Skip to contentSkip to conversation

ARM: dts: nuvoton: Update Quanta GSJ BMC Device Tree.

PATCH Superseded Fran Hsu 2 participants 2 messages Jun 11, 2019 – Jun 12, 2019 Device tree bindings

v7 of 8 Superseded Latest is v8 →

lore
Share & tools
lore

Fran Hsu

author
#0 lore raw

PATCH v7 1/1 ARM: dts: nuvoton: Update Quanta GSJ BMC Device Tree.

This patch cleans up the warning message when build GSJ device tree. Remove the part of i2c-slave-mqueue from GSJ device tree.

Tested:
Build Quanta GSJ image and load on the GSJ BMC module. Ensure that BMC boots to console successful.

---
 arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)
arch/arm/boot/dts/nuvoton-npcm730-gsj.dts +3 -15
index 380d0d382395..497f46d690e9 100644
@@ -5,7 +5,7 @@
 #include "nuvoton-npcm730.dtsi"
 #include "nuvoton-npcm730-gsj-gpio.dtsi"
 / {
-	model = "Quanta GSJ Board (Device Tree v11)";
+	model = "Quanta GSJ Board (Device Tree v12)";
 	compatible = "nuvoton,npcm750";
 
 	aliases {
@@ -300,26 +300,14 @@
 				#address-cells = <1>;
 				#size-cells = <0>;
 				bus-frequency = <100000>;
-				status = "okay";
-
-				ipmb@40000010 {
-					compatible = "slave-mqueue";
-					reg = <0x40000010>;
-					status = "okay";
-				};
+				status = "disabled";
 			};
 
 			i2c14: i2c@8e000 {
 				#address-cells = <1>;
 				#size-cells = <0>;
 				bus-frequency = <100000>;
-				status = "okay";
-
-				ipmb@40000012 {
-					compatible = "slave-mqueue";
-					reg = <0x40000012>;
-					status = "okay";
-				};
+				status = "disabled";
 			};
 
 			i2c15: i2c@8f000 {
Signature · 1 line
2.21.0
#1 lore raw
Quoted 28 lines · Fran Hsu

This patch cleans up the warning message when build GSJ device tree. Remove the part of i2c-slave-mqueue from GSJ device tree.

Tested:
Build Quanta GSJ image and load on the GSJ BMC module. Ensure that BMC boots to console successful.

---
 arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)
arch/arm/boot/dts/nuvoton-npcm730-gsj.dts +1 -1
index 380d0d382395..497f46d690e9 100644
@@ -5,7 +5,7 @@
 #include "nuvoton-npcm730.dtsi"
 #include "nuvoton-npcm730-gsj-gpio.dtsi"
 / {
-       model = "Quanta GSJ Board (Device Tree v11)";
+       model = "Quanta GSJ Board (Device Tree v12)";
        compatible = "nuvoton,npcm750";
 
        aliases {
@@ -300,26 +300,14 @@
                                #address-cells = <1>;

arch/arm/boot/dts/nuvoton-npcm730-gsj.dts line 303

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm730-gsj.dts +1 -7
                                #size-cells = <0>;
                                bus-frequency = <100000>;
-                               status = "okay";
-
-                               ipmb@40000010 {
-                                       compatible = "slave-mqueue";
-                                       reg = <0x40000010>;
-                                       status = "okay";
-                               };
+                               status = "disabled";

There's no reason to have the node listed if you're setting it to disabled in the dts.

A better cleanup would be to put the description of the i2c buses in the dtsi, with the nodes disabled. Then in your dts you enable the nodes that are in use, and add the attached i2c devices.

Quoted 20 lines
arch/arm/boot/dts/nuvoton-npcm730-gsj.dts +1 -8
                        };
 
                        i2c14: i2c@8e000 {
                                #address-cells = <1>;
                                #size-cells = <0>;
                                bus-frequency = <100000>;
-                               status = "okay";
-
-                               ipmb@40000012 {
-                                       compatible = "slave-mqueue";
-                                       reg = <0x40000012>;
-                                       status = "okay";
-                               };
+                               status = "disabled";
                        };
 
                        i2c15: i2c@8f000 {
--

2.21.0