Skip to contentSkip to conversation

NTB: test: remove a duplicate check

PATCH In review Dan Carpenter 2 participants 3 messages Jun 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NTB: test: remove a duplicate check

We already verified that the "nm->isr_ctx" allocation succeeded so there is no need to check again here.

Fixes a6bed7a54165 ("NTB: Introduce NTB MSI Test Client")

---
Hey Logan, can pick a patch prefix when you're introducing a new module? "[PATCH] NTB/test: Introduce NTB MSI Test Client" or whatever.

 drivers/ntb/test/ntb_msi_test.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/ntb/test/ntb_msi_test.c +0 -3
index 99d826ed9c34..9ba3c3162cd0 100644
@@ -372,9 +372,6 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)
 	if (ret)
 		goto remove_dbgfs;
 
-	if (!nm->isr_ctx)
-		goto remove_dbgfs;
-
 	ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);
 
 	return 0;
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

,,

Quoted 5 lines · Dan Carpenter

We already verified that the "nm->isr_ctx" allocation succeeded so there is no need to check again here.

Fixes a6bed7a54165 ("NTB: Introduce NTB MSI Test Client")

Hmm, yup, not sure how that slipped through, must have been a bad rebase or something. Thanks Dan!

Quoted 3 lines

---
Hey Logan, can pick a patch prefix when you're introducing a new module? "[PATCH] NTB/test: Introduce NTB MSI Test Client" or whatever.

I don't quite follow you there. NTB doesn't really have a good standard for prefixes. NTB/test might have made sense.

Logan

#2 lore raw

It's not a huge deal obviously but your commit was a6bed7a54165 ("NTB:
Introduce NTB MSI Test Client") but you know that if I had sent a patch called ("NTB: remove a duplicate check") people would have correctly complained because the patch prefix is too vague.

What I'm saying is we do this all the time:

[PATCH] NTB: add a new foobazle driver

But it should be:

[PATCH] NTB: foobazle: add a new foobazle driver

Then I can just copy and paste your patch prefix instead of trying invent one.

regards,
dan carpenter