Skip to contentSkip to conversation

ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250

PATCH In review Krzysztof Kozlowski 4 participants 14 messages Jun 21, 2019 – Jun 24, 2019

Subsystems (3)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH v2 1/7 ARM: dts: exynos: Add GPU/Mali 400 node to Exynos3250

Add nodes for GPU (Mali 400) to Exynos3250. This is still limited and not tested:
1. No dynamic voltage and frequency scaling,
2. Not sure what to do with CLK_G3D clock responsible for gating entire IP block (it is now being disabled as unused).

---

Changes since v1:
1. Use samsung,exynos4210-mali compatible
2. Use CLK_G3D as bus clock (clock for entire IP block)

---
 arch/arm/boot/dts/exynos3250-artik5.dtsi |  5 ++++
 arch/arm/boot/dts/exynos3250-monk.dts    |  5 ++++
 arch/arm/boot/dts/exynos3250-rinato.dts  |  5 ++++
 arch/arm/boot/dts/exynos3250.dtsi        | 33 ++++++++++++++++++++++++
 4 files changed, 48 insertions(+)
arch/arm/boot/dts/exynos3250-artik5.dtsi +5 -0
index ace50e194a45..dee35e3a5c4b 100644
@@ -59,6 +59,11 @@
 	cpu0-supply = <&buck2_reg>;
 };
 
+&gpu {
+	mali-supply = <&buck3_reg>;
+	status = "okay";
+};
+
 &i2c_0 {
 	#address-cells = <1>;
 	#size-cells = <0>;
arch/arm/boot/dts/exynos3250-monk.dts +5 -0
index e25765500e99..248bd372fe70 100644
@@ -172,6 +172,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&buck3_reg>;
+	status = "okay";
+};
+
 &hsotg {
 	vusb_d-supply = <&ldo15_reg>;
 	vusb_a-supply = <&ldo12_reg>;
arch/arm/boot/dts/exynos3250-rinato.dts +5 -0
index 7479993755da..86c26a4edfd7 100644
@@ -244,6 +244,11 @@
 	};
 };
 
+&gpu {
+	mali-supply = <&buck3_reg>;
+	status = "okay";
+};
+
 &i2c_0 {
 	#address-cells = <1>;
 	#size-cells = <0>;
arch/arm/boot/dts/exynos3250.dtsi +33 -0
index 8ce3a7786b19..c17870a54acf 100644
@@ -126,6 +126,39 @@
 		};
 	};
 
+	gpu: gpu@13000000 {
+		compatible = "samsung,exynos4210-mali", "arm,mali-400";
+		reg = <0x13000000 0x10000>;
+		interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 182 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 181 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "gp",
+				  "gpmmu",
+				  "pp0",
+				  "ppmmu0",
+				  "pp1",
+				  "ppmmu1",
+				  "pp2",
+				  "ppmmu2",
+				  "pp3",
+				  "ppmmu3",
+				  "pmu";
+		clocks = <&cmu CLK_G3D>,
+			 <&cmu CLK_SCLK_G3D>;
+		clock-names = "bus", "core";
+		power-domains = <&pd_g3d>;
+		status = "disabled";
+		/* TODO: operating points for DVFS, assigned clock as 134 MHz */
+	};
+
 	pmu {
 		compatible = "arm,cortex-a7-pmu";
 		interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH v2 2/7 ARM: dts: exynos: Add GPU/Mali 400 node to Exynos4

Add nodes for GPU (Mali 400) to Exynos4210 and Exynos4412. Describe the GPU as much as possible however still few elements are missing:
1. Exynos4210 bus clock is not described in hardware manual therefore the IP gate clock was provided,
2. Exynos4412: Not sure what to do with CLK_G3D clock responsible for gating entire IP block (it is now being disabled as unused),
3. Regulator supplies on Trats board.

Limited testing on Odroid U3 (Exynos4412).

---

Changes since v1:
1. Use samsung,exynos4210-mali compatible
2. Use CLK_G3D as bus clock (clock for entire IP block)
3. Remove some of operating points to match Mali in Tizen kernel. Previously they were taken from datasheet but this information is too generic.
4. Add 533 MHz opp to Exynos4412-prime.

---
 arch/arm/boot/dts/exynos4.dtsi                | 36 +++++++++++++++++++
 arch/arm/boot/dts/exynos4210-origen.dts       |  5 +++
 arch/arm/boot/dts/exynos4210-trats.dts        |  4 +++
 .../boot/dts/exynos4210-universal_c210.dts    |  5 +++
 arch/arm/boot/dts/exynos4210.dtsi             | 17 +++++++++
 .../boot/dts/exynos4412-itop-scp-core.dtsi    |  5 +++
 arch/arm/boot/dts/exynos4412-midas.dtsi       |  5 +++
 .../boot/dts/exynos4412-odroid-common.dtsi    |  5 +++
 arch/arm/boot/dts/exynos4412-prime.dtsi       |  7 ++++
 arch/arm/boot/dts/exynos4412.dtsi             | 25 +++++++++++++
 10 files changed, 114 insertions(+)
arch/arm/boot/dts/exynos4.dtsi +36 -0
index 36ccf227434d..ceaa169032c8 100644
@@ -51,6 +51,42 @@
 		serial3 = &serial_3;
 	};
 
+	gpu: gpu@13000000 {
+		compatible = "samsung,exynos4210-mali", "arm,mali-400";
+		reg = <0x13000000 0x10000>;
+		interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "gp",
+				  "gpmmu",
+				  "pp0",
+				  "ppmmu0",
+				  "pp1",
+				  "ppmmu1",
+				  "pp2",
+				  "ppmmu2",
+				  "pp3",
+				  "ppmmu3",
+				  "pmu";
+		/*
+		 * CLK_G3D is not actually bus clock but a IP-level clock.
+		 * The bus clock is not described in hardware manual.
+		 */
+		clocks = <&clock CLK_G3D>,
+			 <&clock CLK_SCLK_G3D>;
+		clock-names = "bus", "core";
+		power-domains = <&pd_g3d>;
+		status = "disabled";
+	};
+
 	pmu: pmu {
 		compatible = "arm,cortex-a9-pmu";
 		interrupt-parent = <&combiner>;
arch/arm/boot/dts/exynos4210-origen.dts +5 -0
index 36b1edea254a..0d1e1a9c2f6e 100644
@@ -132,6 +132,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&buck3_reg>;
+	status = "okay";
+};
+
 &hsotg {
 	vusb_d-supply = <&ldo3_reg>;
 	vusb_a-supply = <&ldo8_reg>;
arch/arm/boot/dts/exynos4210-trats.dts +4 -0
index 6882480dbaf7..7c39dd1c4d3a 100644
@@ -239,6 +239,10 @@
 	status = "okay";
 };
 
+&gpu {
+	status = "okay";
+};
+
 &hsotg {
 	vusb_d-supply = <&vusb_reg>;
 	vusb_a-supply = <&vusbdac_reg>;
arch/arm/boot/dts/exynos4210-universal_c210.dts +5 -0
index bf092e97e14f..82a8b5449978 100644
@@ -262,6 +262,11 @@
 	};
 };
 
+&gpu {
+	mali-supply = <&buck2_reg>;
+	status = "okay";
+};
+
 &hdmi {
 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";
arch/arm/boot/dts/exynos4210.dtsi +17 -0
index ea0e043cd2b4..bf312ebed01f 100644
@@ -449,6 +449,23 @@
 	samsung,lcd-wb;
 };
 
+&gpu {
+	operating-points-v2 = <&gpu_opp_table>;
+
+	gpu_opp_table: opp_table {
+		compatible = "operating-points-v2";
+
+		opp-160000000 {
+			opp-hz = /bits/ 64 <160000000>;
+			opp-microvolt = <950000>;
+		};
+		opp-267000000 {
+			opp-hz = /bits/ 64 <267000000>;
+			opp-microvolt = <1050000>;
+		};
+	};
+};
+
 &mdma1 {
 	power-domains = <&pd_lcd0>;
 };
arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi +5 -0
index 0038465f38f1..462a5409b1de 100644
@@ -115,6 +115,11 @@
 	cpu0-supply = <&buck2_reg>;
 };
 
+&gpu {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &hsotg {
 	vusb_d-supply = <&ldo15_reg>;
 	vusb_a-supply = <&ldo12_reg>;
arch/arm/boot/dts/exynos4412-midas.dtsi +5 -0
index 4c15cb616cdf..83be3a797411 100644
@@ -453,6 +453,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &hdmi {
 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";
arch/arm/boot/dts/exynos4412-odroid-common.dtsi +5 -0
index 08d3a0a7b4eb..ea55f377d17c 100644
@@ -229,6 +229,11 @@
 	assigned-clock-rates = <0>, <176000000>;
 };
 
+&gpu {
+	mali-supply = <&buck4_reg>;
+	status = "okay";
+};
+
 &hdmi {
 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
 	pinctrl-names = "default";
arch/arm/boot/dts/exynos4412-prime.dtsi +7 -0
index d83fbd4e434c..3731a225f779 100644
@@ -38,3 +38,10 @@
 	cooling-device = <&cpu0 15 15>, <&cpu1 15 15>,
 			 <&cpu2 15 15>, <&cpu3 15 15>;
 };
+
+&gpu_opp_table {
+	opp-533000000 {
+		opp-hz = /bits/ 64 <533000000>;
+		opp-microvolt = <1075000>;
+	};
+};
arch/arm/boot/dts/exynos4412.dtsi +25 -0
index e5c041ec0756..fb53d96934cc 100644
@@ -716,6 +716,31 @@
 	cpu-offset = <0x4000>;
 };
 
+&gpu {
+	operating-points-v2 = <&gpu_opp_table>;
+
+	gpu_opp_table: opp_table {
+		compatible = "operating-points-v2";
+
+		opp-160000000 {
+			opp-hz = /bits/ 64 <160000000>;
+			opp-microvolt = <875000>;
+		};
+		opp-267000000 {
+			opp-hz = /bits/ 64 <267000000>;
+			opp-microvolt = <900000>;
+		};
+		opp-350000000 {
+			opp-hz = /bits/ 64 <350000000>;
+			opp-microvolt = <950000>;
+		};
+		opp-440000000 {
+			opp-hz = /bits/ 64 <440000000>;
+			opp-microvolt = <1025000>;
+		};
+	};
+};
+
 &hdmi {
 	compatible = "samsung,exynos4212-hdmi";
 };
Signature · 1 line
2.17.1
author maintainer
#2 lore raw

PATCH v2 3/7 arm64: dts: exynos: Add GPU/Mali T760 node to Exynos5433

In reply to Krzysztof Kozlowski

Add nodes for GPU (Mali T760) to Exynos5433. Missing element is the cooling device. Not tested on HW.

---

Changes since v1:
1. None

---
 .../dts/exynos/exynos5433-tm2-common.dtsi     |  5 ++
 arch/arm64/boot/dts/exynos/exynos5433.dtsi    | 51 +++++++++++++++++++
 2 files changed, 56 insertions(+)
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +5 -0
index d2de16645e10..6f90b0e62cba 100644
@@ -350,6 +350,11 @@
 	pinctrl-0 = <&te_irq>;
 };
 
+&gpu {
+	mali-supply = <&buck6_reg>;
+	status = "okay";
+};
+
 &hdmi {
 	hpd-gpios = <&gpa3 0 GPIO_ACTIVE_HIGH>;
 	status = "okay";
arch/arm64/boot/dts/exynos/exynos5433.dtsi +51 -0

57 lines not on this page · raw message

Signature · 1 line
2.17.1
author maintainer
#3 lore raw

PATCH v2 4/7 arm64: dts: exynos: Add GPU/Mali T760 node to Exynos7

In reply to Krzysztof Kozlowski

Add nodes for GPU (Mali T760) to Exynos7. Current support for Exynos7 misses a lot, including proper clocks, power domains, frequency and voltage scaling and cooling. However this still can provide basic GPU description. Not tested on HW.

---

Changes since v1:
1. None

---
 arch/arm64/boot/dts/exynos/exynos7-espresso.dts |  5 +++++
 arch/arm64/boot/dts/exynos/exynos7.dtsi         | 11 +++++++++++
 2 files changed, 16 insertions(+)
arch/arm64/boot/dts/exynos/exynos7-espresso.dts +5 -0
index 00dd89b92b42..080e0f56e108 100644
@@ -59,6 +59,11 @@
 	clock-frequency = <24000000>;
 };
 
+&gpu {
+	mali-supply = <&buck6_reg>;
+	status = "okay";
+};
+
 &serial_2 {
 	status = "okay";
 };
arch/arm64/boot/dts/exynos/exynos7.dtsi +11 -0
index 077d23478901..bcb9d8cee267 100644
@@ -78,6 +78,17 @@
 		};
 	};
 
+	gpu: gpu@14ac0000 {
+		compatible = "samsung,exynos5433-mali", "arm,mali-t760";
+		reg = <0x14ac0000 0x5000>;
+		interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 242 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "job", "mmu", "gpu";
+		status = "disabled";
+		/* TODO: operating points for DVFS, cooling device */
+	};
+
 	psci {
 		compatible = "arm,psci-0.2";
 		method = "smc";
Signature · 1 line
2.17.1
author maintainer
#4 lore raw

PATCH v2 5/7 ARM: multi_v7_defconfig: Enable Panfrost and LIMA drivers

In reply to Krzysztof Kozlowski

Enable support for Mali GPU with Panfrost and LIMA drivers. Most of Exynos chipsets come with Mali GPUs:
1. Mali 400 (Exynos3250, Exynos4210, Exynos4412),
2. Mali T628 (Exynos542x).

As Mali GPU is quite popular among ARM vendors, other platforms will benefit as well.

---
 arch/arm/configs/multi_v7_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/configs/multi_v7_defconfig +2 -1
index 6b748f214eae..268161911fc9 100644
@@ -656,6 +656,8 @@ CONFIG_DRM_VC4=m
 CONFIG_DRM_ETNAVIV=m
 CONFIG_DRM_MXSFB=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_LIMA=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB_EFI=y
 CONFIG_FB_WM8505=y
 CONFIG_FB_SH_MOBILE_LCDC=y
@@ -940,7 +942,6 @@ CONFIG_ARCH_TEGRA_2x_SOC=y
 CONFIG_ARCH_TEGRA_3x_SOC=y
 CONFIG_ARCH_TEGRA_114_SOC=y
 CONFIG_ARCH_TEGRA_124_SOC=y
-CONFIG_PM_DEVFREQ=y
 CONFIG_ARM_TEGRA_DEVFREQ=m
 CONFIG_TI_AEMIF=y
 CONFIG_IIO=y
Signature · 1 line
2.17.1
author maintainer
#5 lore raw

PATCH v2 6/7 ARM: exynos_defconfig: Enable Panfrost and LIMA drivers

In reply to Krzysztof Kozlowski

Enable support for Mali GPU with Panfrost and LIMA drivers. Most of Exynos chipsets come with Mali GPUs:
1. Mali 400 (Exynos3250, Exynos4210, Exynos4412),
2. Mali T628 (Exynos542x).

---
 arch/arm/configs/exynos_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/configs/exynos_defconfig +2 -1
index 8d08eed99aa1..f140532ddca7 100644
@@ -212,6 +212,8 @@ CONFIG_DRM_NXP_PTN3460=y
 CONFIG_DRM_PARADE_PS8622=y
 CONFIG_DRM_SII9234=y
 CONFIG_DRM_TOSHIBA_TC358764=y
+CONFIG_DRM_LIMA=y
+CONFIG_DRM_PANFROST=y
 CONFIG_LCD_CLASS_DEVICE=y
 CONFIG_LCD_PLATFORM=y
 CONFIG_BACKLIGHT_PWM=y
@@ -284,7 +286,6 @@ CONFIG_CROS_EC_SPI=y
 CONFIG_COMMON_CLK_MAX77686=y
 CONFIG_COMMON_CLK_S2MPS11=y
 CONFIG_EXYNOS_IOMMU=y
-CONFIG_PM_DEVFREQ=y
 CONFIG_DEVFREQ_GOV_PERFORMANCE=y
 CONFIG_DEVFREQ_GOV_POWERSAVE=y
 CONFIG_DEVFREQ_GOV_USERSPACE=y
Signature · 1 line
2.17.1
author maintainer
#6 lore raw

PATCH v2 7/7 arm64: defconfig: Enable Panfrost driver

In reply to Krzysztof Kozlowski

Enable support for Mali GPU with Panfrost driver, e.g. for Exynos5433 and Exynos7 (having Mali T760).

---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/configs/defconfig +1 -1
index 6b4f5cf23324..972b17239f13 100644
@@ -517,6 +517,7 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_GENERIC=m
@@ -717,7 +718,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
 CONFIG_ARCH_K3_AM6_SOC=y
 CONFIG_SOC_TI=y
 CONFIG_TI_SCI_PM_DOMAINS=y
-CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_EXTCON_USB_GPIO=y
 CONFIG_EXTCON_USBC_CROS_EC=y
 CONFIG_MEMORY=y
Signature · 1 line
2.17.1
#7 lore raw

Re: [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver

Quoted 14 lines · Krzysztof Kozlowski

Enable support for Mali GPU with Panfrost driver, e.g. for Exynos5433 and Exynos7 (having Mali T760).

---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/configs/defconfig +0 -0
index 6b4f5cf23324..972b17239f13 100644

arch/arm64/configs/defconfig CONFIG_DRM_HISI_HIBMC=m · line 520

Quoted 4 lines
arch/arm64/configs/defconfig +1 -0
@@ -517,6 +517,7 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_PANFROST=m

It makes sense to enable lima for arm64 defconfig as well since it's used on number of 64-bit Allwinner SoCs.

Quoted 19 lines
arch/arm64/configs/defconfig +0 -2
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_GENERIC=m
@@ -717,7 +718,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
 CONFIG_ARCH_K3_AM6_SOC=y
 CONFIG_SOC_TI=y
 CONFIG_TI_SCI_PM_DOMAINS=y
-CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_EXTCON_USB_GPIO=y
 CONFIG_EXTCON_USBC_CROS_EC=y
 CONFIG_MEMORY=y
--

2.17.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer
#8 lore raw

Re: [PATCH v2 7/7] arm64: defconfig: Enable Panfrost driver

Quoted 11 lines · Vasily Khoruzhick
Quoted 9 lines · Krzysztof Kozlowski

Enable support for Mali GPU with Panfrost driver, e.g. for Exynos5433 and Exynos7 (having Mali T760).

---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

arch/arm64/configs/defconfig CONFIG_DRM_HISI_HIBMC=m · line 520

Quoted 9 lines
arch/arm64/configs/defconfig +1 -0
index 6b4f5cf23324..972b17239f13 100644
@@ -517,6 +517,7 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_PANFROST=m

It makes sense to enable lima for arm64 defconfig as well since it's used on number of 64-bit Allwinner SoCs.

I wasn't aware that some of ARMv8 SoCs still use Utgard. In such case it makes sense indeed, I will send a follow up.

Thanks for feedback!

Krzysztof

author maintainer
#9 lore raw

PATCH v3 1/1 arm64: defconfig: Enable Panfrost and Lima drivers

In reply to Krzysztof Kozlowski

Enable support for Mali GPU with Panfrost and Lima drivers for:
1. Samsung Exynos5433 and Exynos7 (having Mali T760),
2. Allwiner A64 and H5 (Mali 400/450).

---

Changes since v1:
1. Enable Lima driver

---
 arch/arm64/configs/defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/configs/defconfig +2 -1
index fbbc065415d4..3d31611368af 100644
@@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_LIMA=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_GENERIC=m
@@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
 CONFIG_ARCH_K3_AM6_SOC=y
 CONFIG_SOC_TI=y
 CONFIG_TI_SCI_PM_DOMAINS=y
-CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_EXTCON_USB_GPIO=y
 CONFIG_EXTCON_USBC_CROS_EC=y
 CONFIG_MEMORY=y
Signature · 1 line
2.17.1
#10 lore raw

Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers

Hi Krzysztof,

2019년 6월 23일 (일) 오전 4:20, Krzysztof Kozlowski <[email protected]>님이 작성:

Quoted 29 lines

Enable support for Mali GPU with Panfrost and Lima drivers for:
1. Samsung Exynos5433 and Exynos7 (having Mali T760),
2. Allwiner A64 and H5 (Mali 400/450).

---

Changes since v1:
1. Enable Lima driver

---
 arch/arm64/configs/defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/configs/defconfig +2 -0
index fbbc065415d4..3d31611368af 100644
@@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_LIMA=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_GENERIC=m

arch/arm64/configs/defconfig CONFIG_ARCH_TEGRA_194_SOC=y · line 721

Quoted 4 lines
arch/arm64/configs/defconfig +0 -1
@@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
 CONFIG_ARCH_K3_AM6_SOC=y
 CONFIG_SOC_TI=y
 CONFIG_TI_SCI_PM_DOMAINS=y
-CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y

Exynos5433-tm2 board support the exynos-bus device which used the simple_ondmenad governor of devfreq. Why do you remove this configuration from the defconfig?

Quoted 6 lines
arch/arm64/configs/defconfig +0 -1
 CONFIG_EXTCON_USB_GPIO=y
 CONFIG_EXTCON_USBC_CROS_EC=y
 CONFIG_MEMORY=y
--

2.17.1

Signature · 2 lines
Best Regards,
Chanwoo Choi
author maintainer
#11 lore raw

Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers

Quoted 33 lines · Chanwoo Choi

Hi Krzysztof,

2019년 6월 23일 (일) 오전 4:20, Krzysztof Kozlowski <[email protected]>님이 작성:

Quoted 29 lines

Enable support for Mali GPU with Panfrost and Lima drivers for:
1. Samsung Exynos5433 and Exynos7 (having Mali T760),
2. Allwiner A64 and H5 (Mali 400/450).

---

Changes since v1:
1. Enable Lima driver

---
 arch/arm64/configs/defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/configs/defconfig +2 -0
index fbbc065415d4..3d31611368af 100644
@@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_LIMA=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_GENERIC=m
@@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
Quoted 8 lines

arch/arm64/configs/defconfig CONFIG_ARCH_TEGRA_194_SOC=y · line 721

Quoted 4 lines
arch/arm64/configs/defconfig +0 -1
 CONFIG_ARCH_K3_AM6_SOC=y
 CONFIG_SOC_TI=y
 CONFIG_TI_SCI_PM_DOMAINS=y
-CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y

Exynos5433-tm2 board support the exynos-bus device which used the simple_ondmenad governor of devfreq. Why do you remove this configuration from the defconfig?

It is selected by default by DRM_PANFROST. The difference is that PANFROST selects it as module. The 'y' is chosen because of:
SCSI_UFSHCD [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_DMA [=y]

Best regards,
Krzysztof

#12 lore raw

Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers

Quoted 43 lines · Krzysztof Kozlowski
Quoted 33 lines · Chanwoo Choi

Hi Krzysztof,

2019년 6월 23일 (일) 오전 4:20, Krzysztof Kozlowski <[email protected]>님이 작성:

Quoted 29 lines

Enable support for Mali GPU with Panfrost and Lima drivers for:
1. Samsung Exynos5433 and Exynos7 (having Mali T760),
2. Allwiner A64 and H5 (Mali 400/450).

---

Changes since v1:
1. Enable Lima driver

---
 arch/arm64/configs/defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/configs/defconfig +2 -0
index fbbc065415d4..3d31611368af 100644
@@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_LIMA=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_GENERIC=m
@@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
Quoted 8 lines

arch/arm64/configs/defconfig CONFIG_ARCH_TEGRA_194_SOC=y · line 721

Quoted 4 lines
arch/arm64/configs/defconfig +0 -1
 CONFIG_ARCH_K3_AM6_SOC=y
 CONFIG_SOC_TI=y
 CONFIG_TI_SCI_PM_DOMAINS=y
-CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y

Exynos5433-tm2 board support the exynos-bus device which used the simple_ondmenad governor of devfreq. Why do you remove this configuration from the defconfig?

Quoted 3 lines

It is selected by default by DRM_PANFROST. The difference is that PANFROST selects it as module. The 'y' is chosen because of:
SCSI_UFSHCD [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_DMA [=y]

When I tried to find the history of CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND for defconfig, the following patch[1] added this configuration.
[1] b972ff75f2938c39e2205c23ea0e531d36b27f86
- "arm64: defconfig: Enable UFS on msm8996"

I think that this patch will affect the opration of 'USF on msm8998'.

Signature · 8 lines
Best Regards,
Chanwoo Choi
Samsung Electronics

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#13 lore raw

Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers

Quoted 49 lines · Chanwoo Choi
Quoted 43 lines · Krzysztof Kozlowski
Quoted 33 lines · Chanwoo Choi

Hi Krzysztof,

2019년 6월 23일 (일) 오전 4:20, Krzysztof Kozlowski <[email protected]>님이 작성:

Quoted 29 lines

Enable support for Mali GPU with Panfrost and Lima drivers for:
1. Samsung Exynos5433 and Exynos7 (having Mali T760),
2. Allwiner A64 and H5 (Mali 400/450).

---

Changes since v1:
1. Enable Lima driver

---
 arch/arm64/configs/defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/configs/defconfig +2 -0
index fbbc065415d4..3d31611368af 100644
@@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=m
 CONFIG_DRM_HISI_KIRIN=m
 CONFIG_DRM_MESON=m
 CONFIG_DRM_PL111=m
+CONFIG_DRM_LIMA=m
+CONFIG_DRM_PANFROST=m
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_GENERIC=m
@@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=y
Quoted 8 lines

arch/arm64/configs/defconfig CONFIG_ARCH_TEGRA_194_SOC=y · line 721

Quoted 4 lines
arch/arm64/configs/defconfig +0 -1
 CONFIG_ARCH_K3_AM6_SOC=y
 CONFIG_SOC_TI=y
 CONFIG_TI_SCI_PM_DOMAINS=y
-CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y

Exynos5433-tm2 board support the exynos-bus device which used the simple_ondmenad governor of devfreq. Why do you remove this configuration from the defconfig?

Quoted 3 lines

It is selected by default by DRM_PANFROST. The difference is that PANFROST selects it as module. The 'y' is chosen because of:
SCSI_UFSHCD [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_DMA [=y]

Quoted 6 lines

When I tried to find the history of CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND for defconfig, the following patch[1] added this configuration.
[1] b972ff75f2938c39e2205c23ea0e531d36b27f86
- "arm64: defconfig: Enable UFS on msm8996"

I think that this patch will affect the opration of 'USF on msm8998'.

Hi Chanwoo,

Thanks for the feedback. Unfortunately I do not see how removing a dependency will affect that SCSI_UFSHCD. The DEVFREQ_GOV_SIMPLE_ONDEMAND is still built in, exactly the same as before...

Best regards,
Krzysztof