Skip to contentSkip to conversation

drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

PATCH Superseded Matthias Kaehlcke 2 participants 3 messages Jul 18, 2019 – Jul 19, 2019

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller

The DDC/CI protocol involves sending a multi-byte request to the display via I2C, which is typically followed by a multi-byte response. The internal I2C controller only allows single byte reads/writes or reads of 8 sequential bytes, hence DDC/CI is not supported when the internal I2C controller is used. The I2C transfers complete without errors, however the data in the response is garbage. Abort transfers to/from slave address 0x37 (DDC) with -EOPNOTSUPP, to make it evident that the communication is failing.

---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +8 -0
index 045b1b13fd0e..e49402ebd56f 100644
@@ -35,6 +35,7 @@
 
 #include <media/cec-notifier.h>
 
+#define DDC_I2C_ADDR		0x37
 #define DDC_SEGMENT_ADDR	0x30
 
 #define HDMI_EDID_LEN		512
@@ -322,6 +323,13 @@ static int dw_hdmi_i2c_xfer(struct i2c_adapter *adap,
 	u8 addr = msgs[0].addr;
 	int i, ret = 0;
 
+	if (addr == DDC_I2C_ADDR)
+		/*
+		 * The internal I2C controller does not support the multi-byte
+		 * read and write operations needed for DDC/VCP.
+		 */
+		return -EOPNOTSUPP;
+
 	dev_dbg(hdmi->dev, "xfer: num: %d, addr: %#x\n", num, addr);
 
 	for (i = 0; i < num; i++) {
Signature · 1 line
2.22.0.657.g960e92d24f-goog
#1 lore raw

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c line 38

Quoted 9 lines · Matthias Kaehlcke
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +1 -0
index 045b1b13fd0e..e49402ebd56f 100644
@@ -35,6 +35,7 @@
 
 #include <media/cec-notifier.h>
 
+#define DDC_I2C_ADDR		0x37

This confused the heck out of me to read, DDC by definition happens over I2C and this one address is just for a specific subset of DDC. Perhaps this would be clearer if it was named DDC_CI_ADDR.

- ajax

#2 lore raw
Quoted 8 lines · Adam Jackson
Quoted 6 lines · Matthias Kaehlcke
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +0 -0
index 045b1b13fd0e..e49402ebd56f 100644
@@ -35,6 +35,7 @@
 
Quoted 7 lines

drivers/gpu/drm/bridge/synopsys/dw-hdmi.c line 38

Quoted 3 lines
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +1 -0
 #include <media/cec-notifier.h>
 
+#define DDC_I2C_ADDR		0x37

This confused the heck out of me to read, DDC by definition happens over I2C and this one address is just for a specific subset of DDC. Perhaps this would be clearer if it was named DDC_CI_ADDR.

I was also a bit confused about the terminology, some places call 0x37 the DDC address and 0x50 the EDID address.

DDC_CI_ADDR sounds good to me, thanks for the suggestion!

I'll wait a day or two before respinning, for if there are more comments.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel