Skip to contentSkip to conversation

drm/panfrost: Reduce the amount of logs on deferred probe

PATCH RESEND Superseded Krzysztof Kozlowski 2 participants 3 messages Sep 9, 2019 – Sep 23, 2019

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 drm/panfrost: Reduce the amount of logs on deferred probe

There is no point to print deferred probe (and its failures to get resources) as an error.

In case of multiple probe tries this would pollute the dmesg.

---
 drivers/gpu/drm/panfrost/panfrost_device.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/panfrost/panfrost_device.c +3 -1
index 46b0b02e4289..2252147bc285 100644
@@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
 		pfdev->regulator = NULL;
 		if (ret == -ENODEV)
 			return 0;
-		dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(pfdev->dev, "failed to get regulator: %d\n",
+				ret);
 		return ret;
 	}
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 6 lines · Krzysztof Kozlowski

There is no point to print deferred probe (and its failures to get resources) as an error.

In case of multiple probe tries this would pollute the dmesg.

Looks like a good idea, however from what I can tell you haven't completely silenced the 'error' as the return from panfrost_regulator_init() will be -EPROBE_DEFER causing another dev_err() output:

        err = panfrost_regulator_init(pfdev);
        if (err) {
                dev_err(pfdev->dev, "regulator init failed %d\n", err);
                goto err_out0;
        }

Can you fix that up as well? Or indeed drop it altogether since panfrost_regulator_init() already outputs an appropriate message.

Steve

Quoted 20 lines
---
 drivers/gpu/drm/panfrost/panfrost_device.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/panfrost/panfrost_device.c +3 -1
index 46b0b02e4289..2252147bc285 100644
@@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
 		pfdev->regulator = NULL;
 		if (ret == -ENODEV)
 			return 0;
-		dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(pfdev->dev, "failed to get regulator: %d\n",
+				ret);
 		return ret;
 	}
 
#2 lore raw
Quoted 13 lines · Steven Price
Quoted 6 lines · Krzysztof Kozlowski

There is no point to print deferred probe (and its failures to get resources) as an error.

In case of multiple probe tries this would pollute the dmesg.

Looks like a good idea, however from what I can tell you haven't completely silenced the 'error' as the return from panfrost_regulator_init() will be -EPROBE_DEFER causing another dev_err() output:

Quoted 8 lines
        err = panfrost_regulator_init(pfdev);
        if (err) {
                dev_err(pfdev->dev, "regulator init failed %d\n", err);
                goto err_out0;
        }

Can you fix that up as well? Or indeed drop it altogether since panfrost_regulator_init() already outputs an appropriate message.

I'll drop this error message then. Thanks for feedback!

Best regards,
Krzysztof