Fixes for hostapd/wpa_supplicant packages
v2 cover Fixes for hostapd/wpa_supplicant packages
Hi Thomas and all,
New wpa_supplicant v2.9 enables by default in its defconfig several features for WPA3 support and AP mode:
- WPA3: CONFIG_OWE, CONFIG_SAE, CONFIG_DPP
- AP: CONFIG_AP, CONFIG_P2P, CONFIG_WIFI_DISPLAY
WPA3 features add openssl to wpa_supplicant dependencies. The first two patches add Config.in option for WPA3 support in both hostapd and wpa_supplicant. When this option is selected, then openssl is also selected and WPA3 features are enabled in hostapd/wpa_s configuration files.
AP features make sense only for wpa_supplicant drivers supporting AP mode. For instance, if only WEXT driver is enabled, then those features should be explicitely disabled from hostapd/wpa_s configuration files. The 3rd patch explicitely disables AP features in wpa_supplicant configuration file unless they are requested by Config.in options.
These changes are supposed to fix the following two types of issues listed in daily build results for 2019-09-06:
- wpa_supplicant-2.9 build issues
-- undefined references to hostapd_is_dfs_required and more
- defconfig board issues (orangepi and other boards) -- missing openssl headers
Regards,
Sergey
Changes v1 -> v2
- add patch fixing AP mode options for wpa_supplicant
- update commit messages
Sergey Matyukevich (3):
package/wpa_supplicant: add Config.in option enabling WPA3 support package/hostapd: add Config.in option enabling WPA3 support package/wpa_supplicant: fix AP mode settings
package/hostapd/Config.in | 7 +++++++ package/hostapd/hostapd.mk | 11 +++++++++++ package/wpa_supplicant/Config.in | 7 +++++++ package/wpa_supplicant/wpa_supplicant.mk | 18 ++++++++++++++++++ 4 files changed, 43 insertions(+)
Signature · 1 line
2.23.0
PATCH v2 1/3 package/wpa_supplicant: add Config.in option for WPA3 support
New wpa_supplicant v2.9 enables by default WPA3 features in defconfig. Meanwhile building those features requires openssl.
This patch adds Config.in option for WPA3 support in wpa_supplicant. When this option is selected, libopenssl is also selected and WPA3 features OWE, SAE, DPP are enabled in wpa_supplicant .config file. When this feature is deselected, then all the above WPA3 options are disabled.
--- package/wpa_supplicant/Config.in | 7 +++++++ package/wpa_supplicant/wpa_supplicant.mk | 12 ++++++++++++ 2 files changed, 19 insertions(+)
package/wpa_supplicant/Config.in +7 -0
@@ -81,6 +81,13 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WPS help Enable support for Wi-Fi Protected Setup (WPS). +config BR2_PACKAGE_WPA_SUPPLICANT_WPA3 + bool "Enable WPA3 support" + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL + help + Enable WPA3 support including OWE, SAE, DPP + config BR2_PACKAGE_WPA_SUPPLICANT_CLI bool "Install wpa_cli binary" help
package/wpa_supplicant/wpa_supplicant.mk +12 -0
@@ -88,6 +88,18 @@ ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WPS),y) WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_WPS endif +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WPA3),y) +WPA_SUPPLICANT_CONFIG_ENABLE += \ + CONFIG_DPP \ + CONFIG_SAE \ + CONFIG_OWE +else +WPA_SUPPLICANT_CONFIG_DISABLE += \ + CONFIG_DPP \ + CONFIG_SAE \ + CONFIG_OWE +endif + # Try to use openssl if it's already available ifeq ($(BR2_PACKAGE_LIBOPENSSL),y) WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libopenssl
Signature · 1 line
2.23.0
PATCH v2 2/3 package/hostapd: add Config.in option for WPA3 support
In reply to Sergey MatyukevichNew hostapd v2.9 supports WPA3 features such as OWE, SAE, DPP. Those features are disabled by default in defconfig, so no dependency from openssl is requried unless WPA3 support is enabled.
This patch adds Config.in option for WPA3 support in hostapd. When this option is selected, libopenssl is also selected and WPA3 features including OWE, SAE, DPP are enabled in hostapd .config file. When this option is deselected, then WPA3 options are disabled.
--- package/hostapd/Config.in | 7 +++++++ package/hostapd/hostapd.mk | 11 +++++++++++ 2 files changed, 18 insertions(+)
package/hostapd/Config.in +7 -0
@@ -74,6 +74,13 @@ config BR2_PACKAGE_HOSTAPD_WPS help Enable support for Wi-Fi Protected Setup. +config BR2_PACKAGE_HOSTAPD_WPA3 + bool "Enable WPA3 support" + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL + help + Enable WPA3 support including OWE, SAE, DPP + config BR2_PACKAGE_HOSTAPD_VLAN bool "Enable VLAN support" default y
package/hostapd/hostapd.mk +11 -0
@@ -79,6 +79,17 @@ ifeq ($(BR2_PACKAGE_HOSTAPD_WPS),y) HOSTAPD_CONFIG_ENABLE += CONFIG_WPS endif +ifeq ($(BR2_PACKAGE_HOSTAPD_WPA3),y) +HOSTAPD_CONFIG_SET += \ + CONFIG_DPP \ + CONFIG_SAE +HOSTAPD_CONFIG_ENABLE += \ + CONFIG_OWE +else +HOSTAPD_CONFIG_DISABLE += \ + CONFIG_OWE +endif + ifeq ($(BR2_PACKAGE_HOSTAPD_VLAN),) HOSTAPD_CONFIG_ENABLE += CONFIG_NO_VLAN endif
Signature · 1 line
2.23.0
PATCH v2 3/3 package/wpa_supplicant: fix AP mode settings
In reply to Sergey MatyukevichNew wpa_supplicant v2.9 enables by default AP, P2P, WIFI_DISPLAY features in defconfig. However these features make sense only for wpa_supplicant drivers supporting AP mode.
That is why, for consistent configuration, these features should be explicitely disabled in wpa_supplicant .config file unless they are requested by Config.in options.
Note that at the moment AP support in Buildroot can be enabled only for NL80211 driver.
--- package/wpa_supplicant/wpa_supplicant.mk | 6 ++++++ 1 file changed, 6 insertions(+)
package/wpa_supplicant/wpa_supplicant.mk +6 -0
@@ -67,10 +67,16 @@ ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_AP_SUPPORT),y) WPA_SUPPLICANT_CONFIG_ENABLE += \ CONFIG_AP \ CONFIG_P2P +else +WPA_SUPPLICANT_CONFIG_DISABLE += \ + CONFIG_AP \ + CONFIG_P2P endif ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIFI_DISPLAY),y) WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_WIFI_DISPLAY +else +WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_WIFI_DISPLAY endif ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y)
Signature · 1 line
2.23.0
PATCH v2 3/3 package/wpa_supplicant: fix AP mode settings
Sergey,
Quoted 5 lines · Sergey Matyukevich
New
wpa_supplicantv2.9 enables by default AP, P2P,WIFI_DISPLAYfeatures in defconfig. However these features make sense only forwpa_supplicantdrivers supporting AP mode.
Quoted 7 lines
That is why, for consistent configuration, these features should be explicitely disabled in
wpa_supplicant.config file unless they are requested by Config.in options.Note that at the moment AP support in Buildroot can be enabled only for NL80211 driver.
Fixes
http://autobuild.buildroot.net/results/d37672374db935ac29953263ec68a2786ee65cc2/
Quoted 27 lines
Signed-off-by Sergey Matyukevich <[email protected]>--- package/wpa_supplicant/wpa_supplicant.mk | 6 ++++++ 1 file changed, 6 insertions(+)package/wpa_supplicant/wpa_supplicant.mk +6
-1@@ -67,10 +67,16 @@ ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_AP_SUPPORT),y) WPA_SUPPLICANT_CONFIG_ENABLE += \ CONFIG_AP \ CONFIG_P2P +else +WPA_SUPPLICANT_CONFIG_DISABLE += \ + CONFIG_AP \ + CONFIG_P2P endif ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIFI_DISPLAY),y) WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_WIFI_DISPLAY +else +WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_WIFI_DISPLAY endif ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING),y) --
Quoted 2 lines
2.23.0
--
Matthew Weber | Associate Director Software Engineer | Commercial Avionics
COLLINS AEROSPACE
400 Collins Road NE, Cedar Rapids, Iowa 52498, USA
Tel: +1 319 295 7349 | FAX: +1 319 263 6099
matthew.weber at collins.com | collinsaerospace.com
CONFIDENTIALITY WARNING: This message may contain proprietary and/or privileged information of Collins Aerospace and its affiliated companies. If you are not the intended recipient, please 1) Do not disclose, copy, distribute or use this message or its contents. 2) Advise the sender by return email. 3) Delete all copies (including all attachments) from your computer. Your cooperation is greatly appreciated.
Any export restricted material should be shared using my matthew.weber at corp.rockwellcollins.com address.
v2 cover Fixes for hostapd/wpa_supplicant packages
In reply to Sergey MatyukevichQuoted 19 lines · Sergey Matyukevich
Hi Thomas and all,
New
wpa_supplicantv2.9 enables by default in its defconfig several features for WPA3 support and AP mode:
- WPA3:CONFIG_OWE,CONFIG_SAE,CONFIG_DPP
- AP:CONFIG_AP,CONFIG_P2P,CONFIG_WIFI_DISPLAYWPA3 features add openssl to
wpa_supplicantdependencies. The first two patches add Config.in option for WPA3 support in both hostapd andwpa_supplicant. When this option is selected, then openssl is also selected and WPA3 features are enabled in hostapd/wpa_s configuration files.AP features make sense only for
wpa_supplicantdrivers supporting AP mode. For instance, if only WEXT driver is enabled, then those features should be explicitely disabled from hostapd/wpa_s configuration files. The 3rd patch explicitely disables AP features inwpa_supplicantconfiguration file unless they are requested by Config.in options.
Quoted 7 lines
These changes are supposed to fix the following two types of issues listed in daily build results for 2019-09-06:
- wpa_supplicant-2.9 build issues
-- undefined references tohostapd_is_dfs_requiredand more
- defconfig board issues (orangepi and other boards) -- missing openssl headers
Series applied to master, thanks. Unfortunately, just too late for the weekly
build of the defconfigs...
Regards,
Arnout
Quoted 21 lines
Regards,
SergeyChanges v1 -> v2
- add patch fixing AP mode options for
wpa_supplicant
- update commit messagesSergey Matyukevich (3):
package/wpa_supplicant: add Config.in option enabling WPA3 support package/hostapd: add Config.in option enabling WPA3 support package/wpa_supplicant: fix AP mode settingspackage/hostapd/Config.in | 7 +++++++ package/hostapd/hostapd.mk | 11 +++++++++++ package/wpa_supplicant/Config.in | 7 +++++++ package/wpa_supplicant/wpa_supplicant.mk | 18 ++++++++++++++++++ 4 files changed, 43 insertions(+)