Fix crash on http
PATCH 1/1 Fix crash on http
From: Gustavo Luiz Duarte <[email protected]>
Don't free file->data on receiving FIN flag since it is used all over without checking. http_close() will be called later to free that memory.
https://bugzilla.redhat.com/show_bug.cgi?id=860834
Signed-off-by Gustavo Luiz Duarte <[email protected]>
Signed-off-by Javier Martinez Canillas <[email protected]>
---
grub-core/net/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/net/http.c +1 -1
@@ -392,7 +392,7 @@ http_establish (struct grub_file *file, grub_off_t offset, int initial) data->sock =grub_net_tcp_open (file->device->net->server,HTTP_PORT , http_receive, - http_err, http_err, + http_err,NULL , file);if (!data->sock) {
Signature · 1 line
2.21.0
Quoted 9 lines · Javier Martinez Canillas
From: Gustavo Luiz Duarte <[email protected]>
Don't free
file->dataon receiving FIN flag since it is used all over without checking.http_close()will be called later to free that memory.https://bugzilla.redhat.com/show_bug.cgi?id=860834
Signed-off-by Gustavo Luiz Duarte <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>
Reviewed-by Daniel Kiper <[email protected]>
If there are no objections I will push that patch, together with the patches reviewed this week and earlier, on the beginning of next week. Well, sounds weird but I hope that you know what I mean... :-)))
Daniel