dt-bindings: iio: ad7192: Fix Regulator Properties
PATCH 1/2 dt-bindings: iio: ad7192: Fix Regulator Properties
The AD7192 binding describes two regulator properties, avdd-supply and dvdd-supply, but describes it as a constant string that must be avdd and dvdd. This is wrong since a *-supply property is actually a phandle, and results in warnings when the example is validated (or any device tree using that device, for that matter).
Let's remove that requirement.
--- Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ---- 1 file changed, 4 deletions(-)
Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +0 -4
@@ -43,13 +43,9 @@ properties: dvdd-supply: description: DVdd voltage supply - items: - - const: dvdd avdd-supply: description: AVdd voltage supply - items: - - const: avdd adi,rejection-60-Hz-enable: description: |
Signature · 1 line
2.23.0
PATCH 2/2 dt-bindings: iio: ad7192: Fix DTC warning in the example
The example contains an SPI bus and device, but doesn't have the appropriate size and address cells size.
This creates a DTC warning when the example is compiled since the default ones will not match what the device uses. Let's add them to remove that warning.
--- Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +3 -0
@@ -95,6 +95,9 @@ required: examples: - | spi0 { + #address-cells = <1>; + #size-cells = <0>; + adc@0 { compatible = "adi,ad7192"; reg = <0>;
Signature · 1 line
2.23.0
Re: [PATCH 2/2] dt-bindings: iio: ad7192: Fix DTC warning in the example
Quoted 7 lines · Maxime Ripard
The example contains an SPI bus and device, but doesn't have the appropriate size and address cells size.
This creates a DTC warning when the example is compiled since the default ones will not match what the device uses. Let's add them to remove that warning.
Quoted 6 lines
Fixes f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")Signed-off-by Maxime Ripard <[email protected]>--- Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 3 +++ 1 file changed, 3 insertions(+)
Applied, thanks.
Rob
Quoted 6 lines · Maxime Ripard
The AD7192 binding describes two regulator properties, avdd-supply and dvdd-supply, but describes it as a constant string that must be avdd and dvdd. This is wrong since a *-supply property is actually a phandle, and results in warnings when the example is validated (or any device tree using that device, for that matter).
Quoted 8 lines
Let's remove that requirement.
Fixes f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")Signed-off-by Maxime Ripard <[email protected]>--- Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ---- 1 file changed, 4 deletions(-)
Applied, thanks.
Rob
Jonathan Cameron
maintainerQuoted 16 lines · On Wed, 2 Oct 2019 14:14:16 -0500 Rob Herring <[email protected]> wrote:
Quoted 6 lines · Maxime Ripard
The AD7192 binding describes two regulator properties, avdd-supply and dvdd-supply, but describes it as a constant string that must be avdd and dvdd. This is wrong since a *-supply property is actually a phandle, and results in warnings when the example is validated (or any device tree using that device, for that matter).
Quoted 8 lines
Let's remove that requirement.
Fixes f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")Signed-off-by Maxime Ripard <[email protected]>--- Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ---- 1 file changed, 4 deletions(-)
Quoted 3 lines
Applied, thanks.
Rob
Thanks for clearing this up.
Jonathan