Skip to contentSkip to conversation

dt-bindings: iio: ad7192: Fix Regulator Properties

PATCH Applied Maxime Ripard 3 participants 5 messages Oct 2, 2019 – Oct 6, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: iio: ad7192: Fix Regulator Properties

The AD7192 binding describes two regulator properties, avdd-supply and dvdd-supply, but describes it as a constant string that must be avdd and dvdd. This is wrong since a *-supply property is actually a phandle, and results in warnings when the example is validated (or any device tree using that device, for that matter).

Let's remove that requirement.

Fixes f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ----
 1 file changed, 4 deletions(-)
Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +0 -4
index 676ec42e1438..9e62f54c891a 100644
@@ -43,13 +43,9 @@ properties:
 
   dvdd-supply:
     description: DVdd voltage supply
-    items:
-      - const: dvdd
 
   avdd-supply:
     description: AVdd voltage supply
-    items:
-      - const: avdd
 
   adi,rejection-60-Hz-enable:
     description: |
Signature · 1 line
2.23.0
#1 lore raw

PATCH 2/2 dt-bindings: iio: ad7192: Fix DTC warning in the example

The example contains an SPI bus and device, but doesn't have the appropriate size and address cells size.

This creates a DTC warning when the example is compiled since the default ones will not match what the device uses. Let's add them to remove that warning.

Fixes f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +3 -0
index 9e62f54c891a..567a33a83dce 100644
@@ -95,6 +95,9 @@ required:
 examples:
   - |
     spi0 {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
       adc@0 {
         compatible = "adi,ad7192";
         reg = <0>;
Signature · 1 line
2.23.0
maintainer Applied
#3 lore raw
In reply to Maxime Ripard
Quoted 6 lines · Maxime Ripard

The AD7192 binding describes two regulator properties, avdd-supply and dvdd-supply, but describes it as a constant string that must be avdd and dvdd. This is wrong since a *-supply property is actually a phandle, and results in warnings when the example is validated (or any device tree using that device, for that matter).

Quoted 8 lines

Let's remove that requirement.

Fixes f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ----
 1 file changed, 4 deletions(-)

Applied, thanks.

Rob

maintainer Applied
#2 lore raw

Re: [PATCH 2/2] dt-bindings: iio: ad7192: Fix DTC warning in the example

In reply to Maxime Ripard
Quoted 7 lines · Maxime Ripard

The example contains an SPI bus and device, but doesn't have the appropriate size and address cells size.

This creates a DTC warning when the example is compiled since the default ones will not match what the device uses. Let's add them to remove that warning.

Quoted 6 lines
Fixes f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 3 +++
 1 file changed, 3 insertions(+)

Applied, thanks.

Rob

maintainer
#4 lore raw
In reply to Rob Herring
Quoted 16 lines · On Wed, 2 Oct 2019 14:14:16 -0500 Rob Herring <[email protected]> wrote:
Quoted 6 lines · Maxime Ripard

The AD7192 binding describes two regulator properties, avdd-supply and dvdd-supply, but describes it as a constant string that must be avdd and dvdd. This is wrong since a *-supply property is actually a phandle, and results in warnings when the example is validated (or any device tree using that device, for that matter).

Quoted 8 lines

Let's remove that requirement.

Fixes f7356e47032c ("dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192")
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 4 ----
 1 file changed, 4 deletions(-)
Quoted 3 lines

Applied, thanks.

Rob

Thanks for clearing this up.

Jonathan