Skip to contentSkip to conversation

x86/resctrl: Add task resctrl information display

PATCH Superseded Chen Yu 3 participants 3 messages Nov 20, 2019 – Nov 22, 2019

Subsystems (4)

v3 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Chen Yu

author
#0 lore raw

PATCH v3 1/1 x86/resctrl: Add task resctrl information display

Monitoring tools that want to find out which resctrl CTRL and MONITOR groups a task belongs to must currently read the "tasks" file in every group until they locate the process ID.

Add an additional file /proc/{pid}/resctrl to provide this information.

For example:
cat /proc/1193/resctrl
CTRL_MON:/ctrl_grp0
MON:/ctrl_grp0/mon_groups/mon_grp0

If the resctrl filesystem has not been mounted, reading /proc/{pid}/resctrl returns an empty string.

---
v2: Reduce indentation level in proc_resctrl_show()
according to Boris's suggestion.
Create the include/linux/resctrl.h header and declare proc_resctrl_show() in this file, so that other architectures would probably use it in the future. Different architectures should implement architectural specific proc_resctrl_show() accordingly.

v3: Return empty string if the resctrl filesystem has
not been mounted per Boris's suggestion. Rename the config from CPU_RESCTRL to PROC_CPU_RESCTRL to better represent its usage. Move PROC_CPU_RESCTRL from arch/Kconfig to fs/proc/Kconfig.
And let PROC_CPU_RESCTRL to be depended on PROC_FS.

---
 arch/x86/Kconfig                       |  1 +
 arch/x86/kernel/cpu/resctrl/rdtgroup.c | 52 ++++++++++++++++++++++++++
 fs/proc/Kconfig                        |  4 ++
 fs/proc/base.c                         |  7 ++++
 include/linux/resctrl.h                | 16 ++++++++
 5 files changed, 80 insertions(+)
 create mode 100644 include/linux/resctrl.h
arch/x86/Kconfig +1 -0
index 8ef85139553f..252364d18887 100644
@@ -455,6 +455,7 @@ config X86_CPU_RESCTRL
 	bool "x86 CPU resource control support"
 	depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD)
 	select KERNFS
+	select PROC_CPU_RESCTRL		if PROC_FS
 	help
 	  Enable x86 CPU resource control support.
 
arch/x86/kernel/cpu/resctrl/rdtgroup.c +52 -0

58 lines not on this page · raw message

fs/proc/Kconfig +4 -0
index cb5629bd5fff..ae96a339d24d 100644
@@ -103,3 +103,7 @@ config PROC_CHILDREN
 config PROC_PID_ARCH_STATUS
 	def_bool n
 	depends on PROC_FS
+
+config PROC_CPU_RESCTRL
+	def_bool n
+	depends on PROC_FS
fs/proc/base.c +7 -0
index ebea9501afb8..0e4b8bf2b986 100644
@@ -94,6 +94,7 @@
 #include <linux/sched/debug.h>
 #include <linux/sched/stat.h>
 #include <linux/posix-timers.h>
+#include <linux/resctrl.h>
 #include <trace/events/oom.h>
 #include "internal.h"
 #include "fd.h"
@@ -3060,6 +3061,9 @@ static const struct pid_entry tgid_base_stuff[] = {
 #endif
 #ifdef CONFIG_CGROUPS
 	ONE("cgroup",  S_IRUGO, proc_cgroup_show),
+#endif
+#ifdef CONFIG_PROC_CPU_RESCTRL
+	ONE("resctrl", S_IRUGO, proc_resctrl_show),
 #endif
 	ONE("oom_score",  S_IRUGO, proc_oom_score),
 	REG("oom_adj",    S_IRUGO|S_IWUSR, proc_oom_adj_operations),
@@ -3460,6 +3464,9 @@ static const struct pid_entry tid_base_stuff[] = {
 #endif
 #ifdef CONFIG_CGROUPS
 	ONE("cgroup",  S_IRUGO, proc_cgroup_show),
+#endif
+#ifdef CONFIG_PROC_CPU_RESCTRL
+	ONE("resctrl", S_IRUGO, proc_resctrl_show),
 #endif
 	ONE("oom_score", S_IRUGO, proc_oom_score),
 	REG("oom_adj",   S_IRUGO|S_IWUSR, proc_oom_adj_operations),
include/linux/resctrl.h new file +16 -0
new file mode 100644
index 000000000000..50b147784d55
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _RESCTRL_H
+#define _RESCTRL_H
+
+#ifdef CONFIG_PROC_CPU_RESCTRL
+
+#include <linux/proc_fs.h>
+
+int proc_resctrl_show(struct seq_file *m,
+		      struct pid_namespace *ns,
+		      struct pid *pid,
+		      struct task_struct *tsk);
+
+#endif
+
+#endif /* _RESCTRL_H */
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Chen Yu

Monitoring tools that want to find out which resctrl CTRL and MONITOR groups a task belongs to must currently read the "tasks" file in every group until they locate the process ID.

Quoted 7 lines

Add an additional file /proc/{pid}/resctrl to provide this information.

For example:
cat /proc/1193/resctrl
CTRL_MON:/ctrl_grp0
MON:/ctrl_grp0/mon_groups/mon_grp0

The formatting is quite ugly and I don't see why this needs to be multiple lines and have these uppercase prefixes.

A task can only be part of one control group and of one monitoring group which is associated to the control group. So just providing:

 1)   ""
 2)   "/"
 3)   "/mon_groups/mon0"
 4)   "/group0"
 5)   "/group0/mon_groups/mon1"

is simple and clear enough, i.e.:

#1: Resctrl is not available

#2: Task is part of the root group, task not associated to any monitoring
group

#3: Task is part of the root group and monitoring group mon0

#4: Task is part of control group group0, task not associated to any
monitoring group

#5: Task is part of control group group0 and monitoring group mon1

Hmm?

Thanks,

tglx

#2 lore raw

Hi Thomas,

Quoted 34 lines · Thomas Gleixner
Quoted 5 lines · Chen Yu

Monitoring tools that want to find out which resctrl CTRL and MONITOR groups a task belongs to must currently read the "tasks" file in every group until they locate the process ID.

Quoted 7 lines

Add an additional file /proc/{pid}/resctrl to provide this information.

For example:
cat /proc/1193/resctrl
CTRL_MON:/ctrl_grp0
MON:/ctrl_grp0/mon_groups/mon_grp0

The formatting is quite ugly and I don't see why this needs to be multiple lines and have these uppercase prefixes.

A task can only be part of one control group and of one monitoring group which is associated to the control group. So just providing:

 1)   ""
 2)   "/"
 3)   "/mon_groups/mon0"
 4)   "/group0"
 5)   "/group0/mon_groups/mon1"

is simple and clear enough, i.e.:

#1: Resctrl is not available

#2: Task is part of the root group, task not associated to any monitoring
group

Quoted 9 lines

#3: Task is part of the root group and monitoring group mon0

#4: Task is part of control group group0, task not associated to any
monitoring group

#5: Task is part of control group group0 and monitoring group mon1

Hmm?

Yes, good idea, this is much more simpler. I'll send the new version out based on this.

Thanks,
Chenyu