Skip to contentSkip to conversation

mm: fix comments related to node reclaim

PATCH Superseded Hao Lee 2 participants 3 messages Nov 25, 2019 – Nov 26, 2019

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Hao Lee

author
#0 lore raw

PATCH 1/1 mm: fix comments related to node reclaim

As zone reclaim has been replaced by node reclaim, this patch fixes related comments.

---
 include/linux/mmzone.h          | 2 +-
 include/uapi/linux/capability.h | 2 +-
 include/uapi/linux/sysctl.h     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
include/linux/mmzone.h +1 -1
index 9e47289a4511..7e3208f4f5bc 100644
@@ -747,7 +747,7 @@ typedef struct pglist_data {
 
 #ifdef CONFIG_NUMA
 	/*
-	 * zone reclaim becomes active if more unmapped pages exist.
+	 * node reclaim becomes active if more unmapped pages exist.
 	 */
 	unsigned long		min_unmapped_pages;
 	unsigned long		min_slab_pages;
include/uapi/linux/capability.h +1 -1
index 240fdb9a60f6..dd6772f16eec 100644
@@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
 /* Allow enabling/disabling tagged queuing on SCSI controllers and sending
    arbitrary SCSI commands */
 /* Allow setting encryption key on loopback filesystem */
-/* Allow setting zone reclaim policy */
+/* Allow setting node reclaim policy */
 
 #define CAP_SYS_ADMIN        21
 
include/uapi/linux/sysctl.h +1 -1
index 87aa2a6d9125..27c1ed2822e6 100644
@@ -195,7 +195,7 @@ enum
 	VM_MIN_UNMAPPED=32,	/* Set min percent of unmapped pages */
 	VM_PANIC_ON_OOM=33,	/* panic at out-of-memory */
 	VM_VDSO_ENABLED=34,	/* map VDSO into new processes? */
-	VM_MIN_SLAB=35,		 /* Percent pages ignored by zone reclaim */
+	VM_MIN_SLAB=35,		 /* Percent pages ignored by node reclaim */
 };
 
 
Signature · 1 line
2.14.5
#1 lore raw
Quoted 28 lines · Hao Lee

As zone reclaim has been replaced by node reclaim, this patch fixes related comments.

---
 include/linux/mmzone.h          | 2 +-
 include/uapi/linux/capability.h | 2 +-
 include/uapi/linux/sysctl.h     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
include/linux/mmzone.h +1 -1
index 9e47289a4511..7e3208f4f5bc 100644
@@ -747,7 +747,7 @@ typedef struct pglist_data {
 
 #ifdef CONFIG_NUMA
 	/*
-	 * zone reclaim becomes active if more unmapped pages exist.
+	 * node reclaim becomes active if more unmapped pages exist.
 	 */
 	unsigned long		min_unmapped_pages;
 	unsigned long		min_slab_pages;
include/uapi/linux/capability.h +0 -0
index 240fdb9a60f6..dd6772f16eec 100644

include/uapi/linux/capability.h struct vfs_ns_cap_data { · line 276

Quoted 5 lines
include/uapi/linux/capability.h +1 -1
@@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
 /* Allow enabling/disabling tagged queuing on SCSI controllers and sending
    arbitrary SCSI commands */
 /* Allow setting encryption key on loopback filesystem */
-/* Allow setting zone reclaim policy */
+/* Allow setting node reclaim policy */

Does this point to the capability for accessing vm.zone_reclaim_mode = 0 sysctl knob ? In that case we should not be changing the name here as the interface still retains the original name 'zone_reclaim_mode'.

Quoted 17 lines
include/uapi/linux/capability.h +0 -0
 #define CAP_SYS_ADMIN        21
 
include/uapi/linux/sysctl.h +1 -1
index 87aa2a6d9125..27c1ed2822e6 100644
@@ -195,7 +195,7 @@ enum
 	VM_MIN_UNMAPPED=32,	/* Set min percent of unmapped pages */
 	VM_PANIC_ON_OOM=33,	/* panic at out-of-memory */
 	VM_VDSO_ENABLED=34,	/* map VDSO into new processes? */
-	VM_MIN_SLAB=35,		 /* Percent pages ignored by zone reclaim */
+	VM_MIN_SLAB=35,		 /* Percent pages ignored by node reclaim */
 };
 
 
author
#2 lore raw
Quoted 13 lines · Anshuman Khandual

include/uapi/linux/capability.h struct vfs_ns_cap_data { · line 276

Quoted 8 lines · Hao Lee
include/uapi/linux/capability.h +1 -1
@@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
 /* Allow enabling/disabling tagged queuing on SCSI controllers and sending
    arbitrary SCSI commands */
 /* Allow setting encryption key on loopback filesystem */
-/* Allow setting zone reclaim policy */
+/* Allow setting node reclaim policy */

Does this point to the capability for accessing vm.zone_reclaim_mode = 0 sysctl knob ? In that case we should not be changing the name here as the interface still retains the original name 'zone_reclaim_mode'.

Yes. This comment should be consistent with sysctl documentation and interface. Thanks for your correction!