mm: fix comments related to node reclaim
Subsystems (4)
PATCH 1/1 mm: fix comments related to node reclaim
As zone reclaim has been replaced by node reclaim, this patch fixes related comments.
--- include/linux/mmzone.h | 2 +- include/uapi/linux/capability.h | 2 +- include/uapi/linux/sysctl.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
include/linux/mmzone.h +1 -1
@@ -747,7 +747,7 @@ typedef struct pglist_data {#ifdef CONFIG_NUMA /* -* zone reclaim becomes active if more unmapped pages exist. +* node reclaim becomes active if more unmapped pages exist. */ unsigned long min_unmapped_pages;unsigned long min_slab_pages;
include/uapi/linux/capability.h +1 -1
@@ -273,7 +273,7 @@ struct vfs_ns_cap_data {/* Allow enabling/disabling tagged queuing on SCSI controllers and sending arbitrary SCSI commands */ /* Allow setting encryption key on loopback filesystem */ -/* Allow setting zone reclaim policy */ +/* Allow setting node reclaim policy */ #define CAP_SYS_ADMIN 21
include/uapi/linux/sysctl.h +1 -1
@@ -195,7 +195,7 @@ enumVM_MIN_UNMAPPED =32 ,/* Set min percent of unmapped pages */ VM_PANIC_ON_OOM =33 ,/* panic at out-of-memory */ VM_VDSO_ENABLED =34 ,/* map VDSO into new processes? */ - VM_MIN_SLAB=35, /* Percent pages ignored by zone reclaim */ + VM_MIN_SLAB=35, /* Percent pages ignored by node reclaim */ };
Signature · 1 line
2.14.5
Quoted 28 lines · Hao Lee
As zone reclaim has been replaced by node reclaim, this patch fixes related comments.
Signed-off-by Hao Lee <[email protected]>--- include/linux/mmzone.h | 2 +- include/uapi/linux/capability.h | 2 +- include/uapi/linux/sysctl.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)include/linux/mmzone.h +1
-1@@ -747,7 +747,7 @@ typedef struct pglist_data {#ifdef CONFIG_NUMA /* -* zone reclaim becomes active if more unmapped pages exist. +* node reclaim becomes active if more unmapped pages exist. */ unsigned long min_unmapped_pages;unsigned long min_slab_pages;include/uapi/linux/capability.h +0
-0
include/uapi/linux/capability.h struct vfs_ns_cap_data { · line 276
Quoted 5 lines
include/uapi/linux/capability.h +1
-1@@ -273,7 +273,7 @@ struct vfs_ns_cap_data {/* Allow enabling/disabling tagged queuing on SCSI controllers and sending arbitrary SCSI commands */ /* Allow setting encryption key on loopback filesystem */ -/* Allow setting zone reclaim policy */ +/* Allow setting node reclaim policy */
Does this point to the capability for accessing vm.zone_reclaim_mode = 0 sysctl knob ? In that case we should not be changing the name here as the interface still retains the original name 'zone_reclaim_mode'.
Quoted 17 lines
include/uapi/linux/capability.h +0
-0#define CAP_SYS_ADMIN 21include/uapi/linux/sysctl.h +1
-1@@ -195,7 +195,7 @@ enumVM_MIN_UNMAPPED =32 ,/* Set min percent of unmapped pages */ VM_PANIC_ON_OOM =33 ,/* panic at out-of-memory */ VM_VDSO_ENABLED =34 ,/* map VDSO into new processes? */ - VM_MIN_SLAB=35, /* Percent pages ignored by zone reclaim */ + VM_MIN_SLAB=35, /* Percent pages ignored by node reclaim */ };
Quoted 13 lines · Anshuman Khandual
include/uapi/linux/capability.h struct vfs_ns_cap_data { · line 276
Quoted 8 lines · Hao Lee
include/uapi/linux/capability.h +1
-1@@ -273,7 +273,7 @@ struct vfs_ns_cap_data {/* Allow enabling/disabling tagged queuing on SCSI controllers and sending arbitrary SCSI commands */ /* Allow setting encryption key on loopback filesystem */ -/* Allow setting zone reclaim policy */ +/* Allow setting node reclaim policy */ Does this point to the capability for accessing vm.zone_reclaim_mode = 0 sysctl knob ? In that case we should not be changing the name here as the interface still retains the original name '
zone_reclaim_mode'.
Yes. This comment should be consistent with sysctl documentation and interface. Thanks for your correction!