Skip to contentSkip to conversation

beagle-x15: add am5729-beagleboneai.dtb

PATCH In review Theodore A. Roth 3 participants 5 messages Jan 2, 2020 – Jan 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 beagle-x15: add am5729-beagleboneai.dtb

---
 conf/machine/beagle-x15.conf | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
conf/machine/beagle-x15.conf +4 -1
index d5e05ec7..0af45a84 100644
@@ -4,7 +4,10 @@
 
 require conf/machine/include/dra7xx.inc
 
-KERNEL_DEVICETREE = "am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb"
+KERNEL_DEVICETREE = " \
+    am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb \
+    am5729-beagleboneai.dtb \
+"
 
 MACHINE_GUI_CLASS = "bigscreen"
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 3 lines · Theodore A. Roth
---
 conf/machine/beagle-x15.conf | 5 ++++-

Why add this to the X15 machine? The Beagebone AI is not an X15, the catch all for AM57xx machines seems to be am57xx-evm.conf, which already has the am5729-beagleboneai.dtb.

Thinking more about this, the defining features of the AI might warrant a new machine conf.

Andrew

Quoted 29 lines
 1 file changed, 4 insertions(+), 1 deletion(-)
conf/machine/beagle-x15.conf +4 -2
index d5e05ec7..0af45a84 100644
@@ -4,7 +4,10 @@
 
 require conf/machine/include/dra7xx.inc
 
-KERNEL_DEVICETREE = "am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb"
+KERNEL_DEVICETREE = " \
+    am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb \
+    am5729-beagleboneai.dtb \
+"
 
 MACHINE_GUI_CLASS = "bigscreen"
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.

View/Reply Online (#12591): https://lists.yoctoproject.org/g/meta-ti/message/12591
Mute This Topic: https://lists.yoctoproject.org/mt/69386296/3619733
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 10 lines · Andrew F. Davis
Quoted 3 lines · Theodore A. Roth
---
 conf/machine/beagle-x15.conf | 5 ++++-

Why add this to the X15 machine? The Beagebone AI is not an X15, the catch all for AM57xx machines seems to be am57xx-evm.conf, which already has the am5729-beagleboneai.dtb.

I tried building an image using the am57xx-evm.conf machine in the first place, but it didn't build the wic image, so I added it to the X15 (since they have the same processor). The X15 machine seemed a good place to put it due to the similarities. Seemed similar to what is going on in the beaglebone.conf machine file (lots of very different boards handled in a single machine file).

Quoted 3 lines

Thinking more about this, the defining features of the AI might warrant a new machine conf.

I'm not opposed to adding a new beagle-ai.conf machine. Looking at the X15 machine conf, it seems that there would not be much different for the BBAI other than possibly MACHINE_GUI_CLASS and SERIAL_CONSOLES.

Any ideas or hints on what would be different in the machine conf for BBAI versus the X15?

I'm also not sure why beagle-x15.conf has UBIFS stuff it it since that board has an eMMC nand flash device on it.

Thanks for the feedback.

Ted Roth

Quoted 33 lines

Andrew

Quoted 29 lines
 1 file changed, 4 insertions(+), 1 deletion(-)
conf/machine/beagle-x15.conf +4 -2
index d5e05ec7..0af45a84 100644
@@ -4,7 +4,10 @@
 
 require conf/machine/include/dra7xx.inc
 
-KERNEL_DEVICETREE = "am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb"
+KERNEL_DEVICETREE = " \
+    am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb \
+    am5729-beagleboneai.dtb \
+"
 
 MACHINE_GUI_CLASS = "bigscreen"
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.

View/Reply Online (#12591): https://lists.yoctoproject.org/g/meta-ti/message/12591
Mute This Topic: https://lists.yoctoproject.org/mt/69386296/3619733
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
Quoted 19 lines · Theodore A. Roth
Quoted 10 lines · Andrew F. Davis
Quoted 3 lines · Theodore A. Roth
---
 conf/machine/beagle-x15.conf | 5 ++++-

Why add this to the X15 machine? The Beagebone AI is not an X15, the catch all for AM57xx machines seems to be am57xx-evm.conf, which already has the am5729-beagleboneai.dtb.

I tried building an image using the am57xx-evm.conf machine in the first place, but it didn't build the wic image, so I added it to the X15 (since they have the same processor). The X15 machine seemed a good place to put it due to the similarities. Seemed similar to what is going on in the beaglebone.conf machine file (lots of very different boards handled in a single machine file).

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

Thinking more about this, the defining features of the AI might warrant a new machine conf.

I'm not opposed to adding a new beagle-ai.conf machine. Looking at the X15 machine conf, it seems that there would not be much different for the BBAI other than possibly MACHINE_GUI_CLASS and SERIAL_CONSOLES.

Seems the only difference is in the display (the serial console looks the same for both).

The AM57xx-EVM is basically just an x15 but with a touchscreen attached:

MACHINE_FEATURES += "touchscreen"

The X15 on the other-hand uses HDMI:

MACHINE_GUI_CLASS = "bigscreen"

If we can remove these differences (auto detect them in userspace or something), then we can combine am57xx-evm.conf and beagle-x15.conf into just one machine target, which to me is the best way to it (reduce targets means less testing, etc..)

Quoted 2 lines

Any ideas or hints on what would be different in the machine conf for BBAI versus the X15?

Looks like for your wic image IMAGE_FSTYPES could be changed from "tar.xz" to "tar.xz wic.xz" so both are generated using the am57xx-evm.conf target. What do you use the wic image for anyway, I'm not familiar with it?

Quoted 4 lines

I'm also not sure why beagle-x15.conf has UBIFS stuff it it since that board has an eMMC nand flash device on it.

Possibly left over from when it was forked from am57xx-evm.conf. So as above, re-combining to one superset machine will help prevent this kind of thing.

Andrew

Quoted 37 lines

Thanks for the feedback.

Ted Roth

Quoted 33 lines

Andrew

Quoted 29 lines
 1 file changed, 4 insertions(+), 1 deletion(-)
conf/machine/beagle-x15.conf +4 -2
index d5e05ec7..0af45a84 100644
@@ -4,7 +4,10 @@
 
 require conf/machine/include/dra7xx.inc
 
-KERNEL_DEVICETREE = "am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb"
+KERNEL_DEVICETREE = " \
+    am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb \
+    am5729-beagleboneai.dtb \
+"
 
 MACHINE_GUI_CLASS = "bigscreen"
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.

View/Reply Online (#12591): https://lists.yoctoproject.org/g/meta-ti/message/12591
Mute This Topic: https://lists.yoctoproject.org/mt/69386296/3619733
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw
In reply to Theodore A. Roth
Quoted 8 lines · Theodore A. Roth
Quoted 7 lines · Andrew F. Davis
Quoted 3 lines · Theodore A. Roth
---
 conf/machine/beagle-x15.conf | 5 ++++-
Quoted 6 lines
Quoted 3 lines

Why add this to the X15 machine? The Beagebone AI is not an X15, the catch all for AM57xx machines seems to be am57xx-evm.conf, which already has the am5729-beagleboneai.dtb.

I tried building an image using the am57xx-evm.conf machine in the first place, but it didn't build the wic image,

Well, wic image type can be added to "am57xx-evm" quite easily.

Quoted 4 lines

so I added it to the X15 (since they have the
same processor). The X15 machine seemed a good place to put it due to the similarities. Seemed similar to what is going on in the beaglebone.conf machine file (lots of very different boards handled in a single machine file).

Both "beaglebone" and "beagle-x15" machine types and configs were added only for user convenience, as it is not very obvious for newcomers that beaglebone == am335x-evm and beagle-x15 == am57xx-evm

Unfortunately, neither beaglebone nor beagle-x15 get enough testing attention, as they are normally tested as part of am335x-evm and am57xx-evm builds.

Another option considered was to simply have those as symlinks poiting to corresponding EVM configs. That would also alleviate the testing deficiency mentioned above.

Quoted 4 lines
Quoted 2 lines

Thinking more about this, the defining features of the AI might warrant a new machine conf.

I'm not opposed to adding a new beagle-ai.conf machine. Looking at

Well, I'm not convinced we need another machine definition that's not getting well tested on its own.

Quoted 2 lines

the X15 machine conf, it seems that there would not be much different for the BBAI other than possibly MACHINE_GUI_CLASS and SERIAL_CONSOLES.

MACHINE_GUI_CLASS is somewhat outdated - it may have been used by X11 before, but right now the only place it's used is in meta-oe linux.inc to control the splash screen logo size. We don't use linux.inc from meta-oe anyway.

The difference in SERIAL_CONSOLES is more significant, but X15 uses the same UART as AM57 EVM, not sure about AI. Either way, different UARTs can be listed in SERIAL_CONSOLES, like we already do for am335x-evm:

+ # Normally AM335 boards use ttyS0, but ICE uses ttyS3, so try both
+ SERIAL_CONSOLES = "115200;ttyS0 115200;ttyS3"

Quoted 5 lines

Any ideas or hints on what would be different in the machine conf for BBAI versus the X15?

I'm also not sure why beagle-x15.conf has UBIFS stuff it it since that board has an eMMC nand flash device on it.

Probably cut-n-paste error.

Signature · 1 line
Denys
Quoted 46 lines

Thanks for the feedback.

Ted Roth

Quoted 27 lines

Andrew

Quoted 23 lines
 1 file changed, 4 insertions(+), 1 deletion(-)
conf/machine/beagle-x15.conf +4 -2
index d5e05ec7..0af45a84 100644
@@ -4,7 +4,10 @@
 
 require conf/machine/include/dra7xx.inc
 
-KERNEL_DEVICETREE = "am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb"
+KERNEL_DEVICETREE = " \
+    am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb am57xx-beagle-x15-revc.dtb \
+    am5729-beagleboneai.dtb \
+"
 
 MACHINE_GUI_CLASS = "bigscreen"
 
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.

Quoted 6 lines
Quoted 6 lines

View/Reply Online (#12591): https://lists.yoctoproject.org/g/meta-ti/message/12591
Mute This Topic: https://lists.yoctoproject.org/mt/69386296/3619733
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12596): https://lists.yoctoproject.org/g/meta-ti/message/12596
Mute This Topic: https://lists.yoctoproject.org/mt/69386296/1051543
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-