Skip to contentSkip to conversation

qemuboot-mips: Enable VGA device

PATCH In review Khem Raj 3 participants 8 messages Jan 10, 2020 – Apr 3, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 qemuboot-mips: Enable VGA device

This helps in booting weston images ( core-image-weston ) with fbdev backend, without this westons initialization of fbdev backend fails because it does not get correct frame buffer settings and exits pre-maturely

---
 meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
 1 file changed, 5 insertions(+)
meta/conf/machine/include/qemuboot-mips.inc +5 -0
index 978820a2e0..52cb28a5d2 100644
@@ -5,3 +5,8 @@ QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty"
 QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
 # Add the 'virtio-rng-pci' device otherwise the guest may run out of entropy
 QB_OPT_APPEND += "-object rng-random,filename=/dev/urandom,id=rng0 -device virtio-rng-pci,rng=rng0"
+
+# For graphics to work we need to define the VGA device as well as the necessary USB devices
+QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
+QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device usb-kbd"
+
Signature · 1 line
2.24.1
author
#1 lore raw

PATCH 2/2 busybox: Update inittab

Add stdin/stdout/stderr symlinks in case when not using hotplug Disable ctrl+alt+del, not used much
Mount swap if defined

---
 meta/recipes-core/busybox/files/inittab | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
meta/recipes-core/busybox/files/inittab +8 -4
index 2bc831c7c6..e8ec2ab68e 100644
@@ -8,11 +8,17 @@
 ::sysinit:/bin/mkdir -p /dev/pts
 ::sysinit:/bin/mount -t devpts devpts /dev/pts
 ::sysinit:/bin/mount -a
-
+::sysinit:/sbin/swapon -a
+null::sysinit:/bin/ln -sf /proc/self/fd /dev/fd
+null::sysinit:/bin/ln -sf /proc/self/fd/0 /dev/stdin
+null::sysinit:/bin/ln -sf /proc/self/fd/1 /dev/stdout
+null::sysinit:/bin/ln -sf /proc/self/fd/2 /dev/stderr
+# set hostname
+null::sysinit:/bin/busybox hostname -F /etc/hostname
 ::sysinit:/etc/init.d/rcS
 
 # Stuff to do before rebooting
-::ctrlaltdel:/sbin/reboot
+#::ctrlaltdel:/sbin/reboot
 ::shutdown:/etc/init.d/rcK
 ::shutdown:/sbin/swapoff -a
 ::shutdown:/bin/umount -a -r
@@ -20,5 +26,3 @@
 # Stuff to do when restarting the init process
 ::restart:/sbin/init
 
-# set hostname
-null::sysinit:/bin/busybox hostname -F /etc/hostname
Signature · 1 line
2.24.1
#2 lore raw

Re: [OE-core] [PATCH 2/2] busybox: Update inittab

Quoted 16 lines · Khem Raj

Add stdin/stdout/stderr symlinks in case when not using hotplug Disable ctrl+alt+del, not used much
Mount swap if defined

---
 meta/recipes-core/busybox/files/inittab | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
meta/recipes-core/busybox/files/inittab +0 -0
index 2bc831c7c6..e8ec2ab68e 100644
@@ -8,11 +8,17 @@
 ::sysinit:/bin/mkdir -p /dev/pts

meta/recipes-core/busybox/files/inittab line 17

Quoted 10 lines
meta/recipes-core/busybox/files/inittab +7 -1
 ::sysinit:/bin/mount -t devpts devpts /dev/pts
 ::sysinit:/bin/mount -a
-
+::sysinit:/sbin/swapon -a
+null::sysinit:/bin/ln -sf /proc/self/fd /dev/fd
+null::sysinit:/bin/ln -sf /proc/self/fd/0 /dev/stdin
+null::sysinit:/bin/ln -sf /proc/self/fd/1 /dev/stdout
+null::sysinit:/bin/ln -sf /proc/self/fd/2 /dev/stderr
+# set hostname
+null::sysinit:/bin/busybox hostname -F /etc/hostname

Trying to send the output of these commands to /dev/null seems to go against the fix previously made to inittab to stop doing that?

https://git.openembedded.org/openembedded-core/commit/?id=82de49b899bca915259ea7ea149f50e1401c2426

Quoted 22 lines
meta/recipes-core/busybox/files/inittab +1 -4
 ::sysinit:/etc/init.d/rcS
 
 # Stuff to do before rebooting
-::ctrlaltdel:/sbin/reboot
+#::ctrlaltdel:/sbin/reboot
 ::shutdown:/etc/init.d/rcK
 ::shutdown:/sbin/swapoff -a
 ::shutdown:/bin/umount -a -r
@@ -20,5 +26,3 @@
 # Stuff to do when restarting the init process
 ::restart:/sbin/init
 
-# set hostname
-null::sysinit:/bin/busybox hostname -F /etc/hostname
--

2.24.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#3 lore raw

Re: [OE-core] [PATCH 2/2] busybox: Update inittab

Quoted 32 lines · Andre McCurdy
Quoted 16 lines · Khem Raj

Add stdin/stdout/stderr symlinks in case when not using hotplug Disable ctrl+alt+del, not used much
Mount swap if defined

---
 meta/recipes-core/busybox/files/inittab | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
meta/recipes-core/busybox/files/inittab +0 -0
index 2bc831c7c6..e8ec2ab68e 100644
@@ -8,11 +8,17 @@
 ::sysinit:/bin/mkdir -p /dev/pts

meta/recipes-core/busybox/files/inittab line 17

Quoted 10 lines
meta/recipes-core/busybox/files/inittab +7 -1
 ::sysinit:/bin/mount -t devpts devpts /dev/pts
 ::sysinit:/bin/mount -a
-
+::sysinit:/sbin/swapon -a
+null::sysinit:/bin/ln -sf /proc/self/fd /dev/fd
+null::sysinit:/bin/ln -sf /proc/self/fd/0 /dev/stdin
+null::sysinit:/bin/ln -sf /proc/self/fd/1 /dev/stdout
+null::sysinit:/bin/ln -sf /proc/self/fd/2 /dev/stderr
+# set hostname
+null::sysinit:/bin/busybox hostname -F /etc/hostname

Trying to send the output of these commands to /dev/null seems to go against the fix previously made to inittab to stop doing that?

Quoted 2 lines

https://git.openembedded.org/openembedded-core/commit/?id=82de49b899bca915259ea7ea149f50e1401c2426

It was to avoid additional messages on stdout, so remove null there should be ok if it fixes initramfs please send a patch

Quoted 22 lines
Quoted 22 lines
meta/recipes-core/busybox/files/inittab +1 -4
 ::sysinit:/etc/init.d/rcS
 
 # Stuff to do before rebooting
-::ctrlaltdel:/sbin/reboot
+#::ctrlaltdel:/sbin/reboot
 ::shutdown:/etc/init.d/rcK
 ::shutdown:/sbin/swapoff -a
 ::shutdown:/bin/umount -a -r
@@ -20,5 +26,3 @@
 # Stuff to do when restarting the init process
 ::restart:/sbin/init
 
-# set hostname
-null::sysinit:/bin/busybox hostname -F /etc/hostname
--

2.24.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw
In reply to Khem Raj
Quoted 15 lines · Khem Raj

This helps in booting weston images ( core-image-weston ) with fbdev backend, without this westons initialization of fbdev backend fails because it does not get correct frame buffer settings and exits pre-maturely

---
 meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
 1 file changed, 5 insertions(+)
meta/conf/machine/include/qemuboot-mips.inc +0 -0
index 978820a2e0..52cb28a5d2 100644

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty" · line 12

Quoted 8 lines
meta/conf/machine/include/qemuboot-mips.inc +5 -0
@@ -5,3 +5,8 @@ QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty"
 QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
 # Add the 'virtio-rng-pci' device otherwise the guest may run out of entropy
 QB_OPT_APPEND += "-object rng-random,filename=/dev/urandom,id=rng0 -device virtio-rng-pci,rng=rng0"
+
+# For graphics to work we need to define the VGA device as well as the necessary USB devices
+QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
+QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device usb-kbd"
+

The change is probably good but it causes consistent failures in out testimage runs for mips and mips64:

https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1429
https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/196
https://autobuilder.yoctoproject.org/typhoon/#/builders/74/builds/1431

all due to errors appearing in the logs.

Cheers,

Richard

author
#5 lore raw
Quoted 32 lines · Richard Purdie

Review

Quoted 11 lines · Khem Raj

This helps in booting weston images ( core-image-weston ) with fbdev backend, without this westons initialization of fbdev backend fails because it does not get correct frame buffer settings and exits pre-maturely

---
 meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
 1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/meta/conf/machine/include/qemuboot-mips.inc

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty" · line 6

Quoted 6 lines

index 978820a2e0..52cb28a5d2 100644

meta/conf/machine/include/qemuboot-mips.inc +0 -0
@@ -5,3 +5,8 @@ QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty"
 QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
 # Add the 'virtio-rng-pci' device otherwise the guest may run out of

entropy

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty" · line 7

Quoted 1 line
meta/conf/machine/include/qemuboot-mips.inc +0 -0
 QB_OPT_APPEND += "-object rng-random,filename=/dev/urandom,id=rng0

-device virtio-rng-pci,rng=rng0"

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty" · line 9

Quoted 2 lines
meta/conf/machine/include/qemuboot-mips.inc +2 -0
+
+# For graphics to work we need to define the VGA device as well as the

necessary USB devices

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 console=tty" · line 12

Quoted 3 lines
meta/conf/machine/include/qemuboot-mips.inc +3 -0
+QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
+QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device usb-kbd"
+

The change is probably good but it causes consistent failures in out testimage runs for mips and mips64:

Quoted 5 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1429
https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/196
https://autobuilder.yoctoproject.org/typhoon/#/builders/74/builds/1431

all due to errors appearing in the logs.

Is it due to glibc 2.31 that we were discussing or a separate issue

Quoted 7 lines

Cheers,

Richard

#6 lore raw
Quoted 42 lines · Khem Raj
Quoted 38 lines · Richard Purdie
Quoted 1 line · Khem Raj

This helps in booting weston images ( core-image-weston ) with

fbdev

Quoted 1 line

backend, without this westons initialization of fbdev backend

fails

Review

Quoted 9 lines

because it does not get correct frame buffer settings and exits pre-maturely

---
 meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
 1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/meta/conf/machine/include/qemuboot-mips.inc

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0

Quoted 4 lines

index 978820a2e0..52cb28a5d2 100644

meta/conf/machine/include/qemuboot-mips.inc +0 -0
@@ -5,3 +5,8 @@ QB_KERNEL_CMDLINE_APPEND = "console=ttyS0

console=tty"

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 6

Quoted 2 lines
meta/conf/machine/include/qemuboot-mips.inc +0 -0
 QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
 # Add the 'virtio-rng-pci' device otherwise the guest may run

out of entropy

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 7

Quoted 1 line
meta/conf/machine/include/qemuboot-mips.inc +0 -0
 QB_OPT_APPEND += "-object rng-

random,filename=/dev/urandom,id=rng0 -device virtio-rng- pci,rng=rng0"

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 9

Quoted 2 lines
meta/conf/machine/include/qemuboot-mips.inc +2 -0
+
+# For graphics to work we need to define the VGA device as well

as the necessary USB devices

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 11

Quoted 2 lines
meta/conf/machine/include/qemuboot-mips.inc +2 -0
+QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
+QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device

usb-kbd"

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 12

Quoted 1 line
meta/conf/machine/include/qemuboot-mips.inc +1 -0
+

The change is probably good but it causes consistent failures in out
testimage runs for mips and mips64:

Quoted 7 lines
Quoted 5 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1429
https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/196
https://autobuilder.yoctoproject.org/typhoon/#/builders/74/builds/1431

all due to errors appearing in the logs.

Is it due to glibc 2.31 that we were discussing or a separate issue

Separate, there are two issues.

Cheers,

Richard

author
#7 lore raw

OK I can reproduce atleast couple of them

Quoted 58 lines · Richard Purdie
Quoted 42 lines · Khem Raj
Quoted 38 lines · Richard Purdie
Quoted 1 line · Khem Raj

This helps in booting weston images ( core-image-weston ) with

fbdev

Quoted 1 line

backend, without this westons initialization of fbdev backend

fails

Review

Quoted 9 lines

because it does not get correct frame buffer settings and exits pre-maturely

---
 meta/conf/machine/include/qemuboot-mips.inc | 5 +++++
 1 file changed, 5 insertions(+)
(quoted diff) +0 -0

b/meta/conf/machine/include/qemuboot-mips.inc

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0

Quoted 4 lines

index 978820a2e0..52cb28a5d2 100644

meta/conf/machine/include/qemuboot-mips.inc +0 -0
@@ -5,3 +5,8 @@ QB_KERNEL_CMDLINE_APPEND = "console=ttyS0

console=tty"

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 6

Quoted 2 lines
meta/conf/machine/include/qemuboot-mips.inc +0 -0
 QB_OPT_APPEND = "-show-cursor -usb -device usb-tablet"
 # Add the 'virtio-rng-pci' device otherwise the guest may run

out of entropy

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 7

Quoted 1 line
meta/conf/machine/include/qemuboot-mips.inc +0 -0
 QB_OPT_APPEND += "-object rng-

random,filename=/dev/urandom,id=rng0 -device virtio-rng- pci,rng=rng0"

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 9

Quoted 2 lines
meta/conf/machine/include/qemuboot-mips.inc +2 -0
+
+# For graphics to work we need to define the VGA device as well

as the necessary USB devices

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 11

Quoted 2 lines
meta/conf/machine/include/qemuboot-mips.inc +2 -0
+QB_OPT_APPEND = "-show-cursor -device VGA,edid=on"
+QB_OPT_APPEND += "-device qemu-xhci -device usb-tablet -device

usb-kbd"

meta/conf/machine/include/qemuboot-mips.inc QB_KERNEL_CMDLINE_APPEND = "console=ttyS0 · line 12

Quoted 1 line
meta/conf/machine/include/qemuboot-mips.inc +1 -0
+

The change is probably good but it causes consistent failures in out
testimage runs for mips and mips64:

Quoted 7 lines
Quoted 5 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/1429
https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/196
https://autobuilder.yoctoproject.org/typhoon/#/builders/74/builds/1431

all due to errors appearing in the logs.

Is it due to glibc 2.31 that we were discussing or a separate issue

Separate, there are two issues.

Cheers,

Richard