Skip to contentSkip to conversation

igc: Fix the typo in comment

PATCH New Sasha Neftin 2 participants 2 messages Jan 20, 2020 – Jan 21, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 igc: Fix the typo in comment

Fix the typo and comment to correspond to the i225 device v1->v2:
Address community comment

---
 drivers/net/ethernet/intel/igc/igc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/igc/igc.h +1 -1
index 5d38d0faeced..cb1362188c2a 100644
@@ -112,7 +112,7 @@ extern char igc_driver_version[];
 #define IGC_RX_HDR_LEN			IGC_RXBUFFER_256
 
 /* Transmit and receive latency (for PTP timestamps) */
-/* FIXME: These values were estimated using the ones that i210 has as
+/* FIXME: These values were estimated using the ones that i225 has as
  * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
  * need to confirm them.
  */
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/1 igc: Fix the typo in comment

Hi Sasha,

Quoted 14 lines · Sasha Neftin

Fix the typo and comment to correspond to the i225 device v1->v2:
Address community comment

---
 drivers/net/ethernet/intel/igc/igc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/igc/igc.h +0 -0
index 5d38d0faeced..cb1362188c2a 100644

drivers/net/ethernet/intel/igc/igc.h extern char igc_driver_version[]; · line 118

Quoted 8 lines
drivers/net/ethernet/intel/igc/igc.h +1 -1
@@ -112,7 +112,7 @@ extern char igc_driver_version[];
 #define IGC_RX_HDR_LEN			IGC_RXBUFFER_256
 
 /* Transmit and receive latency (for PTP timestamps) */
-/* FIXME: These values were estimated using the ones that i210 has as
+/* FIXME: These values were estimated using the ones that i225 has as
  * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
  * need to confirm them.
  */

If you are sending this patch, it means that I couldn't explain myself well enough. The idea of that comment was to point out that the documentation doesn't provide an estimate of those values, so I used the ones from the i210 datasheet.

Cheers,
--
Vinicius