Skip to contentSkip to conversation

igc: Fix the typo in the comment

PATCH Superseded Sasha Neftin 3 participants 3 messages Jan 19, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igc: Fix the typo in the comment

Fix the typo and comment to be correspond to the i225 device

---
 drivers/net/ethernet/intel/igc/igc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/igc/igc.h +1 -1
index 5d38d0faeced..6fb222e76293 100644
@@ -112,7 +112,7 @@ extern char igc_driver_version[];
 #define IGC_RX_HDR_LEN			IGC_RXBUFFER_256
 
 /* Transmit and receive latency (for PTP timestamps) */
-/* FIXME: These values were estimated using the ones that i210 has as
+/* These values were estimated using the ones that i225 has as
  * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
  * need to confirm them.
  */
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 igc: Fix the typo in the comment

Dear Sasha,

Thank you for the patch. The article *the* could be removed from the commit message summary.

Quoted 1 line

Fix typo in comment

Am 19.01.20 um 09:44 schrieb Sasha Neftin:

Quoted 1 line

Fix the typo and comment to be correspond to the i225 device

*to correspond*

Please mention *why* the FIXME is removed. The comment still says, they need to be confirmed. If the values were confirmed in the mean-time, please document in the commit message by whom, and remove the whole comment.

Quoted 10 lines
---
  drivers/net/ethernet/intel/igc/igc.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/igc/igc.h +0 -0
index 5d38d0faeced..6fb222e76293 100644

drivers/net/ethernet/intel/igc/igc.h extern char igc_driver_version[]; · line 118

Quoted 8 lines
drivers/net/ethernet/intel/igc/igc.h +1 -1
@@ -112,7 +112,7 @@ extern char igc_driver_version[];
  #define IGC_RX_HDR_LEN			IGC_RXBUFFER_256
 
  /* Transmit and receive latency (for PTP timestamps) */
-/* FIXME: These values were estimated using the ones that i210 has as
+/* These values were estimated using the ones that i225 has as
   * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
   * need to confirm them.
   */

Kind regards,

Paul

#2 lore raw

PATCH 1/1 igc: Fix the typo in the comment

Quoted 1 line · Paul Menzel

Fix typo in comment

We need to do more tests with PTP tools to confirm that. I will return meanwhile "FIXME". Thanks Paul - I will send v2.