igc: Fix the typo in the comment
Subsystems (2)
PATCH 1/1 igc: Fix the typo in the comment
Fix the typo and comment to be correspond to the i225 device
--- drivers/net/ethernet/intel/igc/igc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/igc/igc.h +1 -1
@@ -112,7 +112,7 @@ extern char igc_driver_version[];#define IGC_RX_HDR_LEN IGC_RXBUFFER_256/* Transmit and receive latency (for PTP timestamps) */ -/* FIXME: These values were estimated using the ones that i210 has as +/* These values were estimated using the ones that i225 has as * basis, they seem to provide good numbers with ptp4l/phc2sys, but we * need to confirm them. */
Signature · 1 line
2.11.0
PATCH 1/1 igc: Fix the typo in the comment
Dear Sasha,
Thank you for the patch. The article *the* could be removed from the commit message summary.
Quoted 1 line
Fix typo in comment
Am 19.01.20 um 09:44 schrieb Sasha Neftin:
Quoted 1 line
Fix the typo and comment to be correspond to the i225 device
*to correspond*
Please mention *why* the FIXME is removed. The comment still says, they need to be confirmed. If the values were confirmed in the mean-time, please document in the commit message by whom, and remove the whole comment.
Quoted 10 lines
Signed-off-by Sasha Neftin <[email protected]>--- drivers/net/ethernet/intel/igc/igc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/intel/igc/igc.h +0
-0
drivers/net/ethernet/intel/igc/igc.h extern char igc_driver_version[]; · line 118
Quoted 8 lines
drivers/net/ethernet/intel/igc/igc.h +1
-1@@ -112,7 +112,7 @@ extern char igc_driver_version[];#define IGC_RX_HDR_LEN IGC_RXBUFFER_256/* Transmit and receive latency (for PTP timestamps) */ -/* FIXME: These values were estimated using the ones that i210 has as +/* These values were estimated using the ones that i225 has as * basis, they seem to provide good numbers with ptp4l/phc2sys, but we * need to confirm them. */
Kind regards,
Paul
Neftin
PATCH 1/1 igc: Fix the typo in the comment
Quoted 1 line · Paul Menzel
Fix typo in comment
We need to do more tests with PTP tools to confirm that. I will return meanwhile "FIXME". Thanks Paul - I will send v2.