fio: remove disabling of compiler optimizations
PATCH 1/1 fio: remove disabling of compiler optimizations
Disabling compiler optimizations affects fio performance by 25-30% so remove this from EXTRA_OECONF. Disabling of optimizations should be machine specific if there are bugs in the code instead of the default.
--- meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 - 1 file changed, 1 deletion(-)
meta-oe/recipes-benchmark/fio/fio_3.18.bb +0 -1
@@ -33,7 +33,6 @@ S = "${WORKDIR}/git" DISABLE_STATIC = "" EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'" -EXTRA_OECONF = "--disable-optimizations" do_configure() { ./configure ${EXTRA_OECONF}
Signature · 1 line
2.17.1
Quoted 4 lines · Jonathan Richardson via Openembedded-core
Disabling compiler optimizations affects fio performance by 25-30% so remove this from
EXTRA_OECONF. Disabling of optimizations should be machine specific if there are bugs in the code instead of the default.
Wrong mailing list ( patches for meta-oe should be sent to [email protected] )
In general when removing a workaround or fix it's also helpful to include a link to the commit which added it, in this case:
https://git.openembedded.org/meta-openembedded/commit/?id=739349da0826221f98648b64b693f9ae33e7d4ea
(FWIW since that crash was seen with a much older version of fio compiled with a now obsolete toolchain it seems perfectly justified to remove it).
Quoted 25 lines
Signed-off-by Jonathan Richardson <[email protected]>--- meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 - 1 file changed, 1 deletion(-)meta-oe/recipes-benchmark/fio/fio_3.18.bb +0
-2@@ -33,7 +33,6 @@ S = "${WORKDIR}/git" DISABLE_STATIC = "" EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'" -EXTRA_OECONF = "--disable-optimizations" do_configure() { ./configure ${EXTRA_OECONF} --2.17.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Sorry, that was a typo. I'll send it to devel with an updated comment. Thanks!
Quoted 45 lines · Andre McCurdy
Quoted 4 lines · Jonathan Richardson via Openembedded-core
Disabling compiler optimizations affects fio performance by 25-30% so remove this from
EXTRA_OECONF. Disabling of optimizations should be machine specific if there are bugs in the code instead of the default.Wrong mailing list ( patches for meta-oe should be sent to [email protected] )
In general when removing a workaround or fix it's also helpful to include a link to the commit which added it, in this case:
https://git.openembedded.org/meta-openembedded/commit/?id=739349da0826221f98648b64b693f9ae33e7d4ea
(FWIW since that crash was seen with a much older version of fio compiled with a now obsolete toolchain it seems perfectly justified to remove it).
Quoted 25 lines
Signed-off-by Jonathan Richardson <[email protected]>--- meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 - 1 file changed, 1 deletion(-)meta-oe/recipes-benchmark/fio/fio_3.18.bb +0
-2@@ -33,7 +33,6 @@ S = "${WORKDIR}/git" DISABLE_STATIC = "" EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'" -EXTRA_OECONF = "--disable-optimizations" do_configure() { ./configure ${EXTRA_OECONF} --2.17.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
✗ patchtest: failure for [meta-oe] fio: remove disabling of compiler optimizations
In reply to Jonathan Richardson== Series Details ==
Series: [meta-oe] fio: remove disabling of compiler optimizations
Revision: 1
URL : https://patchwork.openembedded.org/series/22736/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:
* Patch [meta-oe,1/1] fio: remove disabling of compiler optimizations Issue Series sent to the wrong mailing list [test_target_mailing_list] Suggested fix Check the project's README (meta-oe,1/1) and send the patch to the indicated list
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at c9b5802bbe)
If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe