Skip to contentSkip to conversation

configs: disable eMMC HS200 support on layerscape platforms

PATCH New Yangbo Lu 3 participants 5 messages Mar 3, 2020 – Mar 30, 2020

lore
Share & tools
lore

Yangbo Lu

author
#0 lore raw

PATCH 1/1 configs: disable eMMC HS200 support on layerscape platforms

The eMMC HS200 speed mode on Layerscape platforms has not been supported properly. The eSDHC clock tuning has not been implemented by now. So disable it until it is supported properly in case of any potential issues.

---
 configs/ls1012ardb_tfa_defconfig | 1 -
 configs/ls1028ardb_tfa_defconfig | 1 -
 configs/lx2160ardb_tfa_defconfig | 1 -
 3 files changed, 3 deletions(-)
configs/ls1012ardb_tfa_defconfig +0 -1
index b47a47d..0e994f5 100644
@@ -38,7 +38,6 @@ CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_SATA_CEVA=y
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
configs/ls1028ardb_tfa_defconfig +0 -1
index 3ef5520..7ffd1c3 100644
@@ -45,7 +45,6 @@ CONFIG_I2C_DEFAULT_BUS_NUMBER=0
 CONFIG_I2C_MUX=y
 CONFIG_I2C_MUX_PCA954x=y
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
configs/lx2160ardb_tfa_defconfig +0 -1
index b998cb6..0799cd4 100644
@@ -41,7 +41,6 @@ CONFIG_DM_I2C=y
 CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
 CONFIG_I2C_DEFAULT_BUS_NUMBER=0
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/1 configs: disable eMMC HS200 support on layerscape platforms

Any comments?
Thanks!

Best regards,
Yangbo Lu

Quoted 61 lines

-----Original Message-----
From: Yangbo Lu <[email protected]>
Sent: Tuesday, March 3, 2020 10:33 AM
To: u-boot at lists.denx.de; Priyanka Jain <[email protected]>
Cc: Y.b. Lu <[email protected]>
Subject: [PATCH] configs: disable eMMC HS200 support on layerscape platforms

The eMMC HS200 speed mode on Layerscape platforms has not been supported properly. The eSDHC clock tuning has not been implemented by now. So disable it until it is supported properly in case of any potential issues.

---
 configs/ls1012ardb_tfa_defconfig | 1 -
 configs/ls1028ardb_tfa_defconfig | 1 -
 configs/lx2160ardb_tfa_defconfig | 1 -
 3 files changed, 3 deletions(-)
configs/ls1012ardb_tfa_defconfig +0 -1
index b47a47d..0e994f5 100644
@@ -38,7 +38,6 @@ CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_SATA_CEVA=y
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
configs/ls1028ardb_tfa_defconfig +0 -1
index 3ef5520..7ffd1c3 100644
@@ -45,7 +45,6 @@ CONFIG_I2C_DEFAULT_BUS_NUMBER=0
 CONFIG_I2C_MUX=y
 CONFIG_I2C_MUX_PCA954x=y
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
configs/lx2160ardb_tfa_defconfig +0 -2
index b998cb6..0799cd4 100644
@@ -41,7 +41,6 @@ CONFIG_DM_I2C=y
 CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
 CONFIG_I2C_DEFAULT_BUS_NUMBER=0
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
--

2.7.4

#2 lore raw

PATCH 1/1 configs: disable eMMC HS200 support on layerscape platforms

Hi,

Quoted 18 lines · Y.b. Lu

Any comments?
Thanks!

Best regards,
Yangbo Lu

Quoted 12 lines

-----Original Message-----
From: Yangbo Lu <[email protected]>
Sent: Tuesday, March 3, 2020 10:33 AM
To: u-boot at lists.denx.de; Priyanka Jain <[email protected]>
Cc: Y.b. Lu <[email protected]>
Subject: [PATCH] configs: disable eMMC HS200 support on layerscape platforms

The eMMC HS200 speed mode on Layerscape platforms has not been supported properly. The eSDHC clock tuning has not been implemented by now. So disable it until it is supported properly in case of any potential issues.

If it's not working fine, looks good to me.
BTW, I didn't have tested on its platform. Do you have a plan to fix it?

Quoted 52 lines
Quoted 49 lines
---
 configs/ls1012ardb_tfa_defconfig | 1 -
 configs/ls1028ardb_tfa_defconfig | 1 -
 configs/lx2160ardb_tfa_defconfig | 1 -
 3 files changed, 3 deletions(-)
configs/ls1012ardb_tfa_defconfig +0 -1
index b47a47d..0e994f5 100644
@@ -38,7 +38,6 @@ CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_SATA_CEVA=y
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
configs/ls1028ardb_tfa_defconfig +0 -1
index 3ef5520..7ffd1c3 100644
@@ -45,7 +45,6 @@ CONFIG_I2C_DEFAULT_BUS_NUMBER=0
 CONFIG_I2C_MUX=y
 CONFIG_I2C_MUX_PCA954x=y
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
configs/lx2160ardb_tfa_defconfig +0 -2
index b998cb6..0799cd4 100644
@@ -41,7 +41,6 @@ CONFIG_DM_I2C=y
 CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
 CONFIG_I2C_DEFAULT_BUS_NUMBER=0
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
--

2.7.4

author
#3 lore raw

PATCH 1/1 configs: disable eMMC HS200 support on layerscape platforms

Hi Jaehoon,

Quoted 25 lines

-----Original Message-----
From: Jaehoon Chung <[email protected]>
Sent: Thursday, March 19, 2020 5:01 PM
To: Y.b. Lu <[email protected]>; u-boot at lists.denx.de; Priyanka Jain <[email protected]>
Subject: Re: [PATCH] configs: disable eMMC HS200 support on layerscape platforms

Hi,

Quoted 14 lines · Y.b. Lu

Any comments?
Thanks!

Best regards,
Yangbo Lu

Quoted 8 lines

-----Original Message-----
From: Yangbo Lu <[email protected]>
Sent: Tuesday, March 3, 2020 10:33 AM
To: u-boot at lists.denx.de; Priyanka Jain <[email protected]>
Cc: Y.b. Lu <[email protected]>
Subject: [PATCH] configs: disable eMMC HS200 support on layerscape platforms

Quoted 8 lines
Quoted 4 lines
Quoted 4 lines

The eMMC HS200 speed mode on Layerscape platforms has not been supported properly. The eSDHC clock tuning has not been implemented by now. So disable it until it is supported properly in case of any potential issues.

If it's not working fine, looks good to me.
BTW, I didn't have tested on its platform. Do you have a plan to fix it?

[Yangbo Lu] Because we got issues with HS200 mode in testing, I sent this patch to disable it for now. The tuning support with eSDHC tuning block is in my plan.

Thanks.

Quoted 56 lines
Quoted 52 lines
Quoted 49 lines
---
 configs/ls1012ardb_tfa_defconfig | 1 -
 configs/ls1028ardb_tfa_defconfig | 1 -
 configs/lx2160ardb_tfa_defconfig | 1 -
 3 files changed, 3 deletions(-)
configs/ls1012ardb_tfa_defconfig +0 -1
index b47a47d..0e994f5 100644
@@ -38,7 +38,6 @@ CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_SATA_CEVA=y
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
configs/ls1028ardb_tfa_defconfig +0 -1
index 3ef5520..7ffd1c3 100644
@@ -45,7 +45,6 @@ CONFIG_I2C_DEFAULT_BUS_NUMBER=0
 CONFIG_I2C_MUX=y
 CONFIG_I2C_MUX_PCA954x=y
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
configs/lx2160ardb_tfa_defconfig +0 -2
index b998cb6..0799cd4 100644
@@ -41,7 +41,6 @@ CONFIG_DM_I2C=y
 CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
 CONFIG_I2C_DEFAULT_BUS_NUMBER=0
 CONFIG_DM_MMC=y
-CONFIG_MMC_HS200_SUPPORT=y
 CONFIG_FSL_ESDHC=y
 CONFIG_MTD=y
 CONFIG_DM_SPI_FLASH=y
--

2.7.4

#4 lore raw

PATCH 1/1 configs: disable eMMC HS200 support on layerscape platforms

In reply to Yangbo Lu
Quoted 8 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Yangbo Lu
Sent: Tuesday, March 3, 2020 8:03 AM
To: u-boot at lists.denx.de; Priyanka Jain <[email protected]>
Cc: Y.b. Lu <[email protected]>
Subject: [PATCH] configs: disable eMMC HS200 support on layerscape platforms

Quoted 7 lines

The eMMC HS200 speed mode on Layerscape platforms has not been supported properly. The eSDHC clock tuning has not been implemented by now. So disable it until it is supported properly in case of any potential issues.

---

Applied to u-boot-fsl-qoriq after rebasing. Waiting upstream

Thanks
Priyanka