media: rc: make scancodes 64 bit
Subsystems (2)
Sean Young
maintainerPATCH v2 1/1 media: rc: make scancodes 64 bit
There are many protocols that encode more than 32 bit. We want 64 bit support so that BPF IR decoders can decode more than 32 bit. None of the existing kernel IR decoders/encoders support 64 bit, for now.
The MSC_SCAN event can only contain 32 bit scancodes, so we only generate MSC_SCAN events if the scancode fits into 32 bits. The full 64 bit scancode can be read from the lirc chardev.
Signed-off-by Sean Young <[email protected]>
--- drivers/media/rc/bpf-lirc.c | 5 --- drivers/media/rc/lirc_dev.c | 7 +--- drivers/media/rc/rc-main.c | 80 +++++++++++++++++++++++++++---------- include/media/rc-core.h | 8 ++-- include/media/rc-map.h | 4 +- 5 files changed, 65 insertions(+), 39 deletions(-)
drivers/media/rc/bpf-lirc.c +0 -5
@@ -35,11 +35,6 @@ static const struct bpf_func_proto rc_repeat_proto = { .arg1_type = ARG_PTR_TO_CTX, }; -/* -* Currently rc-core does not support 64-bit scancodes, but there are many -* known protocols with more than 32 bits. So, define the interface as u64 -* as a future-proof. -*/ BPF_CALL_4(bpf_rc_keydown, u32*, sample, u32, protocol, u64, scancode, u32, toggle) {
drivers/media/rc/lirc_dev.c +1 -6
@@ -269,12 +269,7 @@ static ssize_t ir_lirc_transmit_ir(struct file *file, const char __user *buf, goto out_unlock; } -/* -* The scancode field in lirc_scancode is 64-bit simply -* to future-proof it, since there are IR protocols encode -* use more than 32 bits. For now only 32-bit protocols -* are supported. -*/ +/* We only have encoders for 32-bit protocols. */ if (scan.scancode >U32_MAX || !rc_validate_scancode (scan.rc_proto, scan.scancode)) { ret = -EINVAL ;
drivers/media/rc/rc-main.c +58 -22
199 lines not on this page · raw message
include/media/rc-core.h +4 -4
@@ -192,7 +192,7 @@ struct rc_dev {struct timer_list timer_repeat;u32 last_keycode;enum rc_proto last_protocol; -u32 last_scancode; +u64 last_scancode;u8 last_toggle;u32 timeout;u32 min_timeout;
@@ -284,12 +284,12 @@ int devm_rc_register_device(struct device *parent, struct rc_dev *dev);void rc_unregister_device (struct rc_dev *dev);void rc_repeat (struct rc_dev *dev); -void rc_keydown (struct rc_dev *dev,enum rc_proto protocol,u32 scancode, +void rc_keydown (struct rc_dev *dev,enum rc_proto protocol,u64 scancode,u8 toggle);void rc_keydown_notimeout (struct rc_dev *dev,enum rc_proto protocol, -u32 scancode,u8 toggle); +u64 scancode,u8 toggle);void rc_keyup (struct rc_dev *dev); -u32 rc_g_keycode_from_table (struct rc_dev *dev,u32 scancode); +u32 rc_g_keycode_from_table (struct rc_dev *dev,u64 scancode);/* * From rc-raw.c
include/media/rc-map.h +2 -2
@@ -85,11 +85,11 @@/** * struct rc_map_table - represents a scancode/keycode pair * -* @scancode: scan code (u32) +* @scancode: scan code (u64) * @keycode: Linux input keycode */ struct rc_map_table { -u32 scancode; +u64 scancode;u32 keycode; };
Signature · 1 line
2.24.1