Skip to contentSkip to conversation

slimbus: core: Set fwnode for a device when setting of_node

PATCH Superseded Saravana Kannan 3 participants 3 messages Mar 26, 2020 Serial low-power inter-chip media bus (SLIMbus)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 slimbus: core: Set fwnode for a device when setting of_node

When setting the of_node for a newly created device, also set the fwnode. This allows fw_devlink to work for slimbus devices.

Change-Id I5505213f8ecca908860a1ad6bbc275ec0f78e4a6
---
 drivers/slimbus/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/slimbus/core.c +3 -1
index 526e3215d8fe..44228a5b246d 100644
@@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
 	INIT_LIST_HEAD(&sbdev->stream_list);
 	spin_lock_init(&sbdev->stream_list_lock);
 
-	if (node)
+	if (node) {
 		sbdev->dev.of_node = of_node_get(node);
+		sbdev->dev.fwnode = of_fwnode_handle(node);
+	}
 
 	dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
 				  sbdev->e_addr.manf_id,
Signature · 1 line
2.25.1.696.g5e7596f4ac-goog
#1 lore raw
Quoted 5 lines · Saravana Kannan

When setting the of_node for a newly created device, also set the fwnode. This allows fw_devlink to work for slimbus devices.

Change-Id I5505213f8ecca908860a1ad6bbc275ec0f78e4a6

-ENOCHANGEID :(

Reviewed-by on v1 1/1
#2 lore raw
In reply to Saravana Kannan

Thanks for doing this!

Quoted 5 lines · Saravana Kannan

When setting the of_node for a newly created device, also set the fwnode. This allows fw_devlink to work for slimbus devices.

Change-Id I5505213f8ecca908860a1ad6bbc275ec0f78e4a6

Once Change-Id is removed as Greg suggested!

--srini

Quoted 21 lines
---
  drivers/slimbus/core.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/slimbus/core.c +3 -1
index 526e3215d8fe..44228a5b246d 100644
@@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
  	INIT_LIST_HEAD(&sbdev->stream_list);
  	spin_lock_init(&sbdev->stream_list_lock);
 
-	if (node)
+	if (node) {
  		sbdev->dev.of_node = of_node_get(node);
+		sbdev->dev.fwnode = of_fwnode_handle(node);
+	}
 
  	dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
  				  sbdev->e_addr.manf_id,