Skip to contentSkip to conversation

slimbus: core: Set fwnode for a device when setting of_node

PATCH In review Saravana Kannan 3 participants 4 messages Mar 26, 2020 – Apr 17, 2020 Serial low-power inter-chip media bus (SLIMbus)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 slimbus: core: Set fwnode for a device when setting of_node

When setting the of_node for a newly created device, also set the fwnode. This allows fw_devlink feature to work for slimbus devices.

---
 drivers/slimbus/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/slimbus/core.c +3 -1
index 526e3215d8fe..44228a5b246d 100644
@@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
 	INIT_LIST_HEAD(&sbdev->stream_list);
 	spin_lock_init(&sbdev->stream_list_lock);
 
-	if (node)
+	if (node) {
 		sbdev->dev.of_node = of_node_get(node);
+		sbdev->dev.fwnode = of_fwnode_handle(node);
+	}
 
 	dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
 				  sbdev->e_addr.manf_id,
Signature · 1 line
2.25.1.696.g5e7596f4ac-goog
#1 lore raw
Quoted 16 lines · Saravana Kannan

When setting the of_node for a newly created device, also set the fwnode. This allows fw_devlink feature to work for slimbus devices.

---
 drivers/slimbus/core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/slimbus/core.c +0 -0
index 526e3215d8fe..44228a5b246d 100644
@@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
        INIT_LIST_HEAD(&sbdev->stream_list);
        spin_lock_init(&sbdev->stream_list_lock);

drivers/slimbus/core.c static int slim_add_device(struct slim_controller *ctrl,

Quoted 10 lines
drivers/slimbus/core.c +3 -2
 
-       if (node)
+       if (node) {
                sbdev->dev.of_node = of_node_get(node);
+               sbdev->dev.fwnode = of_fwnode_handle(node);
+       }
 
        dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
                                  sbdev->e_addr.manf_id,
--

Hi Srinivas,

Btw, I sent another patch that's on top of this patch.
https://lore.kernel.org/lkml/[email protected]/T/#u

That fixes of_node_get() handling. Didn't notice it before I sent this patch. Otherwise would have made it a series. Sorry about the trouble.

Thanks,
Saravana

#3 lore raw
In reply to Saravana Kannan
Quoted 4 lines · Saravana Kannan

When setting the of_node for a newly created device, also set the fwnode. This allows fw_devlink feature to work for slimbus devices.

Applied Thanks,
--srini

Quoted 21 lines
---
  drivers/slimbus/core.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/slimbus/core.c +3 -1
index 526e3215d8fe..44228a5b246d 100644
@@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
  	INIT_LIST_HEAD(&sbdev->stream_list);
  	spin_lock_init(&sbdev->stream_list_lock);
 
-	if (node)
+	if (node) {
  		sbdev->dev.of_node = of_node_get(node);
+		sbdev->dev.fwnode = of_fwnode_handle(node);
+	}
 
  	dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
  				  sbdev->e_addr.manf_id,