Skip to contentSkip to conversation

ARM: dts: Aspeed: Tacoma: Add iio-hwmon nodes for IIO devices

PATCH In review Eddie James 2 participants 6 messages Mar 30, 2020 – Apr 1, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: Aspeed: Tacoma: Add iio-hwmon nodes for IIO devices

Connect the BMP280 and DPS310 to the hwmon subsystem with iio-hwmon nodes.

---
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts +10 -0
index ff49ec76fa7c..374512a83f33 100644
@@ -89,6 +89,16 @@
 			linux,code = <7>;
 		};
 	};
+
+	iio-hwmon-dps310 {
+		compatible = "iio-hwmon";
+		io-channels = <&dps 0>;
+	};
+
+	iio-hwmon-bmp280 {
+		compatible = "iio-hwmon";
+		io-channels = <&bmp 1>;
+	};
 };
 
 &fmc {
Signature · 1 line
2.24.0
maintainer
#1 lore raw
Quoted 3 lines · Eddie James

Connect the BMP280 and DPS310 to the hwmon subsystem with iio-hwmon nodes.

The BMP280 was on pre-production witherspoons. I imagine most of the ones we're using have dps310. Can we drop the bmp280 support?

Cheers,

Joel

Quoted 30 lines
---
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts +10 -1
index ff49ec76fa7c..374512a83f33 100644
@@ -89,6 +89,16 @@
                        linux,code = <7>;
                };
        };
+
+       iio-hwmon-dps310 {
+               compatible = "iio-hwmon";
+               io-channels = <&dps 0>;
+       };
+
+       iio-hwmon-bmp280 {
+               compatible = "iio-hwmon";
+               io-channels = <&bmp 1>;
+       };
 };
 
 &fmc {
--

2.24.0

#2 lore raw
Quoted 5 lines · Joel Stanley
Quoted 2 lines · Eddie James

Connect the BMP280 and DPS310 to the hwmon subsystem with iio-hwmon nodes.

The BMP280 was on pre-production witherspoons. I imagine most of the ones we're using have dps310. Can we drop the bmp280 support?

Yes, sent a new patch for that, so this one can be abandoned.

Thanks,

Eddie

Quoted 34 lines

Cheers,

Joel

Quoted 29 lines
---
  arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 10 ++++++++++
  1 file changed, 10 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts +10 -1
index ff49ec76fa7c..374512a83f33 100644
@@ -89,6 +89,16 @@
                         linux,code = <7>;
                 };
         };
+
+       iio-hwmon-dps310 {
+               compatible = "iio-hwmon";
+               io-channels = <&dps 0>;
+       };
+
+       iio-hwmon-bmp280 {
+               compatible = "iio-hwmon";
+               io-channels = <&bmp 1>;
+       };
  };
 
  &fmc {
--

2.24.0

#3 lore raw
Quoted 10 lines · Eddie James
Quoted 5 lines · Joel Stanley
Quoted 2 lines · Eddie James

Connect the BMP280 and DPS310 to the hwmon subsystem with iio-hwmon nodes.

The BMP280 was on pre-production witherspoons. I imagine most of the ones we're using have dps310. Can we drop the bmp280 support?

Yes, sent a new patch for that, so this one can be abandoned.

Nevermind... This one is better, because the device is physically there on all the Tacomas I've checked. It's also present in the regular old Witherspoon devicetree.

Quoted 41 lines

Thanks,

Eddie

Quoted 34 lines

Cheers,

Joel

Quoted 29 lines

---
  arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 10 ++++++++++

  1 file changed, 10 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts +10 -0
index ff49ec76fa7c..374512a83f33 100644
@@ -89,6 +89,16 @@
                          linux,code = <7>;
                  };
          };
+
+       iio-hwmon-dps310 {
+               compatible = "iio-hwmon";
+               io-channels = <&dps 0>;
+       };
+
+       iio-hwmon-bmp280 {
+               compatible = "iio-hwmon";
+               io-channels = <&bmp 1>;
+       };
   };
 
   &fmc {
Signature · 1 line
2.24.0
maintainer
#4 lore raw
Quoted 12 lines · Eddie James
Quoted 9 lines · Eddie James
Quoted 5 lines · Joel Stanley
Quoted 2 lines · Eddie James

Connect the BMP280 and DPS310 to the hwmon subsystem with iio-hwmon nodes.

The BMP280 was on pre-production witherspoons. I imagine most of the ones we're using have dps310. Can we drop the bmp280 support?

Quoted 6 lines
Quoted 1 line

Yes, sent a new patch for that, so this one can be abandoned.

Nevermind... This one is better, because the device is physically there on all the Tacomas I've checked. It's also present in the regular old Witherspoon devicetree.

Sorry, I don't follow. The machines have both the DPS and the BMP?

#5 lore raw
Quoted 10 lines · Joel Stanley
Quoted 9 lines · Eddie James
Quoted 7 lines · Eddie James
Quoted 5 lines · Joel Stanley
Quoted 2 lines · Eddie James

Connect the BMP280 and DPS310 to the hwmon subsystem with iio-hwmon nodes.

The BMP280 was on pre-production witherspoons. I imagine most of the ones we're using have dps310. Can we drop the bmp280 support?

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

Yes, sent a new patch for that, so this one can be abandoned.

Nevermind... This one is better, because the device is physically there on all the Tacomas I've checked. It's also present in the regular old Witherspoon devicetree.

Sorry, I don't follow. The machines have both the DPS and the BMP?

Yep.