dt-bindings: net: mdio.yaml fixes
Subsystems (4)
v3 cover dt-bindings: net: mdio.yaml fixes
Hi,
This patch series documents some common MDIO devices properties such as resets (and delays) and broken-turn-around. The second patch also rephrases some descriptions to be more general towards MDIO devices and not specific towards Ethernet PHYs.
Changes in v3:
- corrected wording of 'broken-turn-around' in ethernet-phy.yaml and mdio.yaml, add Andrew's R-b tag to patch #3
Florian Fainelli (3):
dt-bindings: net: Correct description of 'broken-turn-around'
dt-bindings: net: mdio: Document common properties
dt-bindings: net: mdio: Make descriptions more general
.../devicetree/bindings/net/ethernet-phy.yaml | 3 +- .../devicetree/bindings/net/mdio.yaml | 38 ++++++++++++++++--- 2 files changed, 35 insertions(+), 6 deletions(-)
Signature · 1 line
2.19.1
PATCH v3 1/3 dt-bindings: net: Correct description of 'broken-turn-around'
The turn around bytes (2) are placed between the control phase of the MDIO transaction and the data phase, correct the wording to be more exact.
--- Documentation/devicetree/bindings/net/ethernet-phy.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/ethernet-phy.yaml +2 -1
@@ -81,7 +81,8 @@ properties: $ref: /schemas/types.yaml#definitions/flag description: If set, indicates the PHY device does not correctly release - the turn around line low at the end of a MDIO transaction. + the turn around line low at end of the control phase of the + MDIO transaction. enet-phy-lane-swap: $ref: /schemas/types.yaml#definitions/flag
Signature · 1 line
2.19.1
PATCH v3 2/3 dt-bindings: net: mdio: Document common properties
In reply to Florian FainelliSome of the properties pertaining to the broken turn around or resets were only documented in ethernet-phy.yaml while they are applicable across all MDIO devices and not Ethernet PHYs specifically which are a superset.
--- .../devicetree/bindings/net/mdio.yaml | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+)
Documentation/devicetree/bindings/net/mdio.yaml +28 -0
@@ -50,6 +50,34 @@ patternProperties: description: The ID number for the PHY. + broken-turn-around: + $ref: /schemas/types.yaml#definitions/flag + description: + If set, indicates the MDIO device does not correctly release + the turn around line low at end of the control phase of the + MDIO transaction. + + resets: + maxItems: 1 + + reset-names: + const: phy + + reset-gpios: + maxItems: 1 + description: + The GPIO phandle and specifier for the MDIO reset signal. + + reset-assert-us: + description: + Delay after the reset was asserted in microseconds. If this + property is missing the delay will be skipped. + + reset-deassert-us: + description: + Delay after the reset was deasserted in microseconds. If + this property is missing the delay will be skipped. + required: - reg
Signature · 1 line
2.19.1
PATCH v3 3/3 dt-bindings: net: mdio: Make descriptions more general
In reply to Florian FainelliA number of descriptions assume a PHY device, but since this binding describes a MDIO bus which can have different kinds of MDIO devices attached to it, rephrase some descriptions to be more general in that regard.
--- Documentation/devicetree/bindings/net/mdio.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/net/mdio.yaml +5 -5
@@ -31,13 +31,13 @@ properties: maxItems: 1 description: The phandle and specifier for the GPIO that controls the RESET - lines of all PHYs on that MDIO bus. + lines of all devices on that MDIO bus. reset-delay-us: description: - RESET pulse width in microseconds. It applies to all PHY devices - and must therefore be appropriately determined based on all PHY - requirements (maximum value of all per-PHY RESET pulse widths). + RESET pulse width in microseconds. It applies to all MDIO devices + and must therefore be appropriately determined based on all devices + requirements (maximum value of all per-device RESET pulse widths). patternProperties: "^ethernet-phy@[0-9a-f]+$":
@@ -48,7 +48,7 @@ patternProperties: minimum: 0 maximum: 31 description: - The ID number for the PHY. + The ID number for the device. broken-turn-around: $ref: /schemas/types.yaml#definitions/flag
Signature · 1 line
2.19.1
Re: [PATCH net-next v3 1/3] dt-bindings: net: Correct description of 'broken-turn-around'
In reply to Florian FainelliQuoted 5 lines · Florian Fainelli
The turn around bytes (2) are placed between the control phase of the MDIO transaction and the data phase, correct the wording to be more exact.
Signed-off-by Florian Fainelli <[email protected]>
Andrew
Re: [PATCH net-next v3 2/3] dt-bindings: net: mdio: Document common properties
In reply to Florian FainelliQuoted 6 lines · Florian Fainelli
Some of the properties pertaining to the broken turn around or resets were only documented in
ethernet-phy.yamlwhile they are applicable across all MDIO devices and not Ethernet PHYs specifically which are a superset.Signed-off-by Florian Fainelli <[email protected]>
Andrew
David Miller
maintainerFrom: Florian Fainelli <[email protected]>
Date: Mon, 20 Apr 2020 11:07:20 -0700
Quoted 9 lines
This patch series documents some common MDIO devices properties such as resets (and delays) and broken-turn-around. The second patch also rephrases some descriptions to be more general towards MDIO devices and not specific towards Ethernet PHYs.
Changes in v3:
- corrected wording of 'broken-turn-around' in
ethernet-phy.yamlandmdio.yaml, add Andrew's R-b tag to patch #3
Series applied, thanks Florian.