Skip to contentSkip to conversation

DVBSKY S952v1 (M88TS2020 tuner, M88DS3103 demod): Set clk_out_div to 1 for M88TS2020, 0 locks up demod M88DS3103

PATCH In review Daniel Gielen 2 participants 2 messages May 2, 2020 – Aug 30, 2020 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DVBSKY S952v1 (M88TS2020 tuner, M88DS3103 demod): Set clk_out_div to 1 for M88TS2020, 0 locks up demod M88DS3103

---
 drivers/media/pci/cx23885/cx23885-dvb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/pci/cx23885/cx23885-dvb.c +1 -0
index 45c2f4afc..7123e1487 100644
@@ -2139,6 +2139,7 @@ static int dvb_register(struct cx23885_tsport *port)
 		memset(&ts2020_config, 0, sizeof(ts2020_config));
 		ts2020_config.fe = fe0->dvb.frontend;
 		ts2020_config.get_agc_pwm = m88ds3103_get_agc_pwm;
+		ts2020_config.clk_out_div = 1;
 		memset(&info, 0, sizeof(struct i2c_board_info));
 		strscpy(info.type, "ts2020", I2C_NAME_SIZE);
 		info.addr = 0x60;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 1 line · Daniel Gielen

Please can we have a better commit message, explaining what behaviour you seeing before the patch and how this fixes it. A bisect which show what regression you are fixing would also be helpful.

Thanks,

Sean

Quoted 18 lines
---
 drivers/media/pci/cx23885/cx23885-dvb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/pci/cx23885/cx23885-dvb.c +1 -0
index 45c2f4afc..7123e1487 100644
@@ -2139,6 +2139,7 @@ static int dvb_register(struct cx23885_tsport *port)
 		memset(&ts2020_config, 0, sizeof(ts2020_config));
 		ts2020_config.fe = fe0->dvb.frontend;
 		ts2020_config.get_agc_pwm = m88ds3103_get_agc_pwm;
+		ts2020_config.clk_out_div = 1;
 		memset(&info, 0, sizeof(struct i2c_board_info));
 		strscpy(info.type, "ts2020", I2C_NAME_SIZE);
 		info.addr = 0x60;
Signature · 1 line
2.25.1