Skip to contentSkip to conversation

SNC calls should handle BUFFER types

PATCH Andy Shevchenko 2 participants 2 messages May 5, 2020 – May 9, 2020 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

+Cc ACPI(CA) people

Quoted 5 lines · On Tue, May 5, 2020 at 1:16 PM <[email protected]> wrote:

After commit 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer objects for ASL create_field() operator") ACPICA creates buffers even when new fields are small enough to fit into an integer.

Many SNC calls counted on the old behaviour.

Rafael, Erik, is it correct behaviour from ACPICA p.o.v. nowadays or should be fixed rather there?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 11 lines · CEST Andy Shevchenko

+Cc ACPI(CA) people

Quoted 5 lines · On Tue, May 5, 2020 at 1:16 PM <[email protected]> wrote:

After commit 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer objects for ASL create_field() operator") ACPICA creates buffers even when new fields are small enough to fit into an integer.

Many SNC calls counted on the old behaviour.

Rafael, Erik, is it correct behaviour from ACPICA p.o.v. nowadays or should be fixed rather there?

The new behavior is correct and it is needed to avoid other failures elsewhere.

Unfortunately, all of the call sites assuming that the conversion will happen need to be fixed.

Cheers!