Skip to contentSkip to conversation

workqueue: Remove unnecessary kfree() call in rcu_free_wq()

PATCH Superseded [email protected] 1 participant 1 message May 28, 2020 Workqueue

v5 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 workqueue: Remove unnecessary kfree() call in rcu_free_wq()

From: Zhang Qiang <[email protected]>

The data structure member "wq->rescuer" was reset to a null pointer in one if branch. It was passed to a call of the function "kfree" in the callback function "rcu_free_wq" (which was eventually executed). The function "kfree" does not perform more meaningful data processing for a passed null pointer (besides immediately returning from such a call). Thus delete this function call which became unnecessary with the referenced software update.

Fixes def98c84b6cd ("workqueue: Fix spurious sanity check failures in destroy_workqueue()")

---
v1->v2->v3->v4->v5:
Modify weakly submitted information.

 kernel/workqueue.c | 1 -
 1 file changed, 1 deletion(-)
kernel/workqueue.c +0 -1
index 891ccad5f271..a2451cdcd503 100644
@@ -3491,7 +3491,6 @@ static void rcu_free_wq(struct rcu_head *rcu)
 	else
 		free_workqueue_attrs(wq->unbound_attrs);
 
-	kfree(wq->rescuer);
 	kfree(wq);
 }
 
Signature · 1 line
2.24.1