Skip to contentSkip to conversation

workqueue: Remove unnecessary kfree() call in rcu_free_wq()

PATCH Superseded [email protected] 2 participants 2 messages May 28, 2020

Subsystems (2)

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 workqueue: Remove unnecessary kfree() call in rcu_free_wq()

From: Zhang Qiang <[email protected]>

The data structure member "wq->rescuer" was reset to a null pointer in one if branch. It was passed to a call of the function "kfree" in the callback function "rcu_free_wq" (which was eventually executed). The function "kfree" does not perform more meaningful data processing for a passed null pointer (besides immediately returning from such a call). Thus delete this function call which became unnecessary with the referenced software update.

Fixes def98c84b6cd ("workqueue: Fix spurious sanity check failures in destroy_workqueue()")

---
v1->v2->v3->v4->v5->v6:
Modify weakly submitted information and tag.

 kernel/workqueue.c | 1 -
 1 file changed, 1 deletion(-)
kernel/workqueue.c +0 -1
index 891ccad5f271..a2451cdcd503 100644
@@ -3491,7 +3491,6 @@ static void rcu_free_wq(struct rcu_head *rcu)
 	else
 		free_workqueue_attrs(wq->unbound_attrs);
 
-	kfree(wq->rescuer);
 	kfree(wq);
 }
 
Signature · 1 line
2.24.1
#1 lore raw
Quoted 2 lines

Thus delete this function call which became unnecessary with the referenced software update.

…

Quoted 1 line

I guess that this tag should usually trigger another consequence like the following.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b0c3ba31be3e45a130e13b278cf3b90f69bda6f6#n548

Is there a need to tag also the patch review contribution of Lai Jiangshan?
https://lore.kernel.org/lkml/CAJhGHyC4XcNL8yzWZKZ=73wZJej4JwCaAHGV8qjYn-AqcEAEjQ@mail.gmail.com/
https://lore.kernel.org/patchwork/comment/1442889/
https://lkml.org/lkml/2020/5/26/201

I am unsure if such aspects will matter after Tejun Heo responded with the information “Applied to wq/for-5.8.” to the previous patch version yesterday.
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/patchwork/comment/1443888/

Quoted 2 lines

v1->v2->v3->v4->v5->v6:
Modify weakly submitted information and tag.

I am curious how our imaginations and preferences will evolve further also for such wording selections.

Regards,
Markus