ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode
PATCH 1/1 ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode
Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") the networking is broken on the BeagleBone AI which has the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for other AM5729 boards.
[0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf
--- arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am5729-beagleboneai.dts +1 -1
@@ -505,7 +505,7 @@ &mac { &cpsw_emac0 { phy-handle = <&phy0>; - phy-mode = "rgmii"; + phy-mode = "rgmii-rxid"; }; &ocp {
Signature · 1 line
2.25.1
Quoted 7 lines · Drew Fustini
Since commit
cd28d1d6e52e("net: phy: at803x: Disable phy delay for RGMII mode") the networking is broken on the BeagleBone AI which has the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from phy-mode = "rgmii" to phy-mode = "rgmii-rxid".Note: Grygorii Strashko made a similar phy-mode fix in
820f8a870f65for other AM5729 boards.
commit ref is incorrect
Quoted 6 lines
[0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf
Cc Vinod Koul <[email protected]>Cc Grygorii Strashko <[email protected]>Fixes cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode")
Pls change fixed tag to520557d4854b ARM: dts: am5729: beaglebone-ai: adding device tree as this board DTB was merged only in 5.8.
Quoted 12 lines
Signed-off-by Robert Nelson <[email protected]>Signed-off-by Drew Fustini <[email protected]>--- arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/am5729-beagleboneai.dts +0
-0
arch/arm/boot/dts/am5729-beagleboneai.dts &mac { · line 511
Quoted 8 lines
arch/arm/boot/dts/am5729-beagleboneai.dts +1
-1@@ -505,7 +505,7 @@ &mac { &cpsw_emac0 { phy-handle = <&phy0>; - phy-mode = "rgmii"; + phy-mode = "rgmii-rxid"; }; &ocp {
Thanks, pls fix above and you can add my
Signature · 2 lines
Best regards, grygorii
Quoted 8 lines · Grygorii Strashko
Quoted 5 lines · Drew Fustini
Since commit
cd28d1d6e52e("net: phy: at803x: Disable phy delay for RGMII mode") the networking is broken on the BeagleBone AI which has the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
Quoted 4 lines
Quoted 2 lines
Note: Grygorii Strashko made a similar phy-mode fix in
820f8a870f65for other AM5729 boards.commit ref is incorrect
Do you mean commit ref 820f8a870f65 ?
("ARM: dts: am57xx: fix networking on boards with ksz9031 phy")
I thought it made sense to point to that commit as you seemed to be fixing a very similar issue, just for a different phy.
Or did you mean commit ref cd28d1d6e52e ? ("net: phy: at803x: Disable phy delay for RGMII mode")
I believe this is the commit that made it necessary to change the phy-mode property for the AR8035 PHY.
Quoted 10 lines
Quoted 6 lines
[0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf
Cc Vinod Koul <[email protected]>Cc Grygorii Strashko <[email protected]>Fixes cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode")Pls change fixed tag to
520557d4854bARM: dts: am5729: beaglebone-ai: adding device tree as this board DTB was merged only in 5.8.
Ok, will do.
Quoted 21 lines
Quoted 12 lines
Signed-off-by Robert Nelson <[email protected]>Signed-off-by Drew Fustini <[email protected]>--- arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/am5729-beagleboneai.dts +0
-0arch/arm/boot/dts/am5729-beagleboneai.dts &mac { · line 510
Quoted 7 lines
arch/arm/boot/dts/am5729-beagleboneai.dts +1
-1@@ -505,7 +505,7 @@ &mac { &cpsw_emac0 { phy-handle = <&phy0>; - phy-mode = "rgmii"; + phy-mode = "rgmii-rxid"; }; &ocp {Thanks, pls fix above and you can add my
Quoted 5 lines
Reviewed-by Grygorii Strashko <[email protected]>Signature · 2 lines
Best regards, grygorii
Thanks for taking the time to review.
-Drew
Quoted 12 lines · Drew Fustini
Quoted 11 lines · Grygorii Strashko
Quoted 7 lines · Drew Fustini
Since commit
cd28d1d6e52e("net: phy: at803x: Disable phy delay for RGMII mode") the networking is broken on the BeagleBone AI which has the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from phy-mode = "rgmii" to phy-mode = "rgmii-rxid".Note: Grygorii Strashko made a similar phy-mode fix in
820f8a870f65for other AM5729 boards.
Quoted 7 lines
Quoted 1 line
commit ref is incorrect
Do you mean commit ref
820f8a870f65?
("ARM: dts: am57xx: fix networking on boards with ksz9031 phy")I thought it made sense to point to that commit as you seemed to be fixing a very similar issue, just for a different phy.
Yes. but you should use proper format for commit ref:
commit <12+ chars of sha1> (\"<title line>\")'
checkpatch should warn you.
Signature · 2 lines
Best regards, grygorii