Skip to contentSkip to conversation

ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode

PATCH In review Drew Fustini 2 participants 2 messages Jun 15, 2020 – Jun 16, 2020 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode

Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") the networking is broken on the BeagleBone AI which has the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from phy-mode = "rgmii" to phy-mode = "rgmii-rxid".

Note: Grygorii made a similar DT fix for other AM57xx boards with a different phy in commit 820f8a870f65 ("ARM: dts: am57xx: fix networking on boards with ksz9031 phy").

[0] https://git.io/Jf7PX

Fixes 520557d4854b ("ARM: dts: am5729: beaglebone-ai: adding device tree")
Cc Vinod Koul <[email protected]>

---
V2:
- fix formatting of commit reference
- add Review-by: from Grygorii

 arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am5729-beagleboneai.dts +1 -1
index 9877d7709d41..4c51c6b05e64 100644
@@ -505,7 +505,7 @@ &mac {
 
 &cpsw_emac0 {
 	phy-handle = <&phy0>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-rxid";
 };
 
 &ocp {
Signature · 1 line
2.25.1
#1 lore raw
Quoted 16 lines · Drew Fustini

Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode") the networking is broken on the BeagleBone AI which has the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from phy-mode = "rgmii" to phy-mode = "rgmii-rxid".

Note: Grygorii made a similar DT fix for other AM57xx boards with a different phy in commit 820f8a870f65 ("ARM: dts: am57xx: fix networking on boards with ksz9031 phy").

[0] https://git.io/Jf7PX

Fixes 520557d4854b ("ARM: dts: am5729: beaglebone-ai: adding device tree")
Cc Vinod Koul <[email protected]>
Quoted 4 lines

---
V2:
- fix formatting of commit reference
- add Review-by: from Grygorii

Thanks applying into fixes.

Regards,

Tony