Skip to contentSkip to conversation

ARM: dts: imx6q-tbs2910: Fix Ethernet regression

PATCH Superseded Fabio Estevam 4 participants 6 messages Jun 25, 2020

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/1 ARM: dts: imx6q-tbs2910: Fix Ethernet regression

Since commit:

commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc

Author: Michael Walle <[email protected]>
Date:   Thu May 7 00:11:58 2020 +0200

phy: atheros: ar8035: remove static clock config

We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver.

If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY. Please have a look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set "clk-out-frequency = <125000000>" because that value was the hardcoded value until this commit.

, the clock output setting for the AR803x driver is removed from being hardcoded in the PHY driver and should be passed via device tree instead.

Update the device tree with the "qca,clk-out-frequency" property so that Ethernet can work again.

---
Changes since v1:
- Removed extra unnecessary extra blank line from device tree.

 arch/arm/dts/imx6q-tbs2910.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/dts/imx6q-tbs2910.dts +11 -0
index cc5df37b46..7d0a0676ff 100644
@@ -107,7 +107,18 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+	phy-handle = <&phy>;
 	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		phy: ethernet-phy at 4 {
+			reg = <4>;
+			qca,clk-out-frequency = <125000000>;
+		};
+	};
 };
 
 &hdmi {
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 ARM: dts: imx6q-tbs2910: Fix Ethernet regression

Quoted 21 lines · Fabio Estevam

Since commit:

commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc

Author: Michael Walle <[email protected]>
Date:   Thu May 7 00:11:58 2020 +0200

phy: atheros: ar8035: remove static clock config

We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver.

If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY. Please have a look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set "clk-out-frequency = <125000000>" because that value was the hardcoded value until this commit.

Quoted 8 lines

, the clock output setting for the AR803x driver is removed from being hardcoded in the PHY driver and should be passed via device tree instead.

Update the device tree with the "qca,clk-out-frequency" property so that Ethernet can work again.

Thanks,
Soeren

Quoted 30 lines

---
Changes since v1:
- Removed extra unnecessary extra blank line from device tree.

 arch/arm/dts/imx6q-tbs2910.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/dts/imx6q-tbs2910.dts +11 -0
index cc5df37b46..7d0a0676ff 100644
@@ -107,7 +107,18 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+	phy-handle = <&phy>;
 	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		phy: ethernet-phy at 4 {
+			reg = <4>;
+			qca,clk-out-frequency = <125000000>;
+		};
+	};
 };
 
 &hdmi {
author reviewer
#2 lore raw

PATCH v2 1/1 ARM: dts: imx6q-tbs2910: Fix Ethernet regression

Hi Tom,

Quoted 26 lines · Soeren Moch
Quoted 24 lines · Fabio Estevam

Since commit:

commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc

Author: Michael Walle <[email protected]>
Date:   Thu May 7 00:11:58 2020 +0200

phy: atheros: ar8035: remove static clock config

We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver.

If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY. Please have a look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set "clk-out-frequency = <125000000>" because that value was the hardcoded value until this commit.

, the clock output setting for the AR803x driver is removed from being hardcoded in the PHY driver and should be passed via device tree instead.

Quoted 6 lines
Quoted 5 lines

Update the device tree with the "qca,clk-out-frequency" property so that Ethernet can work again.

My understanding is that Stefano does not have any other pull requests for 2020.07.

In this case, could you apply this regression fix directly?

Thanks

#3 lore raw

PATCH v2 1/1 ARM: dts: imx6q-tbs2910: Fix Ethernet regression

Quoted 32 lines · Fabio Estevam

Hi Tom,

Quoted 29 lines · Soeren Moch
Quoted 27 lines · Fabio Estevam

Since commit:

commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc

Author: Michael Walle <[email protected]>
Date:   Thu May 7 00:11:58 2020 +0200

phy: atheros: ar8035: remove static clock config

We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver.

If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY. Please have a look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set "clk-out-frequency = <125000000>" because that value was the hardcoded value until this commit.

, the clock output setting for the AR803x driver is removed from being hardcoded in the PHY driver and should be passed via device tree instead.

Update the device tree with the "qca,clk-out-frequency" property so that Ethernet can work again.

Quoted 7 lines
Quoted 3 lines
Quoted 2 lines

My understanding is that Stefano does not have any other pull requests for 2020.07.

Yes, I do not see (this is an exception) other urgent patches that should flow into the release.

Quoted 2 lines

In this case, could you apply this regression fix directly?

+1

Thanks,
Stefano

Quoted 2 lines

Thanks

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#4 lore raw

PATCH v2 1/1 ARM: dts: imx6q-tbs2910: Fix Ethernet regression

Quoted 41 lines · Stefano Babic
Quoted 32 lines · Fabio Estevam

Hi Tom,

Quoted 29 lines · Soeren Moch
Quoted 27 lines · Fabio Estevam

Since commit:

commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc

Author: Michael Walle <[email protected]>
Date:   Thu May 7 00:11:58 2020 +0200

phy: atheros: ar8035: remove static clock config

We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver.

If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY. Please have a look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set "clk-out-frequency = <125000000>" because that value was the hardcoded value until this commit.

, the clock output setting for the AR803x driver is removed from being hardcoded in the PHY driver and should be passed via device tree instead.

Update the device tree with the "qca,clk-out-frequency" property so that Ethernet can work again.

Quoted 7 lines
Quoted 3 lines
Quoted 2 lines

My understanding is that Stefano does not have any other pull requests for 2020.07.

Quoted 7 lines

Yes, I do not see (this is an exception) other urgent patches that should flow into the release.

Quoted 2 lines

In this case, could you apply this regression fix directly?

+1

OK, will do, thanks for sorting this out so quickly!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200625/3c9869aa/attachment.sig>
#5 lore raw

PATCH v2 1/1 ARM: dts: imx6q-tbs2910: Fix Ethernet regression

In reply to Fabio Estevam
Quoted 24 lines · Fabio Estevam

Since commit:

commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc

Author: Michael Walle <[email protected]>
Date:   Thu May 7 00:11:58 2020 +0200

phy: atheros: ar8035: remove static clock config

We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver.

If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY. Please have a look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set "clk-out-frequency = <125000000>" because that value was the hardcoded value until this commit.

, the clock output setting for the AR803x driver is removed from being hardcoded in the PHY driver and should be passed via device tree instead.

Quoted 6 lines

Update the device tree with the "qca,clk-out-frequency" property so that Ethernet can work again.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200625/664ca1e6/attachment.sig>