Enable RTC on Odroid N2

Inoder for test suspend resume feature on Odroid N2 we need to enable RTC module on this device.

Following patches enable rtc on Odroid N2 but sill rtcwakeup is not working se bellow. Any inputs are welcome.

# sudo hwclock -r && date
2020-07-15 15:53:27.706883+00:00
Wed Jul 15 15:53:27 UTC 2020

# echo 1 > /sys/power/pm_debug_messages
bash: /sys/power/pm_debug_messages: Permission denied
# time rtcwake -s 30 -m mem
rtcwake: /dev/rtc0 not enabled for wakeup events

real    0m0.003s
user    0m0.003s
sys     0m0.000s

#

-Anand

Anand Moon (3):
arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node
arm64: dts: meson-g12b-odroid-n2: Disable virtual wake RTC
arm64: defconfig: Enable RTC devices for Amlogic boards

 .../boot/dts/amlogic/meson-g12b-odroid-n2.dts  | 18 ++++++++++++++++++
 arch/arm64/configs/defconfig                   |  1 +
 2 files changed, 19 insertions(+)

Disable virtual wake RTC node on Odroid N2.

[    7.171149] meson-vrtc ff8000a8.rtc: registered as rtc0
[    7.182875] meson-vrtc ff8000a8.rtc: setting system clock to 1970-01-01T00:00:07 UTC (7)

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---

---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4 ++++
 1 file changed, 4 insertions(+)

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +0 -0

index a447cba4dd53..c8c1262a7bfc 100644

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume.

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---

$ sudo hwclock -r && date
2020-07-15 13:11:53.862508+00:00
Wed Jul 15 13:11:54 UTC 2020

$ hwclock --show
2020-07-15 13:17:30.903300+00:00

But RTC wake up is not working at my end. Any inputs are welcome.

$ time rtcwake -s 30 -m mem
rtcwake: /dev/rtc0 not enabled for wakeup events

real    0m0.002s
user    0m0.002s
sys     0m0.000s
---
 .../boot/dts/amlogic/meson-g12b-odroid-n2.dts      | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +1 -0

index 169ea283d4ee..a447cba4dd53 100644
@@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint {
 	};
 };
 
+&i2c3 {

Enables the RTC PCF8563 driver used on Amlogic Libretech-pc and Odroid-N2 boards supported in mainline kernel.

Cc Kevin Hilman <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

arch/arm64/configs/defconfig +0 -0

index 883e8bace3ed..a0e8d46c3d06 100644

Hi,

Quoted 19 lines · Anand Moon

Disable virtual wake RTC node on Odroid N2.

[    7.171149] meson-vrtc ff8000a8.rtc: registered as rtc0
[    7.182875] meson-vrtc ff8000a8.rtc: setting system clock to 1970-01-01T00:00:07 UTC (7)

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---

---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4 ++++
 1 file changed, 4 insertions(+)

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +0 -0

index a447cba4dd53..c8c1262a7bfc 100644

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts &usb2_phy1 { · line 523

Quoted 7 lines

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +4 -0

@@ -517,3 +517,7 @@ &usb2_phy1 {
      /* Enable the hub which is connected to this port */
      phy-supply = <&hub_5v>;
 };
+
+&vrtc {
+     status = "disabled";
+};

Please don't, the vrtc is here to wake up the device.

Neil

Hi,

Quoted 35 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume.

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---

$ sudo hwclock -r && date
2020-07-15 13:11:53.862508+00:00
Wed Jul 15 13:11:54 UTC 2020

$ hwclock --show
2020-07-15 13:17:30.903300+00:00

But RTC wake up is not working at my end. Any inputs are welcome.

$ time rtcwake -s 30 -m mem
rtcwake: /dev/rtc0 not enabled for wakeup events

real    0m0.002s
user    0m0.002s
sys     0m0.000s
---
 .../boot/dts/amlogic/meson-g12b-odroid-n2.dts      | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +0 -0

index 169ea283d4ee..a447cba4dd53 100644
@@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint {
      };
 };
 

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts hdmi_tx_tmds_out: endpoint { · line 404

Quoted 11 lines

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +11 -0

+&i2c3 {
+     pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;
+     pinctrl-names = "default";
+     status = "okay";
+
+     rtc: rtc@51 {
+             reg = <0x51>;
+             compatible = "nxp,pcf8563";
+             #clock-cells = <0>;
+             clock-frequency = <32768>;
+             clock-output-names = "rtc_clkout";

The clkout output is not used, so I don't think these 3 lines are needed.

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts hdmi_tx_tmds_out: endpoint { · line 410

Quoted 8 lines

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +3 -0

+     };
+};
+
 &ir {
      status = "okay";
      pinctrl-0 = <&remote_input_ao_pins>;

Neil

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume.

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---

$ sudo hwclock -r && date
2020-07-15 13:11:53.862508+00:00
Wed Jul 15 13:11:54 UTC 2020

$ hwclock --show
2020-07-15 13:17:30.903300+00:00

But RTC wake up is not working at my end. Any inputs are welcome.

$ time rtcwake -s 30 -m mem
rtcwake: /dev/rtc0 not enabled for wakeup events

real    0m0.002s
user    0m0.002s
sys     0m0.000s
---
 .../boot/dts/amlogic/meson-g12b-odroid-n2.dts      | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +2 -0

index 169ea283d4ee..a447cba4dd53 100644
@@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint {
 	};
 };
 
+&i2c3 {
+	pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +2 -0

+};
+
 &ir {
 	status = "okay";
 	pinctrl-0 = <&remote_input_ao_pins>;

Hi Anand,

Only the vrtc is able to wakeup the device from suspend, the external RTC is not capable.

Neil

Hi Neil,

Thanks for your review comments.

Quoted 7 lines · Neil Armstrong

Hi Anand,

Only the vrtc is able to wakeup the device from suspend, the external RTC is not capable.

Neil

Now I have two RTC driver registered

$ dmesg | grep rtc
[    4.737315] rtc-pcf8563 0-0051: registered as rtc0
[    4.738763] rtc-pcf8563 0-0051: setting system clock to
2020-07-16T08:00:46 UTC (1594886446)
[    4.790206] meson-vrtc ff8000a8.rtc: registered as rtc1

And there are two nodes

# ls /dev/rtc*
/dev/rtc  /dev/rtc0  /dev/rtc1

So it seames an issue that /dev/rtc0 is not able to handle wakeup events. How can we resolve this issue?

# time rtcwake -s 30 -m mem
rtcwake: /dev/rtc0 not enabled for wakeup events

real    0m0.002s
user    0m0.001s
sys     0m0.002s

-Anand

Hi,

Quoted 22 lines · Anand Moon

Hi Neil,

Thanks for your review comments.

Quoted 7 lines · Neil Armstrong

Hi Anand,

Only the vrtc is able to wakeup the device from suspend, the external RTC is not capable.

Neil

Now I have two RTC driver registered

$ dmesg | grep rtc
[    4.737315] rtc-pcf8563 0-0051: registered as rtc0
[    4.738763] rtc-pcf8563 0-0051: setting system clock to
2020-07-16T08:00:46 UTC (1594886446)
[    4.790206] meson-vrtc ff8000a8.rtc: registered as rtc1

And there are two nodes

Quoted 8 lines

# ls /dev/rtc*
/dev/rtc  /dev/rtc0  /dev/rtc1

So it seames an issue that /dev/rtc0 is not able to handle wakeup events. How can we resolve this issue?

# time rtcwake -s 30 -m mem
rtcwake: /dev/rtc0 not enabled for wakeup events

rtcwake -d /dev/rtc1 -s 30 -m mem

As Christian reported off-list, it may be necessary to keep the vrtc as rtc0, so you should add aliases in the odroid-n2 DT to have vrtc as rtc0 and the on-board rtc as rtc1, but it may break the hwclock tools, so the reverse may be better but you'll need to specify rtc1 to rtcwake.

Neil

Quoted 7 lines

real    0m0.002s
user    0m0.001s
sys     0m0.002s

-Anand

Quoted 37 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume.

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---

$ sudo hwclock -r && date
2020-07-15 13:11:53.862508+00:00
Wed Jul 15 13:11:54 UTC 2020

$ hwclock --show
2020-07-15 13:17:30.903300+00:00

But RTC wake up is not working at my end. Any inputs are welcome.

$ time rtcwake -s 30 -m mem
rtcwake: /dev/rtc0 not enabled for wakeup events

real    0m0.002s
user    0m0.002s
sys     0m0.000s
---
 .../boot/dts/amlogic/meson-g12b-odroid-n2.dts      | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +2 -0

index 169ea283d4ee..a447cba4dd53 100644
@@ -391,6 +391,20 @@ hdmi_tx_tmds_out: endpoint {
      };
 };
 
+&i2c3 {
+     pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts hdmi_tx_tmds_out: endpoint { · line 405

Quoted 10 lines

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +10 -0

+     pinctrl-names = "default";
+     status = "okay";
+
+     rtc: rtc@51 {
+             reg = <0x51>;
+             compatible = "nxp,pcf8563";
+             #clock-cells = <0>;
+             clock-frequency = <32768>;
+             clock-output-names = "rtc_clkout";
+     };

This rtc being on a connector, optional and not fitted by default, should it really be enabled for all odroid-n2 ?

We tend not do that usually

Hi,

Quoted 34 lines · Neil Armstrong

Hi,

Quoted 22 lines · Anand Moon

Hi Neil,

Thanks for your review comments.

Quoted 7 lines · Neil Armstrong

Hi Anand,

Only the vrtc is able to wakeup the device from suspend, the external RTC is not capable.

Neil

Now I have two RTC driver registered

$ dmesg | grep rtc
[    4.737315] rtc-pcf8563 0-0051: registered as rtc0
[    4.738763] rtc-pcf8563 0-0051: setting system clock to
2020-07-16T08:00:46 UTC (1594886446)
[    4.790206] meson-vrtc ff8000a8.rtc: registered as rtc1

And there are two nodes

Quoted 8 lines

# ls /dev/rtc*
/dev/rtc  /dev/rtc0  /dev/rtc1

So it seames an issue that /dev/rtc0 is not able to handle wakeup events. How can we resolve this issue?

# time rtcwake -s 30 -m mem
rtcwake: /dev/rtc0 not enabled for wakeup events

Quoted 6 lines

rtcwake -d /dev/rtc1 -s 30 -m mem

As Christian reported off-list, it may be necessary to keep the vrtc as rtc0, so you should add aliases in the odroid-n2 DT to have vrtc as rtc0 and the on-board rtc as rtc1, but it may break the hwclock tools, so the reverse may be better but you'll need to specify rtc1 to rtcwake.

While looking closer to the Odroid-N2 schematics and U-Boot/SCP Firmware, the external on-board RTC can wake the device with the GPIO_AO 7, and wakeup is enabled in:
https://github.com/hardkernel/u-boot/blob/odroidn2-v2015.01/board/hardkernel/odroidn2/firmware/scp_task/pwr_ctrl.c#L143

So, something must be missing.

Hi,

Quoted 34 lines · Neil Armstrong

Hi,

Quoted 22 lines · Anand Moon

Hi Neil,

Thanks for your review comments.

Quoted 7 lines · Neil Armstrong

Hi Anand,

Only the vrtc is able to wakeup the device from suspend, the external RTC is not capable.

Neil

Now I have two RTC driver registered

$ dmesg | grep rtc
[    4.737315] rtc-pcf8563 0-0051: registered as rtc0
[    4.738763] rtc-pcf8563 0-0051: setting system clock to
2020-07-16T08:00:46 UTC (1594886446)
[    4.790206] meson-vrtc ff8000a8.rtc: registered as rtc1

And there are two nodes

Quoted 8 lines

# ls /dev/rtc*
/dev/rtc  /dev/rtc0  /dev/rtc1

So it seames an issue that /dev/rtc0 is not able to handle wakeup events. How can we resolve this issue?

# time rtcwake -s 30 -m mem
rtcwake: /dev/rtc0 not enabled for wakeup events

Quoted 6 lines

rtcwake -d /dev/rtc1 -s 30 -m mem

As Christian reported off-list, it may be necessary to keep the vrtc as rtc0, so you should add aliases in the odroid-n2 DT to have vrtc as rtc0 and the on-board rtc as rtc1, but it may break the hwclock tools, so the reverse may be better but you'll need to specify rtc1 to rtcwake.

While looking closer to the Odroid-N2 schematics and U-Boot/SCP Firmware, the external on-board RTC can wake the device with the GPIO_AO 7, and wakeup is enabled in:
https://github.com/hardkernel/u-boot/blob/odroidn2-v2015.01/board/hardkernel/odroidn2/firmware/scp_task/pwr_ctrl.c#L143

So, something must be missing.