media: platform: vpdma.c: fix comparison to bool
PATCH 19/20 media: platform: vpdma.c: fix comparison to bool
From: "Daniel W. S. Almeida" <[email protected]>
Fix the following coccinelle report:
drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
Comparison to bool
Found using - Coccinelle (http://coccinelle.lip6.fr)
--- drivers/media/platform/ti-vpe/vpdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti-vpe/vpdma.c +1 -1
@@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)spin_lock_irqsave (&vpdma->lock, flags);for (i =0 ; i <VPDMA_MAX_NUM_LIST && - vpdma->hwlist_used[i] == true; i++) + vpdma->hwlist_used[i]; i++) ;if (i <VPDMA_MAX_NUM_LIST ) {
Signature · 1 line
2.28.0
Daniel W. S. Almeida <[email protected]> wrote on Fri [2020-Aug-07 05:35:46 -0300]:
Quoted 10 lines
From: "Daniel W. S. Almeida" <[email protected]>
Fix the following coccinelle report:
drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
Comparison to boolFound using - Coccinelle (http://coccinelle.lip6.fr)
Signed-off-by Daniel W. S. Almeida <[email protected]>
Quoted 20 lines
--- drivers/media/platform/ti-vpe/vpdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/ti-vpe/vpdma.c +1
-1@@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)spin_lock_irqsave (&vpdma->lock, flags);for (i =0 ; i <VPDMA_MAX_NUM_LIST && - vpdma->hwlist_used[i] == true; i++) + vpdma->hwlist_used[i]; i++) ;if (i <VPDMA_MAX_NUM_LIST ) {Signature · 1 line
2.28.0
Quoted 9 lines · Benoit Parrot
Daniel W. S. Almeida <[email protected]> wrote on Fri [2020-Aug-07 05:35:46 -0300]:
Quoted 8 lines
From: "Daniel W. S. Almeida" <[email protected]>
Fix the following coccinelle report:
drivers/media/platform/ti-vpe/vpdma.c:946:5-26: WARNING:
Comparison to boolFound using - Coccinelle (http://coccinelle.lip6.fr)
[]
Quoted 1 line
drivers/media/platform/ti-vpe/vpdma.c
Quoted 1 line
drivers/media/platform/ti-vpe/vpdma.c +0
-0
[]
Quoted 7 lines
drivers/media/platform/ti-vpe/vpdma.c int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv) · line 947
Quoted 7 lines
drivers/media/platform/ti-vpe/vpdma.c +1
-1@@ -943,7 +943,7 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)spin_lock_irqsave (&vpdma->lock, flags);for (i =0 ; i <VPDMA_MAX_NUM_LIST && - vpdma->hwlist_used[i] == true; i++) + vpdma->hwlist_used[i]; i++) ;
A more typical way to write this loop is
not testing i < VPDMA_MAX_NUM_LIST multiple
times like the below:
--- drivers/media/platform/ti-vpe/vpdma.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/media/platform/ti-vpe/vpdma.c +4 -5
@@ -942,14 +942,13 @@ int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv)unsigned long flags;spin_lock_irqsave (&vpdma->lock, flags); -for (i =0 ; i <VPDMA_MAX_NUM_LIST && - vpdma->hwlist_used[i] == true; i++) - ; - -if (i <VPDMA_MAX_NUM_LIST ) { +for (i =0 ; i <VPDMA_MAX_NUM_LIST ; i++) { +if (vpdma->hwlist_used[i]) +continue ; list_num = i; vpdma->hwlist_used[i] = true; vpdma->hwlist_priv[i] = priv; +break ; }spin_unlock_irqrestore (&vpdma->lock, flags);