Skip to contentSkip to conversation

media: pci: saa7164-dvb.c: replace if(cond) BUG() with BUG_ON()

PATCH In review Daniel W. S. Almeida 1 participant 1 message Aug 7, 2020 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 9/20 media: pci: saa7164-dvb.c: replace if(cond) BUG() with BUG_ON()

From: "Daniel W. S. Almeida" <[email protected]>

Fix the following coccinelle reports:

drivers/media/pci/saa7164/saa7164-dvb.c:341:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG

drivers/media/pci/saa7164/saa7164-dvb.c:483:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

Found using - Coccinelle (http://coccinelle.lip6.fr)

---
 drivers/media/pci/saa7164/saa7164-dvb.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/media/pci/saa7164/saa7164-dvb.c +2 -5
index bf8c2bb8852e..24421c116b0b 100644
@@ -337,8 +337,7 @@ static int dvb_register(struct saa7164_port *port)
 
 	dprintk(DBGLVL_DVB, "%s(port=%d)\n", __func__, port->nr);
 
-	if (port->type != SAA7164_MPEG_DVB)
-		BUG();
+	BUG_ON(port->type != SAA7164_MPEG_DVB);
 
 	/* Sanity check that the PCI configuration space is active */
 	if (port->hwcfg.BARLocation == 0) {
@@ -479,8 +478,7 @@ int saa7164_dvb_unregister(struct saa7164_port *port)
 
 	dprintk(DBGLVL_DVB, "%s()\n", __func__);
 
-	if (port->type != SAA7164_MPEG_DVB)
-		BUG();
+	BUG_ON(port->type != SAA7164_MPEG_DVB);
 
 	/* Remove any allocated buffers */
 	mutex_lock(&port->dmaqueue_lock);
@@ -740,4 +738,3 @@ int saa7164_dvb_register(struct saa7164_port *port)
 	printk(KERN_ERR "%s() Frontend/I2C initialization failed\n", __func__);
 	return -1;
 }
-
Signature · 1 line
2.28.0