Skip to contentSkip to conversation

irqchip/ti-sci-inta: Fix unsigned expression compared with zero in ti_sci_inta_alloc_parent_irq

PATCH New Ye Bin 1 participant 1 message Aug 24, 2020

Subsystems (2)
lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH 1/1 irqchip/ti-sci-inta: Fix unsigned expression compared with zero in ti_sci_inta_alloc_parent_irq

---
 drivers/irqchip/irq-ti-sci-inta.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/irqchip/irq-ti-sci-inta.c +4 -3
index d4e97605456b..37d09cbdc15c 100644
@@ -182,12 +182,13 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom
 	if (vint_id == TI_SCI_RESOURCE_NULL)
 		return ERR_PTR(-EINVAL);
 
-	p_hwirq = ti_sci_inta_xlate_irq(inta, vint_id);
-	if (p_hwirq < 0) {
-		ret = p_hwirq;
+	ret = ti_sci_inta_xlate_irq(inta, vint_id);
+	if (ret < 0) {
 		goto free_vint;
 	}
 
+	p_hwirq = ret;
+
 	vint_desc = kzalloc(sizeof(*vint_desc), GFP_KERNEL);
 	if (!vint_desc) {
 		ret = -ENOMEM;
Signature · 7 lines
2.25.4


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel