Skip to contentSkip to conversation

dt-bindings: Cleanup of i.MX 8

PATCH In review Krzysztof Kozlowski 4 participants 23 messages Sep 4, 2020 – Sep 19, 2020

Subsystems (15)
lore
Share & tools
lore
#0 lore raw

v3 cover dt-bindings: Cleanup of i.MX 8

Hi Rob,

I am resending the series (v3) without actual changes. You already reviewed many of them. I think that subsystem maintainers are hesitant to pick them up, so maybe this could go via your tree (all of them)?

Changes against previous revisions are in individual patches.

Best regards,
Krzysztof

Krzysztof Kozlowski (14):
dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles
dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles
dt-bindings: serial: fsl-imx-uart: Add i.MX 8M compatibles
dt-bindings: serial: fsl-lpuart: Fix compatible matching
dt-bindings: watchdog: fsl-imx-wdt: Add i.MX 8M compatibles
dt-bindings: reset: fsl,imx7-src: Add i.MX 8M compatibles
dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible
dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles
dt-bindings: mfd: rohm,bd71847-pmic: Correct clock properties
requirements
dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible
matching
dt-bindings: mtd: gpmi-nand: Add i.MX 8M compatibles
dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs
dt-bindings: mtd: nand-controller: Fix matching with size-cells==1
dt-bindings: clock: imx8m: Integrate duplicated i.MX 8M schemas

 .../bindings/clock/imx8m-clock.yaml           | 125 ++++++++++++++++++
 .../bindings/clock/imx8mm-clock.yaml          |  68 ----------
 .../bindings/clock/imx8mn-clock.yaml          |  70 ----------
 .../bindings/clock/imx8mp-clock.yaml          |  70 ----------
 .../bindings/clock/imx8mq-clock.yaml          |  72 ----------
 .../interrupt-controller/fsl,irqsteer.yaml    |   8 +-
 .../bindings/mfd/rohm,bd71847-pmic.yaml       |   9 +-
 .../devicetree/bindings/mtd/gpmi-nand.yaml    |  94 ++++++++++---
 .../bindings/mtd/nand-controller.yaml         |   5 +-
 .../devicetree/bindings/nvmem/imx-ocotp.yaml  |  38 +++---
 .../devicetree/bindings/perf/fsl-imx-ddr.yaml |  16 ++-
 .../devicetree/bindings/pwm/imx-pwm.yaml      |  14 +-
 .../bindings/reset/fsl,imx7-src.yaml          |  19 ++-
 .../bindings/serial/fsl-imx-uart.yaml         |   4 +
 .../bindings/serial/fsl-lpuart.yaml           |  17 ++-
 .../bindings/thermal/imx8mm-thermal.yaml      |  10 +-
 .../bindings/watchdog/fsl-imx-wdt.yaml        |  11 +-
 17 files changed, 303 insertions(+), 347 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/imx8m-clock.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/imx8mm-clock.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/imx8mn-clock.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/imx8mp-clock.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/imx8mq-clock.yaml
Signature · 1 line
2.17.1
#1 lore raw

PATCH v3 1/14 dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: ddr-pmu@3d800000:
compatible:0: 'fsl,imx8mm-ddr-pmu' is not one of ['fsl,imx8-ddr-pmu', 'fsl,imx8m-ddr-pmu', 'fsl,imx8mp-ddr-pmu'] From schema: Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: ddr-pmu@3d800000:
compatible: ['fsl,imx8mm-ddr-pmu', 'fsl,imx8m-ddr-pmu'] is too long

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: ddr-pmu@3d800000:
compatible: Additional items are not allowed ('fsl,imx8m-ddr-pmu' was unexpected)

---

Changes since v1:
1. Handle also fsl,imx8mp-ddr-pmu

---
 .../devicetree/bindings/perf/fsl-imx-ddr.yaml    | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/perf/fsl-imx-ddr.yaml +12 -4
index 9ed8f44adabe..5aad9f4e0b2a 100644
@@ -11,10 +11,18 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx8-ddr-pmu
-      - fsl,imx8m-ddr-pmu
-      - fsl,imx8mp-ddr-pmu
+    oneOf:
+      - enum:
+          - fsl,imx8-ddr-pmu
+          - fsl,imx8m-ddr-pmu
+          - fsl,imx8mp-ddr-pmu
+      - items:
+          - enum:
+              - fsl,imx8mm-ddr-pmu
+              - fsl,imx8mn-ddr-pmu
+              - fsl,imx8mq-ddr-pmu
+              - fsl,imx8mp-ddr-pmu
+          - const: fsl,imx8m-ddr-pmu
 
   reg:
     maxItems: 1
Signature · 1 line
2.17.1
#2 lore raw

PATCH v3 2/14 dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles

In reply to Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:

    compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)

---
 Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/pwm/imx-pwm.yaml +11 -3
index 01df06777cba..473863eb67e5 100644
@@ -19,9 +19,17 @@ properties:
       - 3
 
   compatible:
-    enum:
-      - fsl,imx1-pwm
-      - fsl,imx27-pwm
+    oneOf:
+      - enum:
+          - fsl,imx1-pwm
+          - fsl,imx27-pwm
+      - items:
+          - enum:
+              - fsl,imx8mm-pwm
+              - fsl,imx8mn-pwm
+              - fsl,imx8mp-pwm
+              - fsl,imx8mq-pwm
+          - const: fsl,imx27-pwm
 
   reg:
     maxItems: 1
Signature · 1 line
2.17.1
#4 lore raw

PATCH v3 4/14 dt-bindings: serial: fsl-lpuart: Fix compatible matching

In reply to Krzysztof Kozlowski

The i.MX 8QXP DTSes use two compatibles so update the binding to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@5a060000:
compatible: ['fsl,imx8qxp-lpuart', 'fsl,imx7ulp-lpuart'] is too long From schema: Documentation/devicetree/bindings/serial/fsl-lpuart.yaml

arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: serial@5a060000:
compatible: Additional items are not allowed ('fsl,imx7ulp-lpuart' was unexpected)

---

Changes since v2:
1. Remove moved compatibles.

Changes since v1:
1. New patch.

---
 .../devicetree/bindings/serial/fsl-lpuart.yaml  | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +10 -7
index e82c2cf9fef7..bd21060d26e0 100644
@@ -14,13 +14,16 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - fsl,vf610-lpuart
-      - fsl,ls1021a-lpuart
-      - fsl,ls1028a-lpuart
-      - fsl,imx7ulp-lpuart
-      - fsl,imx8qxp-lpuart
-      - fsl,imx8qm-lpuart
+    oneOf:
+      - enum:
+          - fsl,vf610-lpuart
+          - fsl,ls1021a-lpuart
+          - fsl,ls1028a-lpuart
+          - fsl,imx7ulp-lpuart
+          - fsl,imx8qm-lpuart
+      - items:
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart
 
   reg:
     maxItems: 1
Signature · 1 line
2.17.1
#5 lore raw

PATCH v3 5/14 dt-bindings: watchdog: fsl-imx-wdt: Add i.MX 8M compatibles

In reply to Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
compatible:0: 'fsl,imx8mm-wdt' is not one of ['fsl,imx21-wdt'] From schema: Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml

arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:

    compatible: ['fsl,imx8mm-wdt', 'fsl,imx21-wdt'] is too long

arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dt.yaml: watchdog@30280000:
compatible: Additional items are not allowed ('fsl,imx21-wdt' was unexpected)

---
 .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml     | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml +9 -2
index d96b93b11fad..991b4e33486e 100644
@@ -14,8 +14,15 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx21-wdt
+    oneOf:
+      - const: fsl,imx21-wdt
+      - items:
+          - enum:
+              - fsl,imx8mm-wdt
+              - fsl,imx8mn-wdt
+              - fsl,imx8mp-wdt
+              - fsl,imx8mq-wdt
+          - const: fsl,imx21-wdt
 
   reg:
     maxItems: 1
Signature · 1 line
2.17.1
#6 lore raw

PATCH v3 6/14 dt-bindings: reset: fsl,imx7-src: Add i.MX 8M compatibles

In reply to Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: reset-controller@30390000:
compatible:0: 'fsl,imx8mm-src' is not one of ['fsl,imx7d-src', 'fsl,imx8mq-src', 'fsl,imx8mp-src'] From schema: Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: reset-controller@30390000:
compatible:1: 'syscon' was expected

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: reset-controller@30390000:
compatible: ['fsl,imx8mm-src', 'fsl,imx8mq-src', 'syscon'] is too long

---
 .../bindings/reset/fsl,imx7-src.yaml          | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml +13 -6
index 569cd3bd3a70..00430e2eabc8 100644
@@ -22,12 +22,19 @@ description: |
 
 properties:
   compatible:
-    items:
-      - enum:
-          - fsl,imx7d-src
-          - fsl,imx8mq-src
-          - fsl,imx8mp-src
-      - const: syscon
+    oneOf:
+      - items:
+          - enum:
+              - fsl,imx7d-src
+              - fsl,imx8mq-src
+              - fsl,imx8mp-src
+          - const: syscon
+      - items:
+          - enum:
+              - fsl,imx8mm-src
+              - fsl,imx8mn-src
+          - const: fsl,imx8mq-src
+          - const: syscon
 
   reg:
     maxItems: 1
Signature · 1 line
2.17.1
#7 lore raw

PATCH v3 7/14 dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible

In reply to Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible:0: 'fsl,imx8mn-tmu' is not one of ['fsl,imx8mm-tmu', 'fsl,imx8mp-tmu'] From schema: Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible: ['fsl,imx8mn-tmu', 'fsl,imx8mm-tmu'] is too long

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible: Additional items are not allowed ('fsl,imx8mm-tmu' was unexpected)

---
 .../devicetree/bindings/thermal/imx8mm-thermal.yaml    | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml +7 -3
index 38852877b8e3..89c54e08ee61 100644
@@ -18,9 +18,13 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - fsl,imx8mm-tmu
-      - fsl,imx8mp-tmu
+    oneOf:
+      - enum:
+          - fsl,imx8mm-tmu
+          - fsl,imx8mp-tmu
+      - items:
+          - const: fsl,imx8mn-tmu
+          - const: fsl,imx8mm-tmu
 
   reg:
     maxItems: 1
Signature · 1 line
2.17.1
#10 lore raw

PATCH v3 8/14 dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles

In reply to Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs use two compatibles so update the binding to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000: compatible:1: 'syscon' was expected
From schema: Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000:
compatible: ['fsl,imx8mn-ocotp', 'fsl,imx8mm-ocotp', 'syscon'] is too long

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: efuse@30350000:
compatible: Additional items are not allowed ('syscon' was unexpected)

---

Changes since v2:
1. Remove moved compatibles.

---
 .../devicetree/bindings/nvmem/imx-ocotp.yaml  | 38 +++++++++++--------
 1 file changed, 23 insertions(+), 15 deletions(-)
Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml +23 -15
index 1c9d7f05f173..5a7284737229 100644
@@ -19,21 +19,29 @@ allOf:
 
 properties:
   compatible:
-    items:
-      - enum:
-          - fsl,imx6q-ocotp
-          - fsl,imx6sl-ocotp
-          - fsl,imx6sx-ocotp
-          - fsl,imx6ul-ocotp
-          - fsl,imx6ull-ocotp
-          - fsl,imx7d-ocotp
-          - fsl,imx6sll-ocotp
-          - fsl,imx7ulp-ocotp
-          - fsl,imx8mq-ocotp
-          - fsl,imx8mm-ocotp
-          - fsl,imx8mn-ocotp
-          - fsl,imx8mp-ocotp
-      - const: syscon
+    oneOf:
+      - items:
+          - enum:
+              - fsl,imx6q-ocotp
+              - fsl,imx6sl-ocotp
+              - fsl,imx6sx-ocotp
+              - fsl,imx6ul-ocotp
+              - fsl,imx6ull-ocotp
+              - fsl,imx7d-ocotp
+              - fsl,imx6sll-ocotp
+              - fsl,imx7ulp-ocotp
+              - fsl,imx8mq-ocotp
+              - fsl,imx8mm-ocotp
+          - const: syscon
+      - items:
+          - enum:
+              - fsl,imx8mn-ocotp
+              # i.MX8MP not really compatible with fsl,imx8mm-ocotp, however
+              # the code for getting SoC revision depends on fsl,imx8mm-ocotp
+              # compatible.
+              - fsl,imx8mp-ocotp
+          - const: fsl,imx8mm-ocotp
+          - const: syscon
 
   reg:
     maxItems: 1
Signature · 1 line
2.17.1
#12 lore raw

PATCH v3 10/14 dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible matching

In reply to Krzysztof Kozlowski

The i.MX 8M DTSes use two compatibles so update the binding to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mq-thor96.dt.yaml: interrupt-controller@32e2d000:
compatible: ['fsl,imx8m-irqsteer', 'fsl,imx-irqsteer'] is too long From schema: Domentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml

arch/arm64/boot/dts/freescale/imx8mq-thor96.dt.yaml: interrupt-controller@32e2d000:
compatible: Additional items are not allowed ('fsl,imx-irqsteer' was unexpected)

---
 .../bindings/interrupt-controller/fsl,irqsteer.yaml       | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml +5 -3
index 360a575ef8b0..3b11a1a15398 100644
@@ -11,9 +11,11 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx8m-irqsteer
-      - fsl,imx-irqsteer
+    oneOf:
+      - const: fsl,imx-irqsteer
+      - items:
+          - const: fsl,imx8m-irqsteer
+          - const: fsl,imx-irqsteer
 
   reg:
     maxItems: 1
Signature · 1 line
2.17.1
#14 lore raw

PATCH v3 12/14 dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs

In reply to Krzysztof Kozlowski

Driver requires different amount of clocks for different SoCs. Describe these requirements properly to fix dtbs_check warnings like:

    arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: clock-names:1: 'gpmi_apb' was expected

---

Changes since v1:
1. Do not require order of clocks (use pattern).

---
 .../devicetree/bindings/mtd/gpmi-nand.yaml    | 76 +++++++++++++++----
 1 file changed, 61 insertions(+), 15 deletions(-)
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +61 -15
index 28ff8c581837..e08e0a50929e 100644
@@ -9,9 +9,6 @@ title: Freescale General-Purpose Media Interface (GPMI) binding
 maintainers:
   - Han Xu <[email protected]>
 
-allOf:
-  - $ref: "nand-controller.yaml"
-
 description: |
   The GPMI nand controller provides an interface to control the NAND
   flash chips. The device tree may optionally contain sub-nodes
@@ -58,22 +55,10 @@ properties:
   clocks:
     minItems: 1
     maxItems: 5
-    items:
-      - description: SoC gpmi io clock
-      - description: SoC gpmi apb clock
-      - description: SoC gpmi bch clock
-      - description: SoC gpmi bch apb clock
-      - description: SoC per1 bch clock
 
   clock-names:
     minItems: 1
     maxItems: 5
-    items:
-      - const: gpmi_io
-      - const: gpmi_apb
-      - const: gpmi_bch
-      - const: gpmi_bch_apb
-      - const: per1_bch
 
   fsl,use-minimum-ecc:
     type: boolean
@@ -107,6 +92,67 @@ required:
 
 unevaluatedProperties: false
 
+allOf:
+  - $ref: "nand-controller.yaml"
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx23-gpmi-nand
+              - fsl,imx28-gpmi-nand
+    then:
+      properties:
+        clocks:
+          items:
+            - description: SoC gpmi io clock
+        clock-names:
+          items:
+            - const: gpmi_io
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx6q-gpmi-nand
+              - fsl,imx6sx-gpmi-nand
+    then:
+      properties:
+        clocks:
+          items:
+            - description: SoC gpmi io clock
+            - description: SoC gpmi apb clock
+            - description: SoC gpmi bch clock
+            - description: SoC gpmi bch apb clock
+            - description: SoC per1 bch clock
+        clock-names:
+          items:
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx7d-gpmi-nand
+    then:
+      properties:
+        clocks:
+          items:
+            - description: SoC gpmi io clock
+            - description: SoC gpmi bch apb clock
+        clock-names:
+          minItems: 2
+          maxItems: 2
+          items:
+            - pattern: "^gpmi_(io|bch_apb)$"
+            - pattern: "^gpmi_(io|bch_apb)$"
+
 examples:
   - |
     nand-controller@8000c000 {
Signature · 1 line
2.17.1
#19 lore raw

PATCH v3 13/14 dt-bindings: mtd: nand-controller: Fix matching with size-cells==1

In reply to Krzysztof Kozlowski

Most of Freescale/NXP GPMI device trees use size-cells==1 (even when actually not needed except few boards). This fixes dtbs_check warnings like:

    arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: #size-cells:0:0: 0 was expected
---
 Documentation/devicetree/bindings/mtd/nand-controller.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mtd/nand-controller.yaml +4 -1
index 40fc5b0b2b8c..0879e1108837 100644
@@ -34,7 +34,10 @@ properties:
     const: 1
 
   "#size-cells":
-    const: 0
+    description:
+      Depends on your controller. Put zero unless you need a mapping between CS
+      lines and dedicated memory regions.
+    enum: [0, 1]
 
   ranges: true
 
Signature · 1 line
2.17.1
#21 lore raw

PATCH v3 14/14 dt-bindings: clock: imx8m: Integrate duplicated i.MX 8M schemas

In reply to Krzysztof Kozlowski

The clock controller schemas for i.MX 8M Mini, 8M Nano, 8M Plus and 8M Quad are basically the same. The only minor difference appears on 8M Quad which needs one more clock.

There is no point to have four schemas for almost the same binding. Any fixes or changes would have to be duplicated four times.

---
 .../bindings/clock/imx8m-clock.yaml           | 125 ++++++++++++++++++
 .../bindings/clock/imx8mm-clock.yaml          |  68 ----------
 .../bindings/clock/imx8mn-clock.yaml          |  70 ----------
 .../bindings/clock/imx8mp-clock.yaml          |  70 ----------
 .../bindings/clock/imx8mq-clock.yaml          |  72 ----------
 5 files changed, 125 insertions(+), 280 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/imx8m-clock.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/imx8mm-clock.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/imx8mn-clock.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/imx8mp-clock.yaml
 delete mode 100644 Documentation/devicetree/bindings/clock/imx8mq-clock.yaml
Documentation/devicetree/bindings/clock/imx8m-clock.yaml new file +125 -0
new file mode 100644
index 000000000000..31e7cc9693c3
@@ -0,0 +1,125 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/imx8m-clock.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX8M Family Clock Control Module Binding
+
+maintainers:
+  - Anson Huang <[email protected]>
+
+description: |
+  NXP i.MX8M Mini/Nano/Plus/Quad clock control module is an integrated clock
+  controller, which generates and supplies to all modules.
+
+properties:
+  compatible:
+    enum:
+      - fsl,imx8mm-ccm
+      - fsl,imx8mn-ccm
+      - fsl,imx8mp-ccm
+      - fsl,imx8mq-ccm
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    minItems: 6
+    maxItems: 7
+
+  clock-names:
+    minItems: 6
+    maxItems: 7
+
+  '#clock-cells':
+    const: 1
+    description:
+      The clock consumer should specify the desired clock by having the clock
+      ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h
+      for the full list of i.MX8M clock IDs.
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - '#clock-cells'
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx8mq-ccm
+    then:
+      properties:
+        clocks:
+          minItems: 7
+          maxItems: 7
+          items:
+            - description: 32k osc
+            - description: 25m osc
+            - description: 27m osc
+            - description: ext1 clock input
+            - description: ext2 clock input
+            - description: ext3 clock input
+            - description: ext4 clock input
+        clock-names:
+          minItems: 7
+          maxItems: 7
+          items:
+            - const: ckil
+            - const: osc_25m
+            - const: osc_27m
+            - const: clk_ext1
+            - const: clk_ext2
+            - const: clk_ext3
+            - const: clk_ext4
+    else:
+      properties:
+        clocks:
+          items:
+            - description: 32k osc
+            - description: 24m osc
+            - description: ext1 clock input
+            - description: ext2 clock input
+            - description: ext3 clock input
+            - description: ext4 clock input
+
+        clock-names:
+          items:
+            - const: osc_32k
+            - const: osc_24m
+            - const: clk_ext1
+            - const: clk_ext2
+            - const: clk_ext3
+            - const: clk_ext4
+
+unevaluatedProperties: false
+
+examples:
+  # Clock Control Module node:
+  - |
+    clock-controller@30380000 {
+        compatible = "fsl,imx8mm-ccm";
+        reg = <0x30380000 0x10000>;
+        #clock-cells = <1>;
+        clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>,
+                 <&clk_ext3>, <&clk_ext4>;
+        clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2",
+                      "clk_ext3", "clk_ext4";
+    };
+
+  - |
+    clock-controller@30390000 {
+        compatible = "fsl,imx8mq-ccm";
+        reg = <0x30380000 0x10000>;
+        #clock-cells = <1>;
+        clocks = <&ckil>, <&osc_25m>, <&osc_27m>, <&clk_ext1>,
+                 <&clk_ext2>, <&clk_ext3>, <&clk_ext4>;
+        clock-names = "ckil", "osc_25m", "osc_27m", "clk_ext1",
+                      "clk_ext2", "clk_ext3", "clk_ext4";
+    };
+
+...
Documentation/devicetree/bindings/clock/imx8mm-clock.yaml deleted +0 -68

68 lines not on this page · raw message

Documentation/devicetree/bindings/clock/imx8mn-clock.yaml deleted +0 -70

70 lines not on this page · raw message

Documentation/devicetree/bindings/clock/imx8mp-clock.yaml deleted +0 -70

70 lines not on this page · raw message

Documentation/devicetree/bindings/clock/imx8mq-clock.yaml deleted +0 -72

72 lines not on this page · raw message

Signature · 1 line
2.17.1
#3 lore raw

PATCH v3 3/14 dt-bindings: serial: fsl-imx-uart: Add i.MX 8M compatibles

In reply to Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible:0: 'fsl,imx8mm-pwm' is not one of ['fsl,imx1-pwm', 'fsl,imx27-pwm'] From schema: Documentation/devicetree/bindings/pwm/imx-pwm.yaml

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:

    compatible: ['fsl,imx8mm-pwm', 'fsl,imx27-pwm'] is too long

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: pwm@30660000:
compatible: Additional items are not allowed ('fsl,imx27-pwm' was unexpected)

---

Changes since v1:
1. Fix subject prefix

---
 Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml +4 -0
index cba3f83ccd5f..3d896173b3b0 100644
@@ -36,6 +36,10 @@ properties:
             - fsl,imx6sx-uart
             - fsl,imx6ul-uart
             - fsl,imx7d-uart
+            - fsl,imx8mm-uart
+            - fsl,imx8mn-uart
+            - fsl,imx8mp-uart
+            - fsl,imx8mq-uart
           - const: fsl,imx6q-uart
 
   reg:
Signature · 6 lines
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#11 lore raw

PATCH v3 9/14 dt-bindings: mfd: rohm,bd71847-pmic: Correct clock properties requirements

In reply to Krzysztof Kozlowski

The input clock and number of clock provider cells are not required for the PMIC to operate. They are needed only for the optional bd718x7 clock driver.

Add also clock-output-names as driver takes use of it.

This fixes dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: pmic@4b: 'clocks' is a required property arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dt.yaml: pmic@4b: '#clock-cells' is a required property

---
 .../devicetree/bindings/mfd/rohm,bd71847-pmic.yaml       | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml +7 -2
index 77bcca2d414f..5d531051a153 100644
@@ -38,6 +38,9 @@ properties:
   "#clock-cells":
     const: 0
 
+  clock-output-names:
+    maxItems: 1
+
 # The BD71847 abd BD71850 support two different HW states as reset target
 # states. States are called as SNVS and READY. At READY state all the PMIC
 # power outputs go down and OTP is reload. At the SNVS state all other logic
@@ -116,12 +119,14 @@ required:
   - compatible
   - reg
   - interrupts
-  - clocks
-  - "#clock-cells"
   - regulators
 
 additionalProperties: false
 
+dependencies:
+  '#clock-cells': [clocks]
+  clocks: ['#clock-cells']
+
 examples:
   - |
     #include <dt-bindings/interrupt-controller/irq.h>
Signature · 1 line
2.17.1
#13 lore raw

PATCH v3 11/14 dt-bindings: mtd: gpmi-nand: Add i.MX 8M compatibles

In reply to Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: nand-controller@33002000:
compatible:0: 'fsl,imx8mm-gpmi-nand' is not one of ['fsl,imx23-gpmi-nand', 'fsl,imx28-gpmi-nand', 'fsl,imx6q-gpmi-nand', 'fsl,imx6sx-gpmi-nand', 'fsl,imx7d-gpmi-nand'] From schema: Documentation/devicetree/bindings/mtd/gpmi-nand.yaml

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: nand-controller@33002000:
compatible: ['fsl,imx8mm-gpmi-nand', 'fsl,imx7d-gpmi-nand'] is too long

arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: nand-controller@33002000:
compatible: Additional items are not allowed ('fsl,imx7d-gpmi-nand' was unexpected)

---
 .../devicetree/bindings/mtd/gpmi-nand.yaml     | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +12 -6
index 3201372b7f85..28ff8c581837 100644
@@ -20,12 +20,18 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - fsl,imx23-gpmi-nand
-      - fsl,imx28-gpmi-nand
-      - fsl,imx6q-gpmi-nand
-      - fsl,imx6sx-gpmi-nand
-      - fsl,imx7d-gpmi-nand
+    oneOf:
+      - enum:
+          - fsl,imx23-gpmi-nand
+          - fsl,imx28-gpmi-nand
+          - fsl,imx6q-gpmi-nand
+          - fsl,imx6sx-gpmi-nand
+          - fsl,imx7d-gpmi-nand
+      - items:
+          - enum:
+              - fsl,imx8mm-gpmi-nand
+              - fsl,imx8mn-gpmi-nand
+          - const: fsl,imx7d-gpmi-nand
 
   reg:
     items:
Signature · 1 line
2.17.1
#20 lore raw

Re: [PATCH v3 13/14] dt-bindings: mtd: nand-controller: Fix matching with size-cells==1

In reply to Krzysztof Kozlowski
Quoted 17 lines · Krzysztof Kozlowski

Most of Freescale/NXP GPMI device trees use size-cells==1 (even when actually not needed except few boards). This fixes dtbs_check warnings like:

    arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: #size-cells:0:0: 0 was expected
---
 Documentation/devicetree/bindings/mtd/nand-controller.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mtd/nand-controller.yaml +0 -0
index 40fc5b0b2b8c..0879e1108837 100644

Documentation/devicetree/bindings/mtd/nand-controller.yaml properties: · line 40

Quoted 8 lines
Documentation/devicetree/bindings/mtd/nand-controller.yaml +4 -1
@@ -34,7 +34,10 @@ properties:
     const: 1
 
   "#size-cells":
-    const: 0
+    description:
+      Depends on your controller. Put zero unless you need a mapping between CS
+      lines and dedicated memory regions.
+    enum: [0, 1]

Humm, seems that was to describe partitions, but the expectation of the nand binding is describing nand chips. It seems the nand chips are never described and on 1 board even has partitions. I think you should fix the dts to move 'partition@N' nodes under 'partitions' which is preferred and needed if you ever describe nand chips. And then fix '#size-cells' to be 0.

Rob

#15 lore raw

Re: [PATCH v3 12/14] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs

In reply to Krzysztof Kozlowski
Quoted 4 lines · Krzysztof Kozlowski

Driver requires different amount of clocks for different SoCs. Describe these requirements properly to fix dtbs_check warnings like:

Quoted 8 lines
    arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: clock-names:1: 'gpmi_apb' was expected

---

Changes since v1:
1. Do not require order of clocks (use pattern).

To the extent that you can, you should fix the order in dts files first. If we just adjust the schemas to match the dts files, then what's the point?

Quoted 77 lines
---
 .../devicetree/bindings/mtd/gpmi-nand.yaml    | 76 +++++++++++++++----
 1 file changed, 61 insertions(+), 15 deletions(-)
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +32 -15
index 28ff8c581837..e08e0a50929e 100644
@@ -9,9 +9,6 @@ title: Freescale General-Purpose Media Interface (GPMI) binding
 maintainers:
   - Han Xu <[email protected]>
 
-allOf:
-  - $ref: "nand-controller.yaml"
-
 description: |
   The GPMI nand controller provides an interface to control the NAND
   flash chips. The device tree may optionally contain sub-nodes
@@ -58,22 +55,10 @@ properties:
   clocks:
     minItems: 1
     maxItems: 5
-    items:
-      - description: SoC gpmi io clock
-      - description: SoC gpmi apb clock
-      - description: SoC gpmi bch clock
-      - description: SoC gpmi bch apb clock
-      - description: SoC per1 bch clock
 
   clock-names:
     minItems: 1
     maxItems: 5
-    items:
-      - const: gpmi_io
-      - const: gpmi_apb
-      - const: gpmi_bch
-      - const: gpmi_bch_apb
-      - const: per1_bch
 
   fsl,use-minimum-ecc:
     type: boolean
@@ -107,6 +92,67 @@ required:
 
 unevaluatedProperties: false
 
+allOf:
+  - $ref: "nand-controller.yaml"
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx23-gpmi-nand
+              - fsl,imx28-gpmi-nand
+    then:
+      properties:
+        clocks:
+          items:
+            - description: SoC gpmi io clock
+        clock-names:
+          items:
+            - const: gpmi_io
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx6q-gpmi-nand
+              - fsl,imx6sx-gpmi-nand
+    then:
+      properties:
+        clocks:
+          items:
+            - description: SoC gpmi io clock
+            - description: SoC gpmi apb clock

Documentation/devicetree/bindings/mtd/gpmi-nand.yaml required: · line 136

Quoted 10 lines
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +10 -0
+            - description: SoC gpmi bch clock
+            - description: SoC gpmi bch apb clock
+            - description: SoC per1 bch clock
+        clock-names:
+          items:
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"

BTW, you can make 'items' a schema rather than a list to apply a constraint to all entries:

maxItems: 5
items:
pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"

Quoted 5 lines
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +5 -0
+
+  - if:
+      properties:
+        compatible:
+          contains:

Documentation/devicetree/bindings/mtd/gpmi-nand.yaml required: · line 151

Quoted 10 lines
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +10 -0
+            const: fsl,imx7d-gpmi-nand
+    then:
+      properties:
+        clocks:
+          items:
+            - description: SoC gpmi io clock
+            - description: SoC gpmi bch apb clock
+        clock-names:
+          minItems: 2
+          maxItems: 2

You can drop these. It's the default based on the size of 'items'.

Documentation/devicetree/bindings/mtd/gpmi-nand.yaml required: · line 154

Quoted 3 lines
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +3 -0
+          items:
+            - pattern: "^gpmi_(io|bch_apb)$"
+            - pattern: "^gpmi_(io|bch_apb)$"

Surely here we can define the order.

Quoted 7 lines
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +1 -1
+
 examples:
   - |
     nand-controller@8000c000 {
--

2.17.1

#16 lore raw

Re: [PATCH v3 12/14] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs

Quoted 9 lines · Rob Herring
Quoted 8 lines · Krzysztof Kozlowski

Driver requires different amount of clocks for different SoCs. Describe these requirements properly to fix dtbs_check warnings like:

    arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: clock-names:1: 'gpmi_apb' was expected
Quoted 8 lines
Quoted 4 lines

---

Changes since v1:
1. Do not require order of clocks (use pattern).

To the extent that you can, you should fix the order in dts files first. If we just adjust the schemas to match the dts files, then what's the point?

The DTSes do not have mixed order of clocks between each other, as fair as I remember. It was fix after Sasha Hauer comment that order is not necessarily good.

We have the clock-names property, why enforcing the order?

Quoted 92 lines
Quoted 78 lines
---
 .../devicetree/bindings/mtd/gpmi-nand.yaml    | 76 +++++++++++++++----
 1 file changed, 61 insertions(+), 15 deletions(-)
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +32 -15
index 28ff8c581837..e08e0a50929e 100644
@@ -9,9 +9,6 @@ title: Freescale General-Purpose Media Interface (GPMI) binding
 maintainers:
   - Han Xu <[email protected]>
 
-allOf:
-  - $ref: "nand-controller.yaml"
-
 description: |
   The GPMI nand controller provides an interface to control the NAND
   flash chips. The device tree may optionally contain sub-nodes
@@ -58,22 +55,10 @@ properties:
   clocks:
     minItems: 1
     maxItems: 5
-    items:
-      - description: SoC gpmi io clock
-      - description: SoC gpmi apb clock
-      - description: SoC gpmi bch clock
-      - description: SoC gpmi bch apb clock
-      - description: SoC per1 bch clock
 
   clock-names:
     minItems: 1
     maxItems: 5
-    items:
-      - const: gpmi_io
-      - const: gpmi_apb
-      - const: gpmi_bch
-      - const: gpmi_bch_apb
-      - const: per1_bch
 
   fsl,use-minimum-ecc:
     type: boolean
@@ -107,6 +92,67 @@ required:
 
 unevaluatedProperties: false
 
+allOf:
+  - $ref: "nand-controller.yaml"
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx23-gpmi-nand
+              - fsl,imx28-gpmi-nand
+    then:
+      properties:
+        clocks:
+          items:
+            - description: SoC gpmi io clock
+        clock-names:
+          items:
+            - const: gpmi_io
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx6q-gpmi-nand
+              - fsl,imx6sx-gpmi-nand
+    then:
+      properties:
+        clocks:
+          items:
+            - description: SoC gpmi io clock
+            - description: SoC gpmi apb clock

Documentation/devicetree/bindings/mtd/gpmi-nand.yaml required: · line 136

Quoted 10 lines
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +10 -0
+            - description: SoC gpmi bch clock
+            - description: SoC gpmi bch apb clock
+            - description: SoC per1 bch clock
+        clock-names:
+          items:
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"
+            - pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"

BTW, you can make 'items' a schema rather than a list to apply a constraint to all entries:

Quoted 3 lines

maxItems: 5
items:
pattern: "^(gpmi_(io|apb|bch|bch_apb)|per1_bch)$"

Right, I forgot about such syntax.

Quoted 17 lines
Quoted 6 lines
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +5 -0
+
+  - if:
+      properties:
+        compatible:
+          contains:

Documentation/devicetree/bindings/mtd/gpmi-nand.yaml required: · line 151

Quoted 10 lines
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +10 -0
+            const: fsl,imx7d-gpmi-nand
+    then:
+      properties:
+        clocks:
+          items:
+            - description: SoC gpmi io clock
+            - description: SoC gpmi bch apb clock
+        clock-names:
+          minItems: 2
+          maxItems: 2
Quoted 1 line

You can drop these. It's the default based on the size of 'items'.

Sure.

Quoted 6 lines

Documentation/devicetree/bindings/mtd/gpmi-nand.yaml required: · line 154

Quoted 4 lines
Documentation/devicetree/bindings/mtd/gpmi-nand.yaml +3 -0
+          items:
+            - pattern: "^gpmi_(io|bch_apb)$"
+            - pattern: "^gpmi_(io|bch_apb)$"

Surely here we can define the order.

Yes, but still the same question as before - do we want the order? Why enforcing it?

Best regards,
Krzysztof

#17 lore raw

Re: [PATCH v3 12/14] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs

Quoted 20 lines · Krzysztof Kozlowski
Quoted 9 lines · Rob Herring
Quoted 8 lines · Krzysztof Kozlowski

Driver requires different amount of clocks for different SoCs. Describe these requirements properly to fix dtbs_check warnings like:

    arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: clock-names:1: 'gpmi_apb' was expected
Quoted 8 lines
Quoted 4 lines

---

Changes since v1:
1. Do not require order of clocks (use pattern).

To the extent that you can, you should fix the order in dts files first. If we just adjust the schemas to match the dts files, then what's the point?

Quoted 5 lines

The DTSes do not have mixed order of clocks between each other, as fair as I remember. It was fix after Sasha Hauer comment that order is not necessarily good.

We have the clock-names property, why enforcing the order?

Because DT/OpenFirmware has always had a defined order for property values. '*-names' is just extra information.

Rob

#18 lore raw

Re: [PATCH v3 12/14] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs

Quoted 22 lines · Rob Herring
Quoted 20 lines · Krzysztof Kozlowski
Quoted 17 lines · Rob Herring
Quoted 4 lines · Krzysztof Kozlowski

Driver requires different amount of clocks for different SoCs. Describe these requirements properly to fix dtbs_check warnings like:

Quoted 8 lines
    arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: clock-names:1: 'gpmi_apb' was expected

---

Changes since v1:
1. Do not require order of clocks (use pattern).

To the extent that you can, you should fix the order in dts files first. If we just adjust the schemas to match the dts files, then what's the point?

Quoted 8 lines
Quoted 5 lines

The DTSes do not have mixed order of clocks between each other, as fair as I remember. It was fix after Sasha Hauer comment that order is not necessarily good.

We have the clock-names property, why enforcing the order?

Because DT/OpenFirmware has always had a defined order for property values. '*-names' is just extra information.

Thanks for the explanation. There are few nonobvious requirements about writing schema which seems many (including me) miss. It might be a good topic for some conference. Too bad ELCE CFP ended some time ago. :)

Best regards,
Krzysztof

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

maintainer
#22 lore raw
In reply to Krzysztof Kozlowski
Quoted 21 lines · Krzysztof Kozlowski

Hi Rob,

I am resending the series (v3) without actual changes. You already reviewed many of them. I think that subsystem maintainers are hesitant to pick them up, so maybe this could go via your tree (all of them)?

Changes against previous revisions are in individual patches.

Best regards,
Krzysztof

Krzysztof Kozlowski (14):
dt-bindings: perf: fsl-imx-ddr: Add i.MX 8M compatibles
dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles
dt-bindings: serial: fsl-imx-uart: Add i.MX 8M compatibles
dt-bindings: serial: fsl-lpuart: Fix compatible matching
dt-bindings: watchdog: fsl-imx-wdt: Add i.MX 8M compatibles
dt-bindings: reset: fsl,imx7-src: Add i.MX 8M compatibles
dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible
dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles

Quoted 8 lines

dt-bindings: mfd: rohm,bd71847-pmic: Correct clock properties
requirements
dt-bindings: interrupt-controller: fsl,irqsteer: Fix compatible
matching
dt-bindings: mtd: gpmi-nand: Add i.MX 8M compatibles
dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs
dt-bindings: mtd: nand-controller: Fix matching with size-cells==1
dt-bindings: clock: imx8m: Integrate duplicated i.MX 8M schemas

I've applied patches 1-11 and 14.

Rob

#8 lore raw

Re: [PATCH v3 07/14] dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible

In reply to Krzysztof Kozlowski
Quoted 10 lines · Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible:0: 'fsl,imx8mn-tmu' is not one of ['fsl,imx8mm-tmu', 'fsl,imx8mp-tmu'] From schema: Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible: ['fsl,imx8mn-tmu', 'fsl,imx8mm-tmu'] is too long

Quoted 6 lines

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible: Additional items are not allowed ('fsl,imx8mm-tmu' was unexpected)

---

Shall I pick this patch separately or did you merge the entire series ?

Quoted 25 lines
 .../devicetree/bindings/thermal/imx8mm-thermal.yaml    | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml +7 -3
index 38852877b8e3..89c54e08ee61 100644
@@ -18,9 +18,13 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - fsl,imx8mm-tmu
-      - fsl,imx8mp-tmu
+    oneOf:
+      - enum:
+          - fsl,imx8mm-tmu
+          - fsl,imx8mp-tmu
+      - items:
+          - const: fsl,imx8mn-tmu
+          - const: fsl,imx8mm-tmu
 
   reg:
     maxItems: 1
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#9 lore raw

Re: [PATCH v3 07/14] dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible

Quoted 12 lines · Daniel Lezcano
Quoted 10 lines · Krzysztof Kozlowski

DTSes with new i.MX 8M SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible:0: 'fsl,imx8mn-tmu' is not one of ['fsl,imx8mm-tmu', 'fsl,imx8mp-tmu'] From schema: Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible: ['fsl,imx8mn-tmu', 'fsl,imx8mm-tmu'] is too long

Quoted 8 lines
Quoted 6 lines

arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
compatible: Additional items are not allowed ('fsl,imx8mm-tmu' was unexpected)

---

Shall I pick this patch separately or did you merge the entire series ?

Thanks. Rob already picked this up.

Best regards,
Krzysztof