drm: panel: add support for TDO tl070wsh30 panel
Subsystems (5)
cover drm: panel: add support for TDO tl070wsh30 panel
This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel module shipped with the Amlogic S400 Development Kit.
The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller.
Changes since v1 at [1]:
- added missing vendor-prefixes patch
- removed vrefresh
- fixed warning on add_panel return
- removed DRM logging
[1] https://patchwork.freedesktop.org/series/81376/#rev1
Neil Armstrong (3):
dt-bindings: vendor-prefixes: Add Shanghai Top Display
Optolelectronics vendor prefix
dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings
drm: panel: add TDO tl070wsh30 panel driver
.../display/panel/tdo,tl070wsh30.yaml | 58 ++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 256 ++++++++++++++++++ 5 files changed, 328 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 1/3 dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix
Shanghai Top Display Optolelectronics Co., Ltd is a display manufacturer from Shanghai.
Web site of the company: http://www.shtdo.com/
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -1078,6 +1078,8 @@ patternProperties: description: TPK U.S.A. LLC "^tplink,.*": description: TP-LINK Technologies Co., Ltd. + "^tdo,.*": + description: Shangai Top Display Optoelectronics Co., Ltd "^tpo,.*": description: TPO "^tq,.*":
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 2/3 dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings
In reply to Neil ArmstrongThis add the bindings for the 1024*600 tl070wsh30 DSI panel.
--- .../display/panel/tdo,tl070wsh30.yaml | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml
Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml new file +58 -0
@@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +# Copyright 2020 BayLibre, SAS +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/tdo,tl070wsh30.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TDO TL070WSH30 DSI panel + +maintainers: + - Neil Armstrong <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + + compatible: + enum: + - tdo,tl070wsh30 + + reg: + maxItems: 1 + description: DSI virtual channel + + backlight: true + reset-gpios: true + port: true + power-supply: true + +additionalProperties: false + +required: + - compatible + - power-supply + - reset-gpios + - port + - reg + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "tdo,tl070wsh30"; + reg = <0>; + power-supply = <&vcc_lcd_reg>; + backlight = <&panel_backlight>; + reset-gpios = <&gpio_reset>; + + port { + panel: endpoint { + remote-endpoint = <&mipi_dsi_out>; + }; + }; + }; + };
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings
Hi Neil.
Quoted 1 line · Neil Armstrong
This add the bindings for the 1024*600 tl070wsh30 DSI panel.
The binding looks like a panel-simple-dsi.yaml candidate. Only differen is enable-gpios versus reset-gpios
Could you check if we can use panel-simple-dsi-yaml.
Sam
Quoted 73 lines
Signed-off-by Neil Armstrong <[email protected]>--- .../display/panel/tdo,tl070wsh30.yaml | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yamlDocumentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml new file +58
-0@@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +# Copyright 2020 BayLibre, SAS +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/tdo,tl070wsh30.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TDO TL070WSH30 DSI panel + +maintainers: + - Neil Armstrong <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + + compatible: + enum: + - tdo,tl070wsh30 + + reg: + maxItems: 1 + description: DSI virtual channel + + backlight: true + reset-gpios: true + port: true + power-supply: true + +additionalProperties: false + +required: + - compatible + - power-supply + - reset-gpios + - port + - reg + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "tdo,tl070wsh30"; + reg = <0>; + power-supply = <&vcc_lcd_reg>; + backlight = <&panel_backlight>; + reset-gpios = <&gpio_reset>; + + port { + panel: endpoint { + remote-endpoint = <&mipi_dsi_out>; + }; + }; + }; + };Signature · 1 line
2.22.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings
Hi,
Quoted 7 lines · Sam Ravnborg
Hi Neil.
Quoted 1 line · Neil Armstrong
This add the bindings for the 1024*600 tl070wsh30 DSI panel.
The binding looks like a
panel-simple-dsi.yamlcandidate. Only differen is enable-gpios versus reset-gpios
This is the only difference, the panel only has a reset signal and no enable signal.
But I can add a reset-gpios to panel-simple-dsi.yaml, would it be ok ?
Neil
Quoted 70 lines
Could you check if we can use panel-simple-dsi-yaml.
Sam
Quoted 65 lines
Signed-off-by Neil Armstrong <[email protected]>--- .../display/panel/tdo,tl070wsh30.yaml | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yamlDocumentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml new file +52
-0@@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +# Copyright 2020 BayLibre, SAS +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/tdo,tl070wsh30.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TDO TL070WSH30 DSI panel + +maintainers: + - Neil Armstrong <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + + compatible: + enum: + - tdo,tl070wsh30 + + reg: + maxItems: 1 + description: DSI virtual channel + + backlight: true + reset-gpios: true + port: true + power-supply: true + +additionalProperties: false + +required: + - compatible + - power-supply + - reset-gpios + - port + - reg + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "tdo,tl070wsh30"; + reg = <0>; + power-supply = <&vcc_lcd_reg>; + backlight = <&panel_backlight>; + reset-gpios = <&gpio_reset>; + + port {
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml new file +6
-0+ panel: endpoint { + remote-endpoint = <&mipi_dsi_out>; + }; + }; + }; + };Signature · 1 line
2.22.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings
Hi Neil.
Quoted 8 lines · Neil Armstrong
Hi,
Quoted 5 lines · Sam Ravnborg
Hi Neil.
Quoted 1 line · Neil Armstrong
This add the bindings for the 1024*600 tl070wsh30 DSI panel.
Quoted 7 lines
Quoted 2 lines
The binding looks like a
panel-simple-dsi.yamlcandidate. Only differen is enable-gpios versus reset-gpiosThis is the only difference, the panel only has a reset signal and no enable signal.
But I can add a reset-gpios to
panel-simple-dsi.yaml, would it be ok ?
Yes, that would be fine as long as it is not a required property. It was a mistake we did not add it from the beginning.
There has been patches floating to add reset-gpios to panle.simple.c that I rejected - this was also wrong.
Really simple and dumb panels has no reset but dsi panels that panel-simple supports too has a reset.
Sam
Quoted 78 lines
Neil
Quoted 75 lines
Could you check if we can use panel-simple-dsi-yaml.
Sam
Quoted 70 lines
Signed-off-by Neil Armstrong <[email protected]>--- .../display/panel/tdo,tl070wsh30.yaml | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yamlDocumentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml new file +57
-0@@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +# Copyright 2020 BayLibre, SAS +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/tdo,tl070wsh30.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TDO TL070WSH30 DSI panel + +maintainers: + - Neil Armstrong <[email protected]> + +allOf: + - $ref: panel-common.yaml# + +properties: + + compatible: + enum: + - tdo,tl070wsh30 + + reg: + maxItems: 1 + description: DSI virtual channel + + backlight: true + reset-gpios: true + port: true + power-supply: true + +additionalProperties: false + +required: + - compatible + - power-supply + - reset-gpios + - port + - reg + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "tdo,tl070wsh30"; + reg = <0>; + power-supply = <&vcc_lcd_reg>; + backlight = <&panel_backlight>; + reset-gpios = <&gpio_reset>; + + port { + panel: endpoint { + remote-endpoint = <&mipi_dsi_out>; + }; + }; + };
Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml new file +1
-0+ };Signature · 1 line
2.22.0_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 3/3 drm: panel: add TDO tl070wsh30 panel driver
In reply to Neil ArmstrongThis adds support for the TDO TL070WSH30 TFT-LCD panel module. The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller.
--- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 256 +++++++++++++++++++ 3 files changed, 268 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
drivers/gpu/drm/panel/Kconfig +11 -0
@@ -433,6 +433,17 @@ config DRM_PANEL_SONY_ACX565AKM Say Y here if you want to enable support for the Sony ACX565AKM 800x600 3.5" panel (found on the Nokia N900). +config DRM_PANEL_TDO_TL070WSH30 + tristate "TDO TL070WSH30 DSI panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for TDO TL070WSH30 TFT-LCD + panel module. The panel has a 1024×600 resolution and uses + 24 bit RGB per pixel. It provides a MIPI DSI interface to + the host, a built-in LED backlight and touch controller. + config DRM_PANEL_TPO_TD028TTEC1 tristate "Toppoly (TPO) TD028TTEC1 panel driver" depends on OF && SPI
drivers/gpu/drm/panel/Makefile +1 -0
@@ -45,6 +45,7 @@ obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o obj-$(CONFIG_DRM_PANEL_SONY_ACX424AKP) += panel-sony-acx424akp.o obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o +obj-$(CONFIG_DRM_PANEL_TDO_TL070WSH30) += panel-tdo-tl070wsh30.o obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.o
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +256 -0
256 lines not on this page · raw message
Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 3/3] drm: panel: add TDO tl070wsh30 panel driver
Hi Neil.
Quoted 4 lines · Neil Armstrong
This adds support for the TDO TL070WSH30 TFT-LCD panel module. The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller.
Despite a nicely written driver I noticed a few things that needs to be addressed.
Sam
Quoted 74 lines
Signed-off-by Neil Armstrong <[email protected]>--- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 256 +++++++++++++++++++ 3 files changed, 268 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.cdrivers/gpu/drm/panel/Kconfig +11
-0@@ -433,6 +433,17 @@ config DRM_PANEL_SONY_ACX565AKM Say Y here if you want to enable support for the Sony ACX565AKM 800x600 3.5" panel (found on the Nokia N900). +config DRM_PANEL_TDO_TL070WSH30 + tristate "TDO TL070WSH30 DSI panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for TDO TL070WSH30 TFT-LCD + panel module. The panel has a 1024×600 resolution and uses + 24 bit RGB per pixel. It provides a MIPI DSI interface to + the host, a built-in LED backlight and touch controller. + config DRM_PANEL_TPO_TD028TTEC1 tristate "Toppoly (TPO) TD028TTEC1 panel driver" depends on OF && SPIdrivers/gpu/drm/panel/Makefile +1
-0@@ -45,6 +45,7 @@ obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o obj-$(CONFIG_DRM_PANEL_SONY_ACX424AKP) += panel-sony-acx424akp.o obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o +obj-$(CONFIG_DRM_PANEL_TDO_TL070WSH30) += panel-tdo-tl070wsh30.o obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.odrivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +25
-0@@ -0,0 +1,256 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (C) 2020 BayLibre, SAS +* Author: Neil Armstrong <[email protected]> +*/ + +#include <linux/delay.h> +#include <linux/gpio/consumer.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/regulator/consumer.h> + +#include <video/mipi_display.h> + +#include <drm/drm_crtc.h> +#include <drm/drm_device.h> +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_modes.h> +#include <drm/drm_panel.h> + +struct tdo_tl070wsh30_panel { +struct drm_panel base; +struct mipi_dsi_device *link; + +struct regulator *supply;
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 35
Quoted 10 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +10
-0+struct gpio_desc *reset_gpio; + +bool prepared; +}; + +static inline +struct tdo_tl070wsh30_panel *to_tdo_tl070wsh30_panel (struct drm_panel *panel) +{ + return container_of(panel, struct tdo_tl070wsh30_panel, base); +}
bikeshedding - but my preference is to order the functions:
prepare
enable
disable
unprepare
As this is the natural order they are used.
Feel free to ignore!
Quoted 69 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +69
-0+ +static int tdo_tl070wsh30_panel_unprepare (struct drm_panel *panel) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30 =to_tdo_tl070wsh30_panel (panel); +int err; + +if (!tdo_tl070wsh30->prepared) +return 0 ; + + err =mipi_dsi_dcs_set_display_off (tdo_tl070wsh30->link); +if (err <0 ) +dev_err (panel->dev,"failed to set display off: %d\n" , err); + +usleep_range (10000 ,11000 ); + + err =mipi_dsi_dcs_enter_sleep_mode (tdo_tl070wsh30->link); +if (err <0 ) { +dev_err (panel->dev,"failed to enter sleep mode: %d\n" , err); +return err; + } + +usleep_range (10000 ,11000 ); + + tdo_tl070wsh30->prepared = false; + +return 0 ; +} + +static int tdo_tl070wsh30_panel_prepare (struct drm_panel *panel) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30 =to_tdo_tl070wsh30_panel (panel); +int err; + +if (tdo_tl070wsh30->prepared) +return 0 ; + + err =mipi_dsi_dcs_exit_sleep_mode (tdo_tl070wsh30->link); +if (err <0 ) { +dev_err (panel->dev,"failed to exit sleep mode: %d\n" , err); +return err; + } + +msleep (200 ); + + err =mipi_dsi_dcs_set_display_on (tdo_tl070wsh30->link); +if (err <0 ) { +dev_err (panel->dev,"failed to set display on: %d\n" , err); +return err; + } + +msleep (20 ); + + tdo_tl070wsh30->prepared = true; + +return 0 ; +} + +static const struct drm_display_mode default_mode = { + .clock =47250 , + .hdisplay =1024 , + .hsync_start =1024 +46 , + .hsync_end =1024 +46 +80 , + .htotal =1024 +46 +80 +100 , + .vdisplay =600 , + .vsync_start =600 +5 , + .vsync_end =600 +5 +5 , + .vtotal =600 +5 +5 +20 , + .flags =DRM_MODE_FLAG_PHSYNC |DRM_MODE_FLAG_PVSYNC , +};
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 114
Quoted 10 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +10
-0+ +static int tdo_tl070wsh30_panel_get_modes (struct drm_panel *panel, +struct drm_connector *connector) +{ +struct drm_display_mode *mode; + + mode =drm_mode_duplicate (connector->dev, &default_mode); +if (!mode) { +dev_err (panel->dev,"failed to add mode %ux%ux\n" , default_mode.hdisplay, + default_mode.vdisplay);
Here we often print the refresh rate too.
If there is no need for the refresh rate than at least drop the extra 'x' at the end of the line.
Quoted 13 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +13
-0+return -ENOMEM ; + } + +drm_mode_set_name (mode); + +drm_mode_probed_add (connector, mode); + + connector->display_info.width_mm =154 ; + connector->display_info.height_mm =85 ; + connector->display_info.bpc =8 ; + +return 1 ; +}
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 137
Quoted 10 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +10
-0+ +static const struct drm_panel_funcs tdo_tl070wsh30_panel_funcs = { + .unprepare = tdo_tl070wsh30_panel_unprepare, + .prepare = tdo_tl070wsh30_panel_prepare, + .get_modes = tdo_tl070wsh30_panel_get_modes, +}; + +static const struct of_device_id tdo_tl070wsh30_of_match[] = { + { .compatible ="tdo,tl070wsh30" , }, + { }
I often recommends
{ /* sentinel },but thats just to be consistent with what I see in other drivers.
Quoted 34 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +31
-0+}; +MODULE_DEVICE_TABLE (of, tdo_tl070wsh30_of_match); + +static int tdo_tl070wsh30_panel_add (struct tdo_tl070wsh30_panel *tdo_tl070wsh30) +{ +struct device *dev = &tdo_tl070wsh30->link->dev; +int err; + + tdo_tl070wsh30->supply =devm_regulator_get (dev,"power" ); +if (IS_ERR (tdo_tl070wsh30->supply)) +return PTR_ERR (tdo_tl070wsh30->supply); + + tdo_tl070wsh30->reset_gpio =devm_gpiod_get (dev,"reset" , +GPIOD_OUT_LOW ); +if (IS_ERR (tdo_tl070wsh30->reset_gpio)) { + err =PTR_ERR (tdo_tl070wsh30->reset_gpio); +dev_dbg (dev,"failed to get reset gpio: %d\n" , err); +return err; + } + +drm_panel_init (&tdo_tl070wsh30->base, &tdo_tl070wsh30->link->dev, + &tdo_tl070wsh30_panel_funcs,DRM_MODE_CONNECTOR_DSI ); + + err =drm_panel_of_backlight (&tdo_tl070wsh30->base); +if (err) +return err; + + err =regulator_enable (tdo_tl070wsh30->supply); +if (err <0 ) +return err; +
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 178
Quoted 10 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +10
-0+usleep_range (10000 ,11000 ); + +gpiod_set_value_cansleep (tdo_tl070wsh30->reset_gpio,1 ); + +usleep_range (10000 ,11000 ); + +gpiod_set_value_cansleep (tdo_tl070wsh30->reset_gpio,0 ); + +msleep (200 ); +
It is the job of the prepare function to turn on the panel, and likewise the unprepare to turn off the panel. Please move the code above to the prepare function.
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 187
Quoted 9 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +9
-0+drm_panel_add (&tdo_tl070wsh30->base); + +return 0 ; +} + +static void tdo_tl070wsh30_panel_del (struct tdo_tl070wsh30_panel *tdo_tl070wsh30) +{ +drm_panel_remove (&tdo_tl070wsh30->base); +}
This helper does not gain anything - call drm_panel_remove() direct.
Quoted 28 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +28
-0+ +static int tdo_tl070wsh30_panel_probe (struct mipi_dsi_device *dsi) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30; +int err; + + dsi->lanes =4 ; + dsi->format =MIPI_DSI_FMT_RGB888 ; + dsi->mode_flags =MIPI_DSI_MODE_VIDEO |MIPI_DSI_MODE_VIDEO_BURST |MIPI_DSI_MODE_LPM ; + + tdo_tl070wsh30 =devm_kzalloc (&dsi->dev,sizeof (*tdo_tl070wsh30), +GFP_KERNEL ); +if (!tdo_tl070wsh30) +return -ENOMEM ; + +mipi_dsi_set_drvdata (dsi, tdo_tl070wsh30); + tdo_tl070wsh30->link = dsi; + + err =tdo_tl070wsh30_panel_add (tdo_tl070wsh30); +if (err <0 ) +return err; + +return mipi_dsi_attach (dsi); +} + +static int tdo_tl070wsh30_panel_remove (struct mipi_dsi_device *dsi) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30 =mipi_dsi_get_drvdata (dsi);
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 225
Quoted 10 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +10
-0+int err; + + err =drm_panel_unprepare (&tdo_tl070wsh30->base); +if (err <0 ) +dev_err (&dsi->dev,"failed to unprepare panel: %d\n" , err); + + err =drm_panel_disable (&tdo_tl070wsh30->base); +if (err <0 ) +dev_err (&dsi->dev,"failed to disable panel: %d\n" , err); +
In most panel drivers we just ignore the return results here.
Quoted 5 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +5
-0+ err =mipi_dsi_detach (dsi); +if (err <0 ) +dev_err (&dsi->dev,"failed to detach from DSI host: %d\n" , err); + +tdo_tl070wsh30_panel_del (tdo_tl070wsh30);
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 240
Quoted 10 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +10
-0+ +return 0 ; +} + +static void tdo_tl070wsh30_panel_shutdown (struct mipi_dsi_device *dsi) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30 =mipi_dsi_get_drvdata (dsi); + +drm_panel_unprepare (&tdo_tl070wsh30->base); +drm_panel_disable (&tdo_tl070wsh30->base);
This is the wrong order. disable before unpreapre.
I am not sure what is right here - but I see some drivers that only have the disable() + unprepare() in their shutdown() method and then the remocal in their remove() function.
That makes sense with this split but I have not looked too deep into it.
Quoted 23 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +16
-0+} + +static struct mipi_dsi_driver tdo_tl070wsh30_panel_driver = { + .driver = { + .name ="panel-tdo-tl070wsh30" , + .of_match_table = tdo_tl070wsh30_of_match, + }, + .probe = tdo_tl070wsh30_panel_probe, + .remove = tdo_tl070wsh30_panel_remove, + .shutdown = tdo_tl070wsh30_panel_shutdown, +}; +module_mipi_dsi_driver (tdo_tl070wsh30_panel_driver); + +MODULE_AUTHOR ("Neil Armstrong <[email protected]>" ); +MODULE_DESCRIPTION ("TDO TL070WSH30 panel driver" ); +MODULE_LICENSE ("GPL v2" );Signature · 6 lines
2.22.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 3/3] drm: panel: add TDO tl070wsh30 panel driver
Hi,
Quoted 10 lines · Sam Ravnborg
Hi Neil.
Quoted 4 lines · Neil Armstrong
This adds support for the TDO TL070WSH30 TFT-LCD panel module. The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. It provides a MIPI DSI interface to the host, a built-in LED backlight and touch controller.
Despite a nicely written driver I noticed a few things that needs to be addressed.
Thanks for the review, indeed the remove/shutdown was wrong, and I aligned with panel-simple, which seems more logical.
Quoted 89 lines
Sam
Quoted 74 lines
Signed-off-by Neil Armstrong <[email protected]>--- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 256 +++++++++++++++++++ 3 files changed, 268 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.cdrivers/gpu/drm/panel/Kconfig +11
-0@@ -433,6 +433,17 @@ config DRM_PANEL_SONY_ACX565AKM Say Y here if you want to enable support for the Sony ACX565AKM 800x600 3.5" panel (found on the Nokia N900). +config DRM_PANEL_TDO_TL070WSH30 + tristate "TDO TL070WSH30 DSI panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for TDO TL070WSH30 TFT-LCD + panel module. The panel has a 1024×600 resolution and uses + 24 bit RGB per pixel. It provides a MIPI DSI interface to + the host, a built-in LED backlight and touch controller. + config DRM_PANEL_TPO_TD028TTEC1 tristate "Toppoly (TPO) TD028TTEC1 panel driver" depends on OF && SPIdrivers/gpu/drm/panel/Makefile +1
-0@@ -45,6 +45,7 @@ obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o obj-$(CONFIG_DRM_PANEL_SONY_ACX424AKP) += panel-sony-acx424akp.o obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o +obj-$(CONFIG_DRM_PANEL_TDO_TL070WSH30) += panel-tdo-tl070wsh30.o obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.odrivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +25
-0@@ -0,0 +1,256 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (C) 2020 BayLibre, SAS +* Author: Neil Armstrong <[email protected]> +*/ + +#include <linux/delay.h> +#include <linux/gpio/consumer.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/regulator/consumer.h> + +#include <video/mipi_display.h> + +#include <drm/drm_crtc.h> +#include <drm/drm_device.h> +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_modes.h> +#include <drm/drm_panel.h> + +struct tdo_tl070wsh30_panel { +struct drm_panel base; +struct mipi_dsi_device *link; + +struct regulator *supply;drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 35
Quoted 10 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +10
-0+struct gpio_desc *reset_gpio; + +bool prepared; +}; + +static inline +struct tdo_tl070wsh30_panel *to_tdo_tl070wsh30_panel (struct drm_panel *panel) +{ + return container_of(panel, struct tdo_tl070wsh30_panel, base); +}bikeshedding - but my preference is to order the functions:
Quoted 7 lines
prepare
enable
disable
unprepareAs this is the natural order they are used.
Feel free to ignore!
Ack, prepare before unprepare looks better !
Quoted 75 lines
Quoted 75 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +74
-0+ +static int tdo_tl070wsh30_panel_unprepare (struct drm_panel *panel) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30 =to_tdo_tl070wsh30_panel (panel); +int err; + +if (!tdo_tl070wsh30->prepared) +return 0 ; + + err =mipi_dsi_dcs_set_display_off (tdo_tl070wsh30->link); +if (err <0 ) +dev_err (panel->dev,"failed to set display off: %d\n" , err); + +usleep_range (10000 ,11000 ); + + err =mipi_dsi_dcs_enter_sleep_mode (tdo_tl070wsh30->link); +if (err <0 ) { +dev_err (panel->dev,"failed to enter sleep mode: %d\n" , err); +return err; + } + +usleep_range (10000 ,11000 ); + + tdo_tl070wsh30->prepared = false; + +return 0 ; +} + +static int tdo_tl070wsh30_panel_prepare (struct drm_panel *panel) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30 =to_tdo_tl070wsh30_panel (panel); +int err; + +if (tdo_tl070wsh30->prepared) +return 0 ; + + err =mipi_dsi_dcs_exit_sleep_mode (tdo_tl070wsh30->link); +if (err <0 ) { +dev_err (panel->dev,"failed to exit sleep mode: %d\n" , err); +return err; + } + +msleep (200 ); + + err =mipi_dsi_dcs_set_display_on (tdo_tl070wsh30->link); +if (err <0 ) { +dev_err (panel->dev,"failed to set display on: %d\n" , err); +return err; + } + +msleep (20 ); + + tdo_tl070wsh30->prepared = true; + +return 0 ; +} + +static const struct drm_display_mode default_mode = { + .clock =47250 , + .hdisplay =1024 , + .hsync_start =1024 +46 , + .hsync_end =1024 +46 +80 , + .htotal =1024 +46 +80 +100 , + .vdisplay =600 , + .vsync_start =600 +5 , + .vsync_end =600 +5 +5 , + .vtotal =600 +5 +5 +20 , + .flags =DRM_MODE_FLAG_PHSYNC |DRM_MODE_FLAG_PVSYNC , +}; + +static int tdo_tl070wsh30_panel_get_modes (struct drm_panel *panel, +struct drm_connector *connector) +{ +struct drm_display_mode *mode;
Quoted 8 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 114
Quoted 5 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +5
-0+ + mode =drm_mode_duplicate (connector->dev, &default_mode); +if (!mode) { +dev_err (panel->dev,"failed to add mode %ux%ux\n" , default_mode.hdisplay, + default_mode.vdisplay);Here we often print the refresh rate too.
If there is no need for the refresh rate than at least drop the extra 'x' at the end of the line.
I forgot to remove it after vrefresh removal, but I'll prefer adding back drm_mode_vrefresh() and the refresh.
Quoted 25 lines
Quoted 14 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +13
-0+return -ENOMEM ; + } + +drm_mode_set_name (mode); + +drm_mode_probed_add (connector, mode); + + connector->display_info.width_mm =154 ; + connector->display_info.height_mm =85 ; + connector->display_info.bpc =8 ; + +return 1 ; +}drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 137
Quoted 10 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +10
-0+ +static const struct drm_panel_funcs tdo_tl070wsh30_panel_funcs = { + .unprepare = tdo_tl070wsh30_panel_unprepare, + .prepare = tdo_tl070wsh30_panel_prepare, + .get_modes = tdo_tl070wsh30_panel_get_modes, +}; + +static const struct of_device_id tdo_tl070wsh30_of_match[] = { + { .compatible ="tdo,tl070wsh30" , }, + { }I often recommends
Quoted 3 lines
{ /* sentinel },but thats just to be consistent with what I see in other drivers.
Let it be consistent.
Quoted 41 lines
Quoted 41 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +37
-0+}; +MODULE_DEVICE_TABLE (of, tdo_tl070wsh30_of_match); + +static int tdo_tl070wsh30_panel_add (struct tdo_tl070wsh30_panel *tdo_tl070wsh30) +{ +struct device *dev = &tdo_tl070wsh30->link->dev; +int err; + + tdo_tl070wsh30->supply =devm_regulator_get (dev,"power" ); +if (IS_ERR (tdo_tl070wsh30->supply)) +return PTR_ERR (tdo_tl070wsh30->supply); + + tdo_tl070wsh30->reset_gpio =devm_gpiod_get (dev,"reset" , +GPIOD_OUT_LOW ); +if (IS_ERR (tdo_tl070wsh30->reset_gpio)) { + err =PTR_ERR (tdo_tl070wsh30->reset_gpio); +dev_dbg (dev,"failed to get reset gpio: %d\n" , err); +return err; + } + +drm_panel_init (&tdo_tl070wsh30->base, &tdo_tl070wsh30->link->dev, + &tdo_tl070wsh30_panel_funcs,DRM_MODE_CONNECTOR_DSI ); + + err =drm_panel_of_backlight (&tdo_tl070wsh30->base); +if (err) +return err; + + err =regulator_enable (tdo_tl070wsh30->supply); +if (err <0 ) +return err; + +usleep_range (10000 ,11000 ); + +gpiod_set_value_cansleep (tdo_tl070wsh30->reset_gpio,1 ); + +usleep_range (10000 ,11000 ); +
Quoted 8 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 178
Quoted 4 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +4
-0+gpiod_set_value_cansleep (tdo_tl070wsh30->reset_gpio,0 ); + +msleep (200 ); +It is the job of the prepare function to turn on the panel, and likewise the unprepare to turn off the panel. Please move the code above to the prepare function.
Moved
Quoted 12 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 187
Quoted 11 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +9
-0+drm_panel_add (&tdo_tl070wsh30->base); + +return 0 ; +} + +static void tdo_tl070wsh30_panel_del (struct tdo_tl070wsh30_panel *tdo_tl070wsh30) +{ +drm_panel_remove (&tdo_tl070wsh30->base); +}This helper does not gain anything - call
drm_panel_remove()direct.
Removed
Quoted 32 lines
Quoted 32 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +31
-0+ +static int tdo_tl070wsh30_panel_probe (struct mipi_dsi_device *dsi) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30; +int err; + + dsi->lanes =4 ; + dsi->format =MIPI_DSI_FMT_RGB888 ; + dsi->mode_flags =MIPI_DSI_MODE_VIDEO |MIPI_DSI_MODE_VIDEO_BURST |MIPI_DSI_MODE_LPM ; + + tdo_tl070wsh30 =devm_kzalloc (&dsi->dev,sizeof (*tdo_tl070wsh30), +GFP_KERNEL ); +if (!tdo_tl070wsh30) +return -ENOMEM ; + +mipi_dsi_set_drvdata (dsi, tdo_tl070wsh30); + tdo_tl070wsh30->link = dsi; + + err =tdo_tl070wsh30_panel_add (tdo_tl070wsh30); +if (err <0 ) +return err; + +return mipi_dsi_attach (dsi); +} + +static int tdo_tl070wsh30_panel_remove (struct mipi_dsi_device *dsi) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30 =mipi_dsi_get_drvdata (dsi); +int err; + + err =drm_panel_unprepare (&tdo_tl070wsh30->base);
Quoted 8 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 225
Quoted 7 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +7
-0+if (err <0 ) +dev_err (&dsi->dev,"failed to unprepare panel: %d\n" , err); + + err =drm_panel_disable (&tdo_tl070wsh30->base); +if (err <0 ) +dev_err (&dsi->dev,"failed to disable panel: %d\n" , err); +In most panel drivers we just ignore the return results here.
Ok
Quoted 19 lines
Quoted 6 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +5
-0+ err =mipi_dsi_detach (dsi); +if (err <0 ) +dev_err (&dsi->dev,"failed to detach from DSI host: %d\n" , err); + +tdo_tl070wsh30_panel_del (tdo_tl070wsh30);drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c line 240
Quoted 10 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +10
-0+ +return 0 ; +} + +static void tdo_tl070wsh30_panel_shutdown (struct mipi_dsi_device *dsi) +{ +struct tdo_tl070wsh30_panel *tdo_tl070wsh30 =mipi_dsi_get_drvdata (dsi); + +drm_panel_unprepare (&tdo_tl070wsh30->base); +drm_panel_disable (&tdo_tl070wsh30->base);This is the wrong order. disable before unpreapre.
Quoted 4 lines
I am not sure what is right here - but I see some drivers that only have the
disable()+unprepare()in theirshutdown()method and then the remocal in theirremove()function.
That makes sense with this split but I have not looked too deep into it.
No prob, I aligned with panel-simple here.
Quoted 20 lines
Quoted 20 lines
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c new file +16
-0+} + +static struct mipi_dsi_driver tdo_tl070wsh30_panel_driver = { + .driver = { + .name ="panel-tdo-tl070wsh30" , + .of_match_table = tdo_tl070wsh30_of_match, + }, + .probe = tdo_tl070wsh30_panel_probe, + .remove = tdo_tl070wsh30_panel_remove, + .shutdown = tdo_tl070wsh30_panel_shutdown, +}; +module_mipi_dsi_driver (tdo_tl070wsh30_panel_driver); + +MODULE_AUTHOR ("Neil Armstrong <[email protected]>" ); +MODULE_DESCRIPTION ("TDO TL070WSH30 panel driver" ); +MODULE_LICENSE ("GPL v2" );Signature · 1 line
2.22.0
Quoted 4 lines
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Thanks,
Neil
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel