Skip to contentSkip to conversation

arm64: dts: imx8mq-librem5: correct GPIO hog property

PATCH Applied Krzysztof Kozlowski 2 participants 9 messages Sep 20, 2020 – Oct 26, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/3 arm64: dts: imx8mq-librem5: correct GPIO hog property

Correct the name of property for GPIO specifier in GPIO hog.

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema

---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi +1 -1
index 56295dd2fa8f..e4dedcb58f76 100644
@@ -251,7 +251,7 @@
 
 	pmic-5v {
 		gpio-hog;
-		gpio = <&gpio1 1 GPIO_ACTIVE_HIGH>;
+		gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
 		input;
 	};
 };
Signature · 1 line
2.17.1
#1 lore raw

PATCH v3 2/3 arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema

dtschema expects GPIO hogs to end with 'hog' suffix.

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema

---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi +1 -1
index e4dedcb58f76..6cbcee2fb938 100644
@@ -249,7 +249,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pmic_5v>;
 
-	pmic-5v {
+	pmic-5v-hog {
 		gpio-hog;
 		gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
 		input;
Signature · 1 line
2.17.1
#6 lore raw

PATCH v3 3/3 ARM: dts: imx: align GPIO hog names with dtschema

In reply to Krzysztof Kozlowski

dtschema for GPIO controllers expects GPIO hogs to end with 'hog' suffix.

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema

---
 arch/arm/boot/dts/imx51-zii-rdu1.dts        | 2 +-
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi     | 8 ++++----
 arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/imx51-zii-rdu1.dts +1 -1
index e559ab0c3645..ec8ca3ac2c1c 100644
@@ -451,7 +451,7 @@
 			  "", "", "", "",
 			  "", "", "", "";
 
-	unused-sd3-wp-gpio {
+	unused-sd3-wp-hog {
 		/*
 		 * See pinctrl_esdhc1 below for more details on this
 		 */
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +4 -4
index 66b15748e287..c0a76202e16b 100644
@@ -330,28 +330,28 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_gpio3_hog>;
 
-	usb-emulation {
+	usb-emulation-hog {
 		gpio-hog;
 		gpios = <19 GPIO_ACTIVE_HIGH>;
 		output-low;
 		line-name = "usb-emulation";
 	};
 
-	usb-mode1 {
+	usb-mode1-hog {
 		gpio-hog;
 		gpios = <20 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "usb-mode1";
 	};
 
-	usb-pwr {
+	usb-pwr-hog {
 		gpio-hog;
 		gpios = <22 GPIO_ACTIVE_LOW>;
 		output-high;
 		line-name = "usb-pwr-ctrl-en-n";
 	};
 
-	usb-mode2 {
+	usb-mode2-hog {
 		gpio-hog;
 		gpios = <23 GPIO_ACTIVE_HIGH>;
 		output-high;
arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts +1 -1
index a0bbec57ddc7..3ec042bfccba 100644
@@ -110,7 +110,7 @@
 };
 
 &gpio5 {
-	emmc-usd-mux {
+	emmc-usd-mux-hog {
 		gpio-hog;
 		gpios = <1 GPIO_ACTIVE_LOW>;
 		output-high;
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema

In reply to Krzysztof Kozlowski
Quoted 3 lines · Krzysztof Kozlowski

dtschema expects GPIO hogs to end with 'hog' suffix.

Ping me after dtschema gets accepted.

Shawn

Quoted 25 lines

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema

---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi +1 -1
index e4dedcb58f76..6cbcee2fb938 100644
@@ -249,7 +249,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pmic_5v>;
 
-	pmic-5v {
+	pmic-5v-hog {
 		gpio-hog;
 		gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
 		input;
Signature · 1 line
2.17.1
#4 lore raw

Re: [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema

Quoted 6 lines · Krzysztof Kozlowski
Quoted 4 lines · Shawn Guo
Quoted 2 lines · Krzysztof Kozlowski

dtschema expects GPIO hogs to end with 'hog' suffix.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Ping me after dtschema gets accepted.

Hi Shawn,

Happened just now, in dt-schema repo:
https://github.com/devicetree-org/dt-schema/pull/47

The dtschema was accepted in September. Can you pick up this patch?

Best regards,
Krzysztof