Skip to contentSkip to conversation

drm/msm/dp: fix incorrect function prototype of dp_debug_get()

PATCH In review Abhinav Kumar 2 participants 2 messages Sep 26, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/msm/dp: fix incorrect function prototype of dp_debug_get()

Fix the incorrect function prototype for dp_debug_get() in the dp_debug module to address compilation warning. Also add prototype for msm_dp_debugfs_init() for fixing compilation issue with other defconfigs.

changes in v2:
- add prototype for msm_dp_debugfs_init()

Fixes f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/")
---
 drivers/gpu/drm/msm/dp/dp_debug.h | 2 +-
 drivers/gpu/drm/msm/msm_drv.h     | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/msm/dp/dp_debug.h +1 -1
index 377e166fd0ea..7eaedfbb149c 100644
@@ -60,7 +60,7 @@ void dp_debug_put(struct dp_debug *dp_debug);
 static inline
 struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
 		struct dp_usbpd *usbpd, struct dp_link *link,
-		struct drm_connector **connector)
+		struct drm_connector **connector, struct drm_minor *minor)
 {
 	return ERR_PTR(-EINVAL);
 }
drivers/gpu/drm/msm/msm_drv.h +5 -0
index 319327462b29..9f7849c4ece3 100644
@@ -435,6 +435,11 @@ static inline void msm_dp_irq_postinstall(struct msm_dp *dp_display)
 {
 }
 
+static inline void msm_dp_debugfs_init(struct msm_dp *dp_display,
+		struct drm_minor *minor)
+{
+}
+
 #endif
 
 void __init msm_mdp_register(void);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Reviewed-by on v2 1/1
#1 lore raw

Quoting Abhinav Kumar (2020-09-25 19:55:12)

Quoted 5 lines

Fix the incorrect function prototype for dp_debug_get() in the dp_debug module to address compilation warning. Also add prototype for msm_dp_debugfs_init() for fixing compilation issue with other defconfigs.

Quoted 7 lines

changes in v2:
- add prototype for msm_dp_debugfs_init()

Fixes f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/")

---