hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry
PATCH 1/1 hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault.
This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller.
--- hw/riscv/microchip_pfsoc.c | 6 ++++++ include/hw/riscv/microchip_pfsoc.h | 1 + 2 files changed, 7 insertions(+)
hw/riscv/microchip_pfsoc.c +6 -0
@@ -97,6 +97,7 @@ static const struct MemmapEntry { [MICROCHIP_PFSOC_GPIO2] = { 0x20122000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_CFG] = { 0x20200000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_DATA] = { 0x20220000, 0x20000 }, + [MICROCHIP_PFSOC_IOSCB_CTRL] = { 0x37020000, 0x1000 }, [MICROCHIP_PFSOC_IOSCB_CFG] = { 0x37080000, 0x1000 }, [MICROCHIP_PFSOC_DRAM] = { 0x80000000, 0x0 }, };
@@ -341,6 +342,11 @@ static void microchip_pfsoc_soc_realize(DeviceState *dev, Error **errp)create_unimplemented_device ("microchip.pfsoc.ioscb.cfg" , memmap[MICROCHIP_PFSOC_IOSCB_CFG ].base, memmap[MICROCHIP_PFSOC_IOSCB_CFG ].size); + +/* IOSCBCTRL */ +create_unimplemented_device ("microchip.pfsoc.ioscb.ctrl" , + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].base, + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].size); }static void microchip_pfsoc_soc_class_init (ObjectClass *oc,void *data)
include/hw/riscv/microchip_pfsoc.h +1 -0
@@ -95,6 +95,7 @@ enum {MICROCHIP_PFSOC_ENVM_CFG ,MICROCHIP_PFSOC_ENVM_DATA ,MICROCHIP_PFSOC_IOSCB_CFG , +MICROCHIP_PFSOC_IOSCB_CTRL , MICROCHIP_PFSOC_DRAM, };
Signature · 1 line
2.17.1
Quoted 18 lines · Ivan Griffin
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault.
This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller.
Signed-off-by Ivan Griffin <[email protected]>--- hw/riscv/microchip_pfsoc.c | 6 ++++++ include/hw/riscv/microchip_pfsoc.h | 1 + 2 files changed, 7 insertions(+)hw/riscv/microchip_pfsoc.c +0
-0
hw/riscv/microchip_pfsoc.c static const struct MemmapEntry { · line 100
Quoted 4 lines
hw/riscv/microchip_pfsoc.c +1
-0@@ -97,6 +97,7 @@ static const struct MemmapEntry { [MICROCHIP_PFSOC_GPIO2] = { 0x20122000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_CFG] = { 0x20200000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_DATA] = { 0x20220000, 0x20000 }, + [MICROCHIP_PFSOC_IOSCB_CTRL] = { 0x37020000, 0x1000 },
I don't see this in the UG0880 "User Guide PolarFire SoC FPGA Microprocessor Sub-System" memory map.
Where is this documented?
Alistair
Quoted 31 lines
hw/riscv/microchip_pfsoc.c +5
-0[MICROCHIP_PFSOC_IOSCB_CFG] = { 0x37080000, 0x1000 }, [MICROCHIP_PFSOC_DRAM] = { 0x80000000, 0x0 }, };@@ -341,6 +342,11 @@ static void microchip_pfsoc_soc_realize(DeviceState *dev, Error **errp)create_unimplemented_device ("microchip.pfsoc.ioscb.cfg" , memmap[MICROCHIP_PFSOC_IOSCB_CFG ].base, memmap[MICROCHIP_PFSOC_IOSCB_CFG ].size); + +/* IOSCBCTRL */ +create_unimplemented_device ("microchip.pfsoc.ioscb.ctrl" , + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].base, + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].size); }static void microchip_pfsoc_soc_class_init (ObjectClass *oc,void *data)include/hw/riscv/microchip_pfsoc.h +1
-1@@ -95,6 +95,7 @@ enum {MICROCHIP_PFSOC_ENVM_CFG ,MICROCHIP_PFSOC_ENVM_DATA ,MICROCHIP_PFSOC_IOSCB_CFG , +MICROCHIP_PFSOC_IOSCB_CTRL , MICROCHIP_PFSOC_DRAM, }; --2.17.1
I don't know why it isn't documented in that PDF (or in the register map), but if you check https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.h you'll see the following
```
typedef struct
{
volatile uint32_t SOFT_RESET;
volatile uint32_t VDETECTOR;
volatile uint32_t TVS_CONTROL;
volatile uint32_t TVS_TEMP_A;
volatile uint32_t TVS_TEMP_B;
volatile uint32_t TVS_TEMP_C;
volatile uint32_t TVS_VOLT_A;
volatile uint32_t TVS_VOLT_B;
volatile uint32_t TVS_VOLT_C;
volatile uint32_t TVS_OUTPUT0;
volatile uint32_t TVS_OUTPUT1;
volatile uint32_t TVS_TRIGGER;
volatile uint32_t TRIM_VDET1P05;
volatile uint32_t TRIM_VDET1P8;
volatile uint32_t TRIM_VDET2P5;
volatile uint32_t TRIM_TVS;
volatile uint32_t TRIM_GDET1P05;
volatile uint32_t RESERVED0;
volatile uint32_t RESERVED1;
volatile uint32_t RESERVED2;
volatile uint32_t SERVICES_CR;
volatile uint32_t SERVICES_SR;
volatile uint32_t USER_DETECTOR_SR;
volatile uint32_t USER_DETECTOR_CR;
volatile uint32_t MSS_SPI_CR;
} SCBCTRL_TypeDef;
#define MSS_SCBCTRL ((SCBCTRL_TypeDef*) (0x37020000UL))
/*2kB bytes long mailbox.*/
#define MSS_SCBMAILBOX ((uint32_t*) (0x37020800UL))
```And in https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.c you'll see MSS_SCB and MSS_SCBMAILBOX used in many places to interact with the FPGA system controller to perform various services.
Cheers,
Ivan
-----Original Message-----
From: Alistair Francis <[email protected]>
Sent: Friday 16 October 2020 17:08
To: Ivan Griffin <[email protected]>
Cc: Bin Meng <[email protected]>; QEMU Trivial <[email protected]>; open list:RISC-V <[email protected]>; [email protected] Developers <[email protected]>
Subject: Re: [PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry
Quoted 18 lines · Ivan Griffin
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault.
This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller.
Signed-off-by Ivan Griffin <[email protected]>--- hw/riscv/microchip_pfsoc.c | 6 ++++++ include/hw/riscv/microchip_pfsoc.h | 1 + 2 files changed, 7 insertions(+)hw/riscv/microchip_pfsoc.c +0
-0
hw/riscv/microchip_pfsoc.c static const struct MemmapEntry { · line 100
Quoted 4 lines
hw/riscv/microchip_pfsoc.c +1
-0@@ -97,6 +97,7 @@ static const struct MemmapEntry { [MICROCHIP_PFSOC_GPIO2] = { 0x20122000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_CFG] = { 0x20200000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_DATA] = { 0x20220000, 0x20000 }, + [MICROCHIP_PFSOC_IOSCB_CTRL] = { 0x37020000, 0x1000 },
I don't see this in the UG0880 "User Guide PolarFire SoC FPGA Microprocessor Sub-System" memory map.
Where is this documented?
Alistair
Quoted 32 lines
hw/riscv/microchip_pfsoc.c +5
-0[MICROCHIP_PFSOC_IOSCB_CFG] = { 0x37080000, 0x1000 }, [MICROCHIP_PFSOC_DRAM] = { 0x80000000, 0x0 }, };@@ -341,6 +342,11 @@ static void microchip_pfsoc_soc_realize(DeviceState *dev, Error **errp)create_unimplemented_device ("microchip.pfsoc.ioscb.cfg" , memmap[MICROCHIP_PFSOC_IOSCB_CFG ].base, memmap[MICROCHIP_PFSOC_IOSCB_CFG ].size); + +/* IOSCBCTRL */ +create_unimplemented_device ("microchip.pfsoc.ioscb.ctrl" , + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].base, + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].size); } static void microchip_pfsoc_soc_class_init(ObjectClass *oc, void*data) diff --git
a/include/hw/riscv/microchip_pfsoc.hb/include/hw/riscv/microchip_pfsoc.h
index8bfc7e1a85..3f1874b162100644include/hw/riscv/microchip_pfsoc.h +1
-1@@ -95,6 +95,7 @@ enum {MICROCHIP_PFSOC_ENVM_CFG ,MICROCHIP_PFSOC_ENVM_DATA ,MICROCHIP_PFSOC_IOSCB_CFG , +MICROCHIP_PFSOC_IOSCB_CTRL , MICROCHIP_PFSOC_DRAM, }; --2.17.1
Quoted 40 lines · Ivan Griffin
I don't know why it isn't documented in that PDF (or in the register map), but if you check https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.h you'll see the following
``` typedef struct { volatile uint32_t SOFT_RESET; volatile uint32_t VDETECTOR; volatile uint32_t TVS_CONTROL; volatile uint32_t TVS_TEMP_A; volatile uint32_t TVS_TEMP_B; volatile uint32_t TVS_TEMP_C; volatile uint32_t TVS_VOLT_A; volatile uint32_t TVS_VOLT_B; volatile uint32_t TVS_VOLT_C; volatile uint32_t TVS_OUTPUT0; volatile uint32_t TVS_OUTPUT1; volatile uint32_t TVS_TRIGGER; volatile uint32_t TRIM_VDET1P05; volatile uint32_t TRIM_VDET1P8; volatile uint32_t TRIM_VDET2P5; volatile uint32_t TRIM_TVS; volatile uint32_t TRIM_GDET1P05; volatile uint32_t RESERVED0; volatile uint32_t RESERVED1; volatile uint32_t RESERVED2; volatile uint32_t SERVICES_CR; volatile uint32_t SERVICES_SR; volatile uint32_t USER_DETECTOR_SR; volatile uint32_t USER_DETECTOR_CR; volatile uint32_t MSS_SPI_CR; } SCBCTRL_TypeDef; #define MSS_SCBCTRL ((SCBCTRL_TypeDef*) (0x37020000UL)) /*2kB bytes long mailbox.*/ #define MSS_SCBMAILBOX ((uint32_t*) (0x37020800UL)) ```
Quoted 1 line
And in https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.c you'll see
MSS_SCBandMSS_SCBMAILBOXused in many places to interact with the FPGA system controller to perform various services.
Ok, so the memory map exists, but not documented in the official documentation.
In this case it's fine to add. Can you add a comment though saying that it's not documented in the official documentation though? Otherwise it will confuse developers.
Alistair
Quoted 75 lines
Cheers,
Ivan-----Original Message-----
From: Alistair Francis <[email protected]>
Sent: Friday 16 October 2020 17:08
To: Ivan Griffin <[email protected]>
Cc: Bin Meng <[email protected]>; QEMU Trivial <[email protected]>; open list:RISC-V <[email protected]>; [email protected] Developers <[email protected]>
Subject: Re: [PATCH] hw/riscv:microchip_pfsoc: IOSCBCTRL memmap entryQuoted 18 lines · Ivan Griffin
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault.
This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller.
Signed-off-by Ivan Griffin <[email protected]>--- hw/riscv/microchip_pfsoc.c | 6 ++++++ include/hw/riscv/microchip_pfsoc.h | 1 + 2 files changed, 7 insertions(+)hw/riscv/microchip_pfsoc.c +0
-0hw/riscv/microchip_pfsoc.c static const struct MemmapEntry { · line 100
Quoted 4 lines
hw/riscv/microchip_pfsoc.c +1
-0@@ -97,6 +97,7 @@ static const struct MemmapEntry { [MICROCHIP_PFSOC_GPIO2] = { 0x20122000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_CFG] = { 0x20200000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_DATA] = { 0x20220000, 0x20000 }, + [MICROCHIP_PFSOC_IOSCB_CTRL] = { 0x37020000, 0x1000 },I don't see this in the UG0880 "User Guide PolarFire SoC FPGA Microprocessor Sub-System" memory map.
Where is this documented?
Alistair
Quoted 32 lines
hw/riscv/microchip_pfsoc.c +5
-0[MICROCHIP_PFSOC_IOSCB_CFG] = { 0x37080000, 0x1000 }, [MICROCHIP_PFSOC_DRAM] = { 0x80000000, 0x0 }, };@@ -341,6 +342,11 @@ static void microchip_pfsoc_soc_realize(DeviceState *dev, Error **errp)create_unimplemented_device ("microchip.pfsoc.ioscb.cfg" , memmap[MICROCHIP_PFSOC_IOSCB_CFG ].base, memmap[MICROCHIP_PFSOC_IOSCB_CFG ].size); + +/* IOSCBCTRL */ +create_unimplemented_device ("microchip.pfsoc.ioscb.ctrl" , + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].base, + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].size); } static void microchip_pfsoc_soc_class_init(ObjectClass *oc, void*data) diff --git
a/include/hw/riscv/microchip_pfsoc.hb/include/hw/riscv/microchip_pfsoc.h
index8bfc7e1a85..3f1874b162100644include/hw/riscv/microchip_pfsoc.h +1
-1@@ -95,6 +95,7 @@ enum {MICROCHIP_PFSOC_ENVM_CFG ,MICROCHIP_PFSOC_ENVM_DATA ,MICROCHIP_PFSOC_IOSCB_CFG , +MICROCHIP_PFSOC_IOSCB_CTRL , MICROCHIP_PFSOC_DRAM, }; --2.17.1
PATCH v2 1/1 hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault.
This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller.
--- hw/riscv/microchip_pfsoc.c | 10 ++++++++++ include/hw/riscv/microchip_pfsoc.h | 1 + 2 files changed, 11 insertions(+)
hw/riscv/microchip_pfsoc.c +10 -0
@@ -97,6 +97,7 @@ static const struct MemmapEntry { [MICROCHIP_PFSOC_GPIO2] = { 0x20122000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_CFG] = { 0x20200000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_DATA] = { 0x20220000, 0x20000 }, + [MICROCHIP_PFSOC_IOSCB_CTRL] = { 0x37020000, 0x1000 }, [MICROCHIP_PFSOC_IOSCB_CFG] = { 0x37080000, 0x1000 }, [MICROCHIP_PFSOC_DRAM] = { 0x80000000, 0x0 }, };
@@ -341,6 +342,15 @@ static void microchip_pfsoc_soc_realize(DeviceState *dev, Error **errp)create_unimplemented_device ("microchip.pfsoc.ioscb.cfg" , memmap[MICROCHIP_PFSOC_IOSCB_CFG ].base, memmap[MICROCHIP_PFSOC_IOSCB_CFG ].size); + +/* IOSCBCTRL +* +* These registers are not documented in the official documentation +* but used by the polarfire-soc-bare-meta-library code +*/ +create_unimplemented_device ("microchip.pfsoc.ioscb.ctrl" , + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].base, + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].size); }static void microchip_pfsoc_soc_class_init (ObjectClass *oc,void *data)
include/hw/riscv/microchip_pfsoc.h +1 -0
@@ -95,6 +95,7 @@ enum {MICROCHIP_PFSOC_ENVM_CFG ,MICROCHIP_PFSOC_ENVM_DATA ,MICROCHIP_PFSOC_IOSCB_CFG , +MICROCHIP_PFSOC_IOSCB_CTRL , MICROCHIP_PFSOC_DRAM, };
Signature · 1 line
2.17.1
Quoted 8 lines · Ivan Griffin
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault.
This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller.
Signed-off-by Ivan Griffin <[email protected]>
Alistair
Quoted 48 lines
--- hw/riscv/microchip_pfsoc.c | 10 ++++++++++ include/hw/riscv/microchip_pfsoc.h | 1 + 2 files changed, 11 insertions(+)hw/riscv/microchip_pfsoc.c +10
-0@@ -97,6 +97,7 @@ static const struct MemmapEntry { [MICROCHIP_PFSOC_GPIO2] = { 0x20122000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_CFG] = { 0x20200000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_DATA] = { 0x20220000, 0x20000 }, + [MICROCHIP_PFSOC_IOSCB_CTRL] = { 0x37020000, 0x1000 }, [MICROCHIP_PFSOC_IOSCB_CFG] = { 0x37080000, 0x1000 }, [MICROCHIP_PFSOC_DRAM] = { 0x80000000, 0x0 }, };@@ -341,6 +342,15 @@ static void microchip_pfsoc_soc_realize(DeviceState *dev, Error **errp)create_unimplemented_device ("microchip.pfsoc.ioscb.cfg" , memmap[MICROCHIP_PFSOC_IOSCB_CFG ].base, memmap[MICROCHIP_PFSOC_IOSCB_CFG ].size); + +/* IOSCBCTRL +* +* These registers are not documented in the official documentation +* but used by the polarfire-soc-bare-meta-library code +*/ +create_unimplemented_device ("microchip.pfsoc.ioscb.ctrl" , + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].base, + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].size); }static void microchip_pfsoc_soc_class_init (ObjectClass *oc,void *data)include/hw/riscv/microchip_pfsoc.h +1
-1@@ -95,6 +95,7 @@ enum {MICROCHIP_PFSOC_ENVM_CFG ,MICROCHIP_PFSOC_ENVM_DATA ,MICROCHIP_PFSOC_IOSCB_CFG , +MICROCHIP_PFSOC_IOSCB_CTRL , MICROCHIP_PFSOC_DRAM, }; --2.17.1
Hi Ivan,
Quoted 46 lines · Ivan Griffin
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault.
This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller.
Signed-off-by Ivan Griffin <[email protected]>--- hw/riscv/microchip_pfsoc.c | 10 ++++++++++ include/hw/riscv/microchip_pfsoc.h | 1 + 2 files changed, 11 insertions(+)hw/riscv/microchip_pfsoc.c +10
-0@@ -97,6 +97,7 @@ static const struct MemmapEntry { [MICROCHIP_PFSOC_GPIO2] = { 0x20122000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_CFG] = { 0x20200000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_DATA] = { 0x20220000, 0x20000 }, + [MICROCHIP_PFSOC_IOSCB_CTRL] = { 0x37020000, 0x1000 }, [MICROCHIP_PFSOC_IOSCB_CFG] = { 0x37080000, 0x1000 }, [MICROCHIP_PFSOC_DRAM] = { 0x80000000, 0x0 }, };@@ -341,6 +342,15 @@ static void microchip_pfsoc_soc_realize(DeviceState *dev, Error **errp)create_unimplemented_device ("microchip.pfsoc.ioscb.cfg" , memmap[MICROCHIP_PFSOC_IOSCB_CFG ].base, memmap[MICROCHIP_PFSOC_IOSCB_CFG ].size); + +/* IOSCBCTRL +* +* These registers are not documented in the official documentation +* but used by the polarfire-soc-bare-meta-library code +*/ +create_unimplemented_device ("microchip.pfsoc.ioscb.ctrl" , + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].base, + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].size); }static void microchip_pfsoc_soc_class_init (ObjectClass *oc,void *data)include/hw/riscv/microchip_pfsoc.h +0
-0
include/hw/riscv/microchip_pfsoc.h enum { · line 100
Quoted 6 lines
include/hw/riscv/microchip_pfsoc.h +1
-0@@ -95,6 +95,7 @@ enum {MICROCHIP_PFSOC_ENVM_CFG ,MICROCHIP_PFSOC_ENVM_DATA ,MICROCHIP_PFSOC_IOSCB_CFG , +MICROCHIP_PFSOC_IOSCB_CTRL , MICROCHIP_PFSOC_DRAM, };
Thank you for the patch!
I am currently adding the DDR controller modeling support to PolarFire SoC which will cover this memory map. With my patch series, your patch is no longer needed.
Regards,
Bin
Quoted 59 lines · Bin Meng
Hi Ivan,
Quoted 46 lines · Ivan Griffin
Adding the PolarFire SoC IOSCBCTRL memory region to prevent QEMU reporting a STORE/AMO Access Fault.
This region is used by the PolarFire SoC port of U-Boot to interact with the FPGA system controller.
Signed-off-by Ivan Griffin <[email protected]>--- hw/riscv/microchip_pfsoc.c | 10 ++++++++++ include/hw/riscv/microchip_pfsoc.h | 1 + 2 files changed, 11 insertions(+)hw/riscv/microchip_pfsoc.c +10
-0@@ -97,6 +97,7 @@ static const struct MemmapEntry { [MICROCHIP_PFSOC_GPIO2] = { 0x20122000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_CFG] = { 0x20200000, 0x1000 }, [MICROCHIP_PFSOC_ENVM_DATA] = { 0x20220000, 0x20000 }, + [MICROCHIP_PFSOC_IOSCB_CTRL] = { 0x37020000, 0x1000 }, [MICROCHIP_PFSOC_IOSCB_CFG] = { 0x37080000, 0x1000 }, [MICROCHIP_PFSOC_DRAM] = { 0x80000000, 0x0 }, };@@ -341,6 +342,15 @@ static void microchip_pfsoc_soc_realize(DeviceState *dev, Error **errp)create_unimplemented_device ("microchip.pfsoc.ioscb.cfg" , memmap[MICROCHIP_PFSOC_IOSCB_CFG ].base, memmap[MICROCHIP_PFSOC_IOSCB_CFG ].size); + +/* IOSCBCTRL +* +* These registers are not documented in the official documentation +* but used by the polarfire-soc-bare-meta-library code +*/ +create_unimplemented_device ("microchip.pfsoc.ioscb.ctrl" , + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].base, + memmap[MICROCHIP_PFSOC_IOSCB_CTRL ].size); }static void microchip_pfsoc_soc_class_init (ObjectClass *oc,void *data)include/hw/riscv/microchip_pfsoc.h +0
-0include/hw/riscv/microchip_pfsoc.h enum { · line 100
Quoted 6 lines
include/hw/riscv/microchip_pfsoc.h +1
-0@@ -95,6 +95,7 @@ enum {MICROCHIP_PFSOC_ENVM_CFG ,MICROCHIP_PFSOC_ENVM_DATA ,MICROCHIP_PFSOC_IOSCB_CFG , +MICROCHIP_PFSOC_IOSCB_CTRL , MICROCHIP_PFSOC_DRAM, };Thank you for the patch!
Quoted 3 lines
I am currently adding the DDR controller modeling support to PolarFire SoC which will cover this memory map. With my patch series, your patch is no longer needed.
I forgot to apply this, and Bin just sent his series. So if it's ok with you Ivan I'm just going to apply Bin's series instead. Sorry about that.
Alistair
Quoted 3 lines
Regards,
Bin
Hi Ivan,
Quoted 40 lines · Ivan Griffin
I don't know why it isn't documented in that PDF (or in the register map), but if you check https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.h you'll see the following
``` typedef struct { volatile uint32_t SOFT_RESET; volatile uint32_t VDETECTOR; volatile uint32_t TVS_CONTROL; volatile uint32_t TVS_TEMP_A; volatile uint32_t TVS_TEMP_B; volatile uint32_t TVS_TEMP_C; volatile uint32_t TVS_VOLT_A; volatile uint32_t TVS_VOLT_B; volatile uint32_t TVS_VOLT_C; volatile uint32_t TVS_OUTPUT0; volatile uint32_t TVS_OUTPUT1; volatile uint32_t TVS_TRIGGER; volatile uint32_t TRIM_VDET1P05; volatile uint32_t TRIM_VDET1P8; volatile uint32_t TRIM_VDET2P5; volatile uint32_t TRIM_TVS; volatile uint32_t TRIM_GDET1P05; volatile uint32_t RESERVED0; volatile uint32_t RESERVED1; volatile uint32_t RESERVED2; volatile uint32_t SERVICES_CR; volatile uint32_t SERVICES_SR; volatile uint32_t USER_DETECTOR_SR; volatile uint32_t USER_DETECTOR_CR; volatile uint32_t MSS_SPI_CR; } SCBCTRL_TypeDef; #define MSS_SCBCTRL ((SCBCTRL_TypeDef*) (0x37020000UL)) /*2kB bytes long mailbox.*/ #define MSS_SCBMAILBOX ((uint32_t*) (0x37020800UL)) ```
Quoted 1 line
And in https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.c you'll see
MSS_SCBandMSS_SCBMAILBOXused in many places to interact with the FPGA system controller to perform various services.
It's actually documented, but not in the PDF file. I also spent some time locating the doc when I do the DDR controller modeling work.
See Register Map/PF_SoC_RegMap_V1_1/MPFS250T/pfsoc_control_scb.htm in
https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
Regards,
Bin
Hi Bin,
Well spotted with the register map. I grepped it for 0x37020000 and didn't find it, but it seems the address (incorrectly) is 0x07020000 in the documentation.
Thanks,
Ivan.
________________________________
From: Bin Meng <[email protected]>
Sent: Monday 19 October 2020 03:05
To: Ivan Griffin <[email protected]>
Cc: Alistair Francis <[email protected]>; QEMU Trivial <[email protected]>; Bin Meng <[email protected]>; open list:RISC-V <[email protected]>; [email protected] Developers <[email protected]>
Subject: Re: [PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry
Hi Ivan,
Quoted 40 lines · Ivan Griffin
I don't know why it isn't documented in that PDF (or in the register map), but if you check https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.h you'll see the following
``` typedef struct { volatile uint32_t SOFT_RESET; volatile uint32_t VDETECTOR; volatile uint32_t TVS_CONTROL; volatile uint32_t TVS_TEMP_A; volatile uint32_t TVS_TEMP_B; volatile uint32_t TVS_TEMP_C; volatile uint32_t TVS_VOLT_A; volatile uint32_t TVS_VOLT_B; volatile uint32_t TVS_VOLT_C; volatile uint32_t TVS_OUTPUT0; volatile uint32_t TVS_OUTPUT1; volatile uint32_t TVS_TRIGGER; volatile uint32_t TRIM_VDET1P05; volatile uint32_t TRIM_VDET1P8; volatile uint32_t TRIM_VDET2P5; volatile uint32_t TRIM_TVS; volatile uint32_t TRIM_GDET1P05; volatile uint32_t RESERVED0; volatile uint32_t RESERVED1; volatile uint32_t RESERVED2; volatile uint32_t SERVICES_CR; volatile uint32_t SERVICES_SR; volatile uint32_t USER_DETECTOR_SR; volatile uint32_t USER_DETECTOR_CR; volatile uint32_t MSS_SPI_CR; } SCBCTRL_TypeDef; #define MSS_SCBCTRL ((SCBCTRL_TypeDef*) (0x37020000UL)) /*2kB bytes long mailbox.*/ #define MSS_SCBMAILBOX ((uint32_t*) (0x37020800UL)) ```
Quoted 1 line
And in https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.c you'll see
MSS_SCBandMSS_SCBMAILBOXused in many places to interact with the FPGA system controller to perform various services.
It's actually documented, but not in the PDF file. I also spent some time locating the doc when I do the DDR controller modeling work.
See Register Map/PF_SoC_RegMap_V1_1/MPFS250T/pfsoc_control_scb.htm in
https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
Regards,
Bin
Hi Ivan,
Quoted 5 lines · Ivan Griffin
Hi Bin,
Well spotted with the register map. I grepped it for
0x37020000and didn't find it, but it seems the address (incorrectly) is0x07020000in the documentation.
I believe the documented offset 0x07020000 is the offset into the IOSCB block, not the final one that is mapped into the system memory.
Regards,
Bin
Quoted 57 lines
________________________________
From: Bin Meng <[email protected]>
Sent: Monday 19 October 2020 03:05
To: Ivan Griffin <[email protected]>
Cc: Alistair Francis <[email protected]>; QEMU Trivial <[email protected]>; Bin Meng <[email protected]>; open list:RISC-V <[email protected]>; [email protected] Developers <[email protected]>
Subject: Re: [PATCH] hw/riscv:microchip_pfsoc: IOSCBCTRL memmap entryHi Ivan,
Quoted 40 lines · Ivan Griffin
I don't know why it isn't documented in that PDF (or in the register map), but if you check https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.h you'll see the following
``` typedef struct { volatile uint32_t SOFT_RESET; volatile uint32_t VDETECTOR; volatile uint32_t TVS_CONTROL; volatile uint32_t TVS_TEMP_A; volatile uint32_t TVS_TEMP_B; volatile uint32_t TVS_TEMP_C; volatile uint32_t TVS_VOLT_A; volatile uint32_t TVS_VOLT_B; volatile uint32_t TVS_VOLT_C; volatile uint32_t TVS_OUTPUT0; volatile uint32_t TVS_OUTPUT1; volatile uint32_t TVS_TRIGGER; volatile uint32_t TRIM_VDET1P05; volatile uint32_t TRIM_VDET1P8; volatile uint32_t TRIM_VDET2P5; volatile uint32_t TRIM_TVS; volatile uint32_t TRIM_GDET1P05; volatile uint32_t RESERVED0; volatile uint32_t RESERVED1; volatile uint32_t RESERVED2; volatile uint32_t SERVICES_CR; volatile uint32_t SERVICES_SR; volatile uint32_t USER_DETECTOR_SR; volatile uint32_t USER_DETECTOR_CR; volatile uint32_t MSS_SPI_CR; } SCBCTRL_TypeDef; #define MSS_SCBCTRL ((SCBCTRL_TypeDef*) (0x37020000UL)) /*2kB bytes long mailbox.*/ #define MSS_SCBMAILBOX ((uint32_t*) (0x37020800UL)) ```Quoted 1 line
And in https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.c you'll see
MSS_SCBandMSS_SCBMAILBOXused in many places to interact with the FPGA system controller to perform various services.It's actually documented, but not in the PDF file. I also spent some time locating the doc when I do the DDR controller modeling work.
See Register Map/PF_SoC_RegMap_V1_1/MPFS250T/pfsoc_control_scb.htm in
https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
Yes, it could be.
But the "Physical Address" column, in my mind, should be the 0x37020000 address. At least when I check other peripherals, their physical address values in the register map HTML corresponds to the source code.
Cheers,
Ivan.
________________________________
From: Bin Meng <[email protected]>
Sent: Monday 19 October 2020 09:38
To: Ivan Griffin <[email protected]>
Cc: Alistair Francis <[email protected]>; QEMU Trivial <[email protected]>; open list:RISC-V <[email protected]>; [email protected] Developers <[email protected]>
Subject: Re: [PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry
Hi Ivan,
Quoted 5 lines · Ivan Griffin
Hi Bin,
Well spotted with the register map. I grepped it for
0x37020000and didn't find it, but it seems the address (incorrectly) is0x07020000in the documentation.
I believe the documented offset 0x07020000 is the offset into the IOSCB block, not the final one that is mapped into the system memory.
Regards,
Bin
Quoted 57 lines
________________________________
From: Bin Meng <[email protected]>
Sent: Monday 19 October 2020 03:05
To: Ivan Griffin <[email protected]>
Cc: Alistair Francis <[email protected]>; QEMU Trivial <[email protected]>; Bin Meng <[email protected]>; open list:RISC-V <[email protected]>; [email protected] Developers <[email protected]>
Subject: Re: [PATCH] hw/riscv:microchip_pfsoc: IOSCBCTRL memmap entryHi Ivan,
Quoted 40 lines · Ivan Griffin
I don't know why it isn't documented in that PDF (or in the register map), but if you check https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.h you'll see the following
``` typedef struct { volatile uint32_t SOFT_RESET; volatile uint32_t VDETECTOR; volatile uint32_t TVS_CONTROL; volatile uint32_t TVS_TEMP_A; volatile uint32_t TVS_TEMP_B; volatile uint32_t TVS_TEMP_C; volatile uint32_t TVS_VOLT_A; volatile uint32_t TVS_VOLT_B; volatile uint32_t TVS_VOLT_C; volatile uint32_t TVS_OUTPUT0; volatile uint32_t TVS_OUTPUT1; volatile uint32_t TVS_TRIGGER; volatile uint32_t TRIM_VDET1P05; volatile uint32_t TRIM_VDET1P8; volatile uint32_t TRIM_VDET2P5; volatile uint32_t TRIM_TVS; volatile uint32_t TRIM_GDET1P05; volatile uint32_t RESERVED0; volatile uint32_t RESERVED1; volatile uint32_t RESERVED2; volatile uint32_t SERVICES_CR; volatile uint32_t SERVICES_SR; volatile uint32_t USER_DETECTOR_SR; volatile uint32_t USER_DETECTOR_CR; volatile uint32_t MSS_SPI_CR; } SCBCTRL_TypeDef; #define MSS_SCBCTRL ((SCBCTRL_TypeDef*) (0x37020000UL)) /*2kB bytes long mailbox.*/ #define MSS_SCBMAILBOX ((uint32_t*) (0x37020800UL)) ```Quoted 1 line
And in https://github.com/polarfire-soc/polarfire-soc-bare-metal-library/blob/master/src/platform/drivers/mss_sys_services/mss_sys_services.c you'll see
MSS_SCBandMSS_SCBMAILBOXused in many places to interact with the FPGA system controller to perform various services.It's actually documented, but not in the PDF file. I also spent some time locating the doc when I do the DDR controller modeling work.
See Register Map/PF_SoC_RegMap_V1_1/MPFS250T/pfsoc_control_scb.htm in
https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map