Skip to contentSkip to conversation

test: log: Actually test enable/disable output

PATCH New Sean Anderson 2 participants 2 messages Oct 17, 2020 – Oct 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test: log: Actually test enable/disable output

Strings are truth-y in python, so ``assert 'anything'`` will always evaluate to True. Fix the test so that it actually checks the output.

Fixes 3d03ab6361 ("log: Add a way to enable/disable a log device")

---

 test/py/tests/test_log.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
test/py/tests/test_log.py +2 -2
index 275f9382d2..e8b2b17145 100644
@@ -95,9 +95,9 @@ def test_log(u_boot_console):
     def test11():
         """Test use of log_device_set_enable()"""
         lines = run_test(11)
-        assert 'log_test() default'
+        assert 'log_test() default' == next(lines)
         # disabled should not be displayed
-        assert 'log_test() enabled'
+        assert 'log_test() enabled' == next(lines)
 
     # TODO(sjg at chromium.org): Consider structuring this as separate tests
     cons = u_boot_console
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 test: log: Actually test enable/disable output

Quoted 10 lines · Sean Anderson

Strings are truth-y in python, so ``assert 'anything'`` will always evaluate to True. Fix the test so that it actually checks the output.

Fixes 3d03ab6361 ("log: Add a way to enable/disable a log device")

---

 test/py/tests/test_log.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)