Skip to contentSkip to conversation

drm/tegra: sor: Don't warn on probe deferral

PATCH Superseded Jon Hunter 1 participant 2 messages Nov 3, 2020

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/1 drm/tegra: sor: Don't warn on probe deferral

Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users.

---
 drivers/gpu/drm/tegra/sor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tegra/sor.c +1 -1
index e88a17c2937f..5a232055b8cc 100644
@@ -3765,7 +3765,7 @@ static int tegra_sor_probe(struct platform_device *pdev)
 
 	err = tegra_output_probe(&sor->output);
 	if (err < 0) {
-		dev_err(&pdev->dev, "failed to probe output: %d\n", err);
+		dev_err_probe(&pdev->dev, "failed to probe output: %d\n", err);
 		return err;
 	}
 
Signature · 1 line
2.25.1
author maintainer
#1 lore raw
Quoted 14 lines · Jon Hunter

Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users.

---
 drivers/gpu/drm/tegra/sor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tegra/sor.c +0 -0
index e88a17c2937f..5a232055b8cc 100644

drivers/gpu/drm/tegra/sor.c static int tegra_sor_probe(struct platform_device *pdev) · line 3770

Quoted 7 lines
drivers/gpu/drm/tegra/sor.c +1 -1
@@ -3765,7 +3765,7 @@ static int tegra_sor_probe(struct platform_device *pdev)
 
 	err = tegra_output_probe(&sor->output);
 	if (err < 0) {
-		dev_err(&pdev->dev, "failed to probe output: %d\n", err);
+		dev_err_probe(&pdev->dev, "failed to probe output: %d\n", err);
 		return err;
 	}

Sorry this is not right. I will fix this in V2.

Jon

Signature · 1 line
nvpublic