drm/tegra: sor: Don't warn on probe deferral
Jon Hunter
maintainerPATCH v2 1/1 drm/tegra: sor: Don't warn on probe deferral
Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users.
---
Changes since V1:
- This time, I actually validated it!
drivers/gpu/drm/tegra/sor.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/tegra/sor.c +3 -4
@@ -3764,10 +3764,9 @@ static int tegra_sor_probe(struct platform_device *pdev)return err; err =tegra_output_probe (&sor->output); -if (err <0 ) { -dev_err (&pdev->dev,"failed to probe output: %d\n" , err); -return err; - } +if (err <0 ) +return dev_err_probe (&pdev->dev, err, +"failed to probe output: %d\n" , err);if (sor->ops && sor->ops->probe) { err = sor->ops->probe (sor);
Signature · 1 line
2.25.1
04.11.2020 12:23, Jon Hunter пишет:
Quoted 18 lines
Deferred probe is an expected return value for
tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users.Signed-off-by Jon Hunter <[email protected]>---
Changes since V1:
- This time, I actually validated it!drivers/gpu/drm/tegra/sor.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/tegra/sor.c +0
-0
drivers/gpu/drm/tegra/sor.c static int tegra_sor_probe(struct platform_device *pdev) · line 3769
Quoted 10 lines
drivers/gpu/drm/tegra/sor.c +3
-4@@ -3764,10 +3764,9 @@ static int tegra_sor_probe(struct platform_device *pdev)return err; err =tegra_output_probe (&sor->output); -if (err <0 ) { -dev_err (&pdev->dev,"failed to probe output: %d\n" , err); -return err; - } +if (err <0 ) +return dev_err_probe (&pdev->dev, err, +"failed to probe output: %d\n" , err);
Hello Jon,
There is no need to duplicate the error code in the message [1]. Perhaps worth making a v3? :)
[1]
https://elixir.bootlin.com/linux/v5.10-rc2/source/drivers/base/core.c#L4240
Jon Hunter
maintainerQuoted 32 lines · Dmitry Osipenko
04.11.2020 12:23, Jon Hunter пишет:
Quoted 18 lines
Deferred probe is an expected return value for
tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users.Signed-off-by Jon Hunter <[email protected]>---
Changes since V1:
- This time, I actually validated it!drivers/gpu/drm/tegra/sor.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/tegra/sor.c +0
-0drivers/gpu/drm/tegra/sor.c static int tegra_sor_probe(struct platform_device *pdev) · line 3769
Quoted 10 lines
drivers/gpu/drm/tegra/sor.c +3
-4@@ -3764,10 +3764,9 @@ static int tegra_sor_probe(struct platform_device *pdev)return err; err =tegra_output_probe (&sor->output); -if (err <0 ) { -dev_err (&pdev->dev,"failed to probe output: %d\n" , err); -return err; - } +if (err <0 ) +return dev_err_probe (&pdev->dev, err, +"failed to probe output: %d\n" , err);Hello Jon,
Quoted 2 lines
There is no need to duplicate the error code in the message [1]. Perhaps worth making a v3? :)
Indeed! Thanks for catching. Trying to do to many things at the same time. I should have learned by now!
Jon
Signature · 1 line
nvpublic