Skip to contentSkip to conversation

arm64: dts: ti: Cleanup mix of "okay" and "disabled" usage

PATCH Superseded Nishanth Menon 5 participants 15 messages Nov 12, 2020

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
author maintainer
#4 lore raw

PATCH v2 2/5 arm64: dts: ti: k3-j721e*: Cleanup disabled nodes at SoC dtsi level

In reply to Nishanth Menon

The device tree standard states that when the status property is not present under a node, the okay value is assumed. There are many reasons for doing the same, the number of strings in the device tree, default power management functionality, etc. are a few of the reasons.

In general, after a few rounds of discussions [1] there are few options one could take when dealing with SoC dtsi and board dts

a. SoC dtsi provide nodes as a super-set default (aka enabled) state and
to prevent messy board files, when more boards are added per SoC, we optimize and disable commonly un-used nodes in board-common.dtsi
b. SoC dtsi disables all hardware dependent nodes by default and board
dts files enable nodes based on a need basis.
c. Subjectively pick and choose which nodes we will disable by default
in SoC dtsi and over the years we can optimize things and change default state depending on the need.

While there are pros and cons on each of these approaches, the right thing to do will be to stick with device tree default standards and work within those established rules. So, we choose to go with option (a).

Lets cleanup defaults of j721e SoC dtsi before this gets more harder to cleanup later on and new SoCs are added.

The only functional difference between the dtb generated is status='okay' is no longer necessary for mcasp10 and depends on the default state.

NOTE: There is a known risk of omission that new board dts developers might miss reviewing both the board schematics in addition to all the DT nodes of the SoC when setting appropriate nodes status to disable or reserved in the board dts. This can expose issues in drivers that may not anticipate an incomplete node (example: missing appropriate board properties) being in an "okay" state. These cases are considered bugs and need to be fixed in the drivers as and when identified.

[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/

Fixes 1c4d35265fb2 ("arm64: dts: ti: k3-j721e-main: Add McASP nodes")
Fixes 76921f15acc0 ("arm64: dts: ti: k3-j721e-main: Add DSS node")
Cc Jyri Sarha <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc Peter Ujfalusi <[email protected]>
Cc Tony Lindgren <[email protected]>

---
Changes since v1:
- commit message update

V1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 .../dts/ti/k3-j721e-common-proc-board.dts     | 48 ++++++++++++++++++-
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 26 ----------
 2 files changed, 47 insertions(+), 27 deletions(-)
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +47 -1
index 52e121155563..9416528caa8a 100644
@@ -540,6 +540,46 @@ &dss {
 				 <&k3_clks 152 18>;	/* PLL23_HSDIV0 */
 };
 
+&mcasp0 {
+	status = "disabled";
+};
+
+&mcasp1 {
+	status = "disabled";
+};
+
+&mcasp2 {
+	status = "disabled";
+};
+
+&mcasp3 {
+	status = "disabled";
+};
+
+&mcasp4 {
+	status = "disabled";
+};
+
+&mcasp5 {
+	status = "disabled";
+};
+
+&mcasp6 {
+	status = "disabled";
+};
+
+&mcasp7 {
+	status = "disabled";
+};
+
+&mcasp8 {
+	status = "disabled";
+};
+
+&mcasp9 {
+	status = "disabled";
+};
+
 &mcasp10 {
 	#sound-dai-cells = <0>;
 
@@ -556,8 +596,10 @@ &mcasp10 {
 	>;
 	tx-num-evt = <0>;
 	rx-num-evt = <0>;
+};
 
-	status = "okay";
+&mcasp11 {
+	status = "disabled";
 };
 
 &serdes0 {
@@ -639,3 +681,7 @@ &pcie3_rc {
 &pcie3_ep {
 	status = "disabled";
 };
+
+&dss {
+	status = "disabled";
+};
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +0 -26
index e2a96b2c423c..b54332d6fdc5 100644
@@ -1327,8 +1327,6 @@ dss: dss@04a00000 {
 				  "common_s1",
 				  "common_s2";
 
-		status = "disabled";
-
 		dss_ports: ports {
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -1350,8 +1348,6 @@ mcasp0: mcasp@2b00000 {
 		clocks = <&k3_clks 174 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 174 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp1: mcasp@2b10000 {
@@ -1369,8 +1365,6 @@ mcasp1: mcasp@2b10000 {
 		clocks = <&k3_clks 175 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 175 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp2: mcasp@2b20000 {
@@ -1388,8 +1382,6 @@ mcasp2: mcasp@2b20000 {
 		clocks = <&k3_clks 176 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 176 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp3: mcasp@2b30000 {
@@ -1407,8 +1399,6 @@ mcasp3: mcasp@2b30000 {
 		clocks = <&k3_clks 177 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 177 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp4: mcasp@2b40000 {
@@ -1426,8 +1416,6 @@ mcasp4: mcasp@2b40000 {
 		clocks = <&k3_clks 178 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 178 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp5: mcasp@2b50000 {
@@ -1445,8 +1433,6 @@ mcasp5: mcasp@2b50000 {
 		clocks = <&k3_clks 179 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 179 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp6: mcasp@2b60000 {
@@ -1464,8 +1450,6 @@ mcasp6: mcasp@2b60000 {
 		clocks = <&k3_clks 180 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 180 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp7: mcasp@2b70000 {
@@ -1483,8 +1467,6 @@ mcasp7: mcasp@2b70000 {
 		clocks = <&k3_clks 181 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 181 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp8: mcasp@2b80000 {
@@ -1502,8 +1484,6 @@ mcasp8: mcasp@2b80000 {
 		clocks = <&k3_clks 182 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 182 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp9: mcasp@2b90000 {
@@ -1521,8 +1501,6 @@ mcasp9: mcasp@2b90000 {
 		clocks = <&k3_clks 183 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 183 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp10: mcasp@2ba0000 {
@@ -1540,8 +1518,6 @@ mcasp10: mcasp@2ba0000 {
 		clocks = <&k3_clks 184 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 184 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp11: mcasp@2bb0000 {
@@ -1559,8 +1535,6 @@ mcasp11: mcasp@2bb0000 {
 		clocks = <&k3_clks 185 1>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 185 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	watchdog0: watchdog@2200000 {
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#9 lore raw

PATCH v2 4/5 arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to "okay" for USB

In reply to Nishanth Menon

The default state of a device tree node is "okay". There is no specific use of explicitly adding status = "okay" in the board dts.

Fixes 7e7e7dd51d06 ("arm64: dts: ti: k3-am654-base-board: enable USB1")
Cc Roger Quadros <[email protected]>

---
Changes since v1:
- no change.

v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 8 --------
 1 file changed, 8 deletions(-)
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +0 -8
index 199c4d4e7539..744efcbb4f7f 100644
@@ -325,14 +325,6 @@ &sdhci1 {
 	disable-wp;
 };
 
-&dwc3_1 {
-	status = "okay";
-};
-
-&usb1_phy {
-	status = "okay";
-};
-
 &usb1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&usb1_pins_default>;
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#1 lore raw

PATCH v2 1/5 arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi level

In reply to Nishanth Menon

The device tree standard states that when the status property is not present under a node, the okay value is assumed. There are many reasons for doing the same, the number of strings in the device tree, default power management functionality, etc. are a few of the reasons.

In general, after a few rounds of discussions [1] there are few options one could take when dealing with SoC dtsi and board dts

a. SoC dtsi provide nodes as a super-set default (aka enabled) state and
to prevent messy board files, when more boards are added per SoC, we optimize and disable commonly un-used nodes in board-common.dtsi
b. SoC dtsi disables all hardware dependent nodes by default and board
dts files enable nodes based on a need basis.
c. Subjectively pick and choose which nodes we will disable by default
in SoC dtsi and over the years we can optimize things and change default state depending on the need.

While there are pros and cons on each of these approaches, the right thing to do will be to stick with device tree default standards and work within those established rules. So, we choose to go with option (a).

Lets cleanup defaults of am654 SoC dtsi before this gets more harder to cleanup later on and new SoCs are added.

The dtb generated is identical with the patch and it is just cleanup to ensure we have a clean usage model

NOTE: There is a known risk of omission that new board dts developers might miss reviewing both the board schematics in addition to all the DT nodes of the SoC when setting appropriate nodes status to disable or reserved in the board dts. This can expose issues in drivers that may not anticipate an incomplete node (example: missing appropriate board properties) being in an "okay" state. These cases are considered bugs and need to be fixed in the drivers as and when identified.

[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/

Fixes 9bcb631e9953 ("arm64: dts: ti: k3-am654-main: Add McASP nodes")
Fixes fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node")
Cc Jyri Sarha <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc Peter Ujfalusi <[email protected]>
Cc Tony Lindgren <[email protected]>

---

Changes since v1:
- commit message update

V1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi       |  8 --------
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 16 ++++++++++++++++
 2 files changed, 16 insertions(+), 8 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +0 -8
index 533525229a8d..21e50021dd83 100644
@@ -770,8 +770,6 @@ mcasp0: mcasp@2b00000 {
 		clocks = <&k3_clks 104 0>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 104 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp1: mcasp@2b10000 {
@@ -789,8 +787,6 @@ mcasp1: mcasp@2b10000 {
 		clocks = <&k3_clks 105 0>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 105 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	mcasp2: mcasp@2b20000 {
@@ -808,8 +804,6 @@ mcasp2: mcasp@2b20000 {
 		clocks = <&k3_clks 106 0>;
 		clock-names = "fck";
 		power-domains = <&k3_pds 106 TI_SCI_PD_EXCLUSIVE>;
-
-		status = "disabled";
 	};
 
 	cal: cal@6f03000 {
@@ -865,8 +859,6 @@ dss: dss@04a00000 {
 
 		interrupts = <GIC_SPI 166 IRQ_TYPE_EDGE_RISING>;
 
-		status = "disabled";
-
 		dss_ports: ports {
 			#address-cells = <1>;
 			#size-cells = <0>;
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +16 -0
index d12dd89f3405..199c4d4e7539 100644
@@ -486,3 +486,19 @@ &cpsw_port1 {
 	phy-mode = "rgmii-rxid";
 	phy-handle = <&phy0>;
 };
+
+&mcasp0 {
+	status = "disabled";
+};
+
+&mcasp1 {
+	status = "disabled";
+};
+
+&mcasp2 {
+	status = "disabled";
+};
+
+&dss {
+	status = "disabled";
+};
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#6 lore raw

PATCH v2 3/5 arm64: dts: ti: am65/j721e: Fix up un-necessary status set to "okay" for crypto

In reply to Nishanth Menon

The default state of a device tree node is "okay". There is no specific use of explicitly adding status = "okay" in the SoC dtsi.

Fixes 8ebcaaae8017 ("arm64: dts: ti: k3-j721e-main: Add crypto accelerator node")
Fixes b366b2409c97 ("arm64: dts: ti: k3-am6: Add crypto accelarator node")
Cc Keerthy <[email protected]>

---
Changes since V1:
- No change.

V1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi  | 1 -
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 2 --
 2 files changed, 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +0 -1
index 21e50021dd83..2bd66a9e4b1d 100644
@@ -119,7 +119,6 @@ crypto: crypto@4e00000 {
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges = <0x0 0x04e00000 0x00 0x04e00000 0x0 0x30000>;
-		status = "okay";
 
 		dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
 				<&main_udmap 0x4001>;
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +0 -2
index b54332d6fdc5..9747c387385b 100644
@@ -345,8 +345,6 @@ main_crypto: crypto@4e00000 {
 		#size-cells = <2>;
 		ranges = <0x0 0x04e00000 0x00 0x04e00000 0x0 0x30000>;
 
-		status = "okay";
-
 		dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
 				<&main_udmap 0x4001>;
 		dma-names = "tx", "rx1", "rx2";
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Nishanth Menon

author maintainer
#0 lore raw

v2 cover arm64: dts: ti: Cleanup mix of "okay" and "disabled" usage

Hi,

Changes since v1[1]:
- Picked up Reviews from Tomi
- Added patch #5 for moving uart used by firmware to 'reserved' state (thanks Peter for pointing it out)
- Updated commit message of #1, #2 to add information about the limitation as well (thanks Peter for your inputs).

This is hopefully a conclusion of the thread we had (online[2] and offline). There are few options one could take when dealing with SoC dtsi and board dts

a. SoC dtsi provide nodes as a super-set default (aka enabled) state and
to prevent messy board files, when more boards are added per SoC, we optimize and disable commonly un-used nodes in board-common.dtsi
b. SoC dtsi disables all hardware dependent nodes by default and board
dts files enable nodes based on a need basis.
c. Subjectively pick and choose which nodes we will disable by default
in SoC dtsi and over the years we can optimize things and change default state depending on the need.

While there are pros and cons on each of these approaches, the right thing to do will be to stick with device tree default standards and work within those established rules. So, we choose to go with option (a).

NOTE: There is a known risk of "omission" that new board dts developers might miss reviewing both the board schematics in addition to all the dt nodes of the SoC when setting appropriate nodes status to "disable" or "reserved" in the board dts. This can expose issues in drivers which may not anticipate an incomplete node(example: missing appropriate board properties) being in "okay" state. These cases are considered as bugs and need to be fixed in the drivers as and when identified.

The dtb changes are limited to be functionaly equivalent similar to what was published with v1.

dtb-> dts decompiled
a) As of v5.10-rc1:
am654: https://pastebin.ubuntu.com/p/G4P5vghpV3/
j721e: https://pastebin.ubuntu.com/p/HWXmTwD6m8/
j7200: https://pastebin.ubuntu.com/p/SsG6JtPzR9/

b) with this series applied:
am654: https://pastebin.ubuntu.com/p/pGdpbPQvyd/
j721e: https://pastebin.ubuntu.com/p/PWcNMdtj5J/
j7200: https://pastebin.ubuntu.com/p/NFxpNtyNr9/

Boot test logs(base v5.10-rc1):
am654: https://pastebin.ubuntu.com/p/pNngXcWy23/
j721e: https://pastebin.ubuntu.com/p/xjbXkHb7Gv/
j7200: https://pastebin.ubuntu.com/p/dn7MgfJJ2j/

Nishanth Menon (5):
arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi level
arm64: dts: ti: k3-j721e*: Cleanup disabled nodes at SoC dtsi level
arm64: dts: ti: am65/j721e: Fix up un-necessary status set to "okay"
for crypto
arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to
"okay" for USB
arm64: dts: ti: am65/j721e/j7200: Mark firmware used uart as
"reserved"

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      |  9 ----
 .../arm64/boot/dts/ti/k3-am654-base-board.dts | 26 ++++++----
 .../dts/ti/k3-j7200-common-proc-board.dts     |  4 +-
 .../dts/ti/k3-j721e-common-proc-board.dts     | 50 ++++++++++++++++++-
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 28 -----------
 5 files changed, 67 insertions(+), 50 deletions(-)

[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/
[2] https://lore.kernel.org/linux-arm-kernel/[email protected]/

Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#12 lore raw

PATCH v2 5/5 arm64: dts: ti: am65/j721e/j7200: Mark firmware used uart as "reserved"

Follow the device tree standards that states to set the status="reserved" if an device is operational, but used by a non-linux firmware in the system.

---
- New patch introduced with V2 based on feedback on v1

 arch/arm64/boot/dts/ti/k3-am654-base-board.dts        | 2 +-
 arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 4 ++--
 arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +1 -1
index 744efcbb4f7f..b5dba13556f8 100644
@@ -211,7 +211,7 @@ AM65X_IOPAD(0x0010, PIN_INPUT, 0) /* (D21) ECAP0_IN_APWM_OUT */
 
 &wkup_uart0 {
 	/* Wakeup UART is used by System firmware */
-	status = "disabled";
+	status = "reserved";
 };
 
 &main_uart0 {
arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +2 -2
index ef03e7636b66..1d08434229c7 100644
@@ -79,7 +79,7 @@ J721E_IOPAD(0x120, PIN_OUTPUT, 0) /* (T4) USB0_DRVVBUS */
 
 &wkup_uart0 {
 	/* Wakeup UART is used by System firmware */
-	status = "disabled";
+	status = "reserved";
 };
 
 &main_uart0 {
@@ -89,7 +89,7 @@ &main_uart0 {
 
 &main_uart2 {
 	/* MAIN UART 2 is used by R5F firmware */
-	status = "disabled";
+	status = "reserved";
 };
 
 &main_uart3 {
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +1 -1
index 9416528caa8a..5754892f8501 100644
@@ -221,7 +221,7 @@ J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_MDIO0_MDIO */
 
 &wkup_uart0 {
 	/* Wakeup UART is used by System firmware */
-	status = "disabled";
+	status = "reserved";
 };
 
 &main_uart0 {
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by on v2 4/5
#10 lore raw

Re: [PATCH V2 4/5] arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to "okay" for USB

In reply to Nishanth Menon
Quoted 6 lines · Nishanth Menon

The default state of a device tree node is "okay". There is no specific use of explicitly adding status = "okay" in the board dts.

Fixes 7e7e7dd51d06 ("arm64: dts: ti: k3-am654-base-board: enable USB1")
Cc Roger Quadros <[email protected]>

cheers,
-roger

Quoted 29 lines

---
Changes since v1:
- no change.

v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

  arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 8 --------
  1 file changed, 8 deletions(-)
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +0 -8
index 199c4d4e7539..744efcbb4f7f 100644
@@ -325,14 +325,6 @@ &sdhci1 {
  	disable-wp;
  };
 
-&dwc3_1 {
-	status = "okay";
-};
-
-&usb1_phy {
-	status = "okay";
-};
-
  &usb1 {
  	pinctrl-names = "default";
  	pinctrl-0 = <&usb1_pins_default>;
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Acked-by on v2 3/5
#7 lore raw

Re: [PATCH V2 3/5] arm64: dts: ti: am65/j721e: Fix up un-necessary status set to "okay" for crypto

In reply to Nishanth Menon
Quoted 7 lines · Nishanth Menon

The default state of a device tree node is "okay". There is no specific use of explicitly adding status = "okay" in the SoC dtsi.

Fixes 8ebcaaae8017 ("arm64: dts: ti: k3-j721e-main: Add crypto accelerator node")
Fixes b366b2409c97 ("arm64: dts: ti: k3-am6: Add crypto accelarator node")
Cc Keerthy <[email protected]>
Quoted 28 lines

---
Changes since V1:
- No change.

V1: https://lore.kernel.org/linux-arm-kernel/[email protected]/

  arch/arm64/boot/dts/ti/k3-am65-main.dtsi  | 1 -
  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 2 --
  2 files changed, 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +0 -1
index 21e50021dd83..2bd66a9e4b1d 100644
@@ -119,7 +119,6 @@ crypto: crypto@4e00000 {
  		#address-cells = <2>;
  		#size-cells = <2>;
  		ranges = <0x0 0x04e00000 0x00 0x04e00000 0x0 0x30000>;
-		status = "okay";
 
  		dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
  				<&main_udmap 0x4001>;
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +0 -0
index b54332d6fdc5..9747c387385b 100644

arch/arm64/boot/dts/ti/k3-j721e-main.dtsi main_crypto: crypto@4e00000 { · line 350

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +0 -2
@@ -345,8 +345,6 @@ main_crypto: crypto@4e00000 {
  		#size-cells = <2>;
  		ranges = <0x0 0x04e00000 0x00 0x04e00000 0x0 0x30000>;
 
-		status = "okay";
-
  		dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
  				<&main_udmap 0x4001>;
  		dma-names = "tx", "rx1", "rx2";

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Reviewed-by on v2 1/5
#2 lore raw

Re: [PATCH V2 1/5] arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi level

In reply to Nishanth Menon
Quoted 10 lines · Nishanth Menon

While there are pros and cons on each of these approaches, the right thing to do will be to stick with device tree default standards and work within those established rules. So, we choose to go with option (a).

Lets cleanup defaults of am654 SoC dtsi before this gets more harder to cleanup later on and new SoCs are added.

The dtb generated is identical with the patch and it is just cleanup to ensure we have a clean usage model

Thanks this looks good to me:

Reviewed-by on v2 1/5
#3 lore raw

Re: [PATCH V2 1/5] arm64: dts: ti: k3-am65*: Cleanup disabled nodes at SoC dtsi level

In reply to Nishanth Menon
Quoted 5 lines · Nishanth Menon

The device tree standard states that when the status property is not present under a node, the okay value is assumed. There are many reasons for doing the same, the number of strings in the device tree, default power management functionality, etc. are a few of the reasons.

Reviewed-by on v2 2/5
#5 lore raw

Re: [PATCH V2 2/5] arm64: dts: ti: k3-j721e*: Cleanup disabled nodes at SoC dtsi level

In reply to Nishanth Menon
Quoted 5 lines · Nishanth Menon

The device tree standard states that when the status property is not present under a node, the okay value is assumed. There are many reasons for doing the same, the number of strings in the device tree, default power management functionality, etc. are a few of the reasons.

Reviewed-by
#8 lore raw

Re: [PATCH V2 3/5] arm64: dts: ti: am65/j721e: Fix up un-necessary status set to "okay" for crypto

In reply to Tero Kristo
Quoted 10 lines · Tero Kristo
Quoted 7 lines · Nishanth Menon

The default state of a device tree node is "okay". There is no specific use of explicitly adding status = "okay" in the SoC dtsi.

Fixes 8ebcaaae8017 ("arm64: dts: ti: k3-j721e-main: Add crypto accelerator node")
Fixes b366b2409c97 ("arm64: dts: ti: k3-am6: Add crypto accelarator node")
Cc Keerthy <[email protected]>
Reviewed-by
#11 lore raw

Re: [PATCH V2 4/5] arm64: dts: ti: k3-am654-base-board: Fix up un-necessary status set to "okay" for USB

In reply to Roger Quadros
Quoted 9 lines · Roger Quadros
Quoted 6 lines · Nishanth Menon

The default state of a device tree node is "okay". There is no specific use of explicitly adding status = "okay" in the board dts.

Fixes 7e7e7dd51d06 ("arm64: dts: ti: k3-am654-base-board: enable USB1")
Cc Roger Quadros <[email protected]>
Reviewed-by on v2 5/5
#13 lore raw

Re: [PATCH V2 5/5] arm64: dts: ti: am65/j721e/j7200: Mark firmware used uart as "reserved"

In reply to Nishanth Menon
Quoted 3 lines · Nishanth Menon

Follow the device tree standards that states to set the status="reserved" if an device is operational, but used by a non-linux firmware in the system.

Makes sense to me: