Add support for Rpi4b + Cirrus Lochnagar2 and CS47L15
Subsystems (8)
Richard Fitzgerald
maintainerPATCH v3 4/6 ASoC: madera: Allow codecs to be selected from kernel config
In reply to Richard FitzgeraldThe codec Kconfig options were hidden and intended to be selected by the machine driver that requires them. But that means having either a dedicated machine driver or building all codecs.
This patch makes the Kconfig options visible so that they can be selected independently of the machine driver, allowing the codec to be used with simple-card and other machine drivers that are not hardcoded to use a fixed set of codecs.
--- sound/soc/codecs/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
sound/soc/codecs/Kconfig +5 -5
@@ -658,23 +658,23 @@ config SND_SOC_CS4349 depends on I2C config SND_SOC_CS47L15 - tristate + tristate "Cirrus Logic CS47L15 CODEC" config SND_SOC_CS47L24 tristate depends on MFD_CS47L24 config SND_SOC_CS47L35 - tristate + tristate "Cirrus Logic CS47L35 CODEC" config SND_SOC_CS47L85 - tristate + tristate "Cirrus Logic CS47L85 CODEC" config SND_SOC_CS47L90 - tristate + tristate "Cirrus Logic CS47L90 CODEC" config SND_SOC_CS47L92 - tristate + tristate "Cirrus Logic CS47L92 CODEC" # Cirrus Logic Quad-Channel ADC config SND_SOC_CS53L30
Signature · 1 line
2.20.1
Richard Fitzgerald
maintainerv3 cover Add support for Rpi4b + Cirrus Lochnagar2 and CS47L15
This set of patches provides support for using the Raspberry Pi 4b with a Cirrus Logic Lochnagar 2 audio development platform plus Cirrus Logic CS47L15 codec.
Patches are needed to audio-graph-card to enable support for setting the component sysclks and plls. These are not specific to CS47L15 - several Cirrus and non-Cirrus codecs also require component clock setup, typically for larger codecs with multiple internal clocking options and clock domains.
The codec sysclks and plls cannot be placed under the clock framework because they are typically I2C/SPI/Soundwire-connected peripherals and access to the registers would cause a nested get of the bus clock. The clock framework does not support this and it would result in a deadlock.
Richard Fitzgerald (6):
of: base: Add of_count_phandle_with_fixed_args()
ASoC: audio-graph-card: Add plls and sysclks DT bindings
ASoC: audio-graph-card: Support setting component plls and sysclks
ASoC: madera: Allow codecs to be selected from kernel config
ASoC: madera: Export clock config defines to dt-bindings
ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15
.../bindings/sound/audio-graph-card.txt | 72 ++++++ MAINTAINERS | 1 + arch/arm/boot/dts/Makefile | 1 + ...bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dts | 186 ++++++++++++++ .../dts/bcm2711-rpi4b-cirrus-lochnagar.dtsi | 201 +++++++++++++++ drivers/of/base.c | 73 ++++-- include/dt-bindings/sound/madera.h | 60 +++++ include/linux/of.h | 9 + include/sound/simple_card_utils.h | 25 ++ sound/soc/codecs/Kconfig | 10 +- sound/soc/codecs/madera.h | 56 +---- sound/soc/generic/audio-graph-card.c | 16 +- sound/soc/generic/simple-card-utils.c | 236 ++++++++++++++++++ 13 files changed, 861 insertions(+), 85 deletions(-) create mode 100644 arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dts create mode 100644 arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar.dtsi
Signature · 1 line
2.20.1
Richard Fitzgerald
maintainerPATCH v3 1/6 of: base: Add of_count_phandle_with_fixed_args()
Add an equivalent of of_count_phandle_with_args() for fixed argument sets, to pair with of_parse_phandle_with_fixed_args().
The existing of_count_phandle_with_args() is modified to be a private function that handles both cases and the public functions are trivial wrappers round that.
--- drivers/of/base.c | 73 +++++++++++++++++++++++++++++++--------------- include/linux/of.h | 9 ++++++ 2 files changed, 59 insertions(+), 23 deletions(-)
drivers/of/base.c +50 -23
@@ -1720,34 +1720,22 @@ int of_parse_phandle_with_fixed_args(const struct device_node *np, }EXPORT_SYMBOL (of_parse_phandle_with_fixed_args); -/** -* of_count_phandle_with_args() - Find the number of phandles references in a property -* @np: pointer to a device tree node containing a list -* @list_name: property name that contains a list -* @cells_name: property name that specifies phandles' arguments count -* -* Returns the number of phandle + argument tuples within a property. It -* is a typical pattern to encode a list of phandle and variable -* arguments into a single property. The number of arguments is encoded -* by a property in the phandle-target node. For example, a gpios -* property would contain a list of GPIO specifies consisting of a -* phandle and 1 or more arguments. The number of arguments are -* determined by the #gpio-cells property in the node pointed to by the -* phandle. -*/ -int of_count_phandle_with_args (const struct device_node *np,const char *list_name, -const char *cells_name) +static int __of_count_phandle_with_args (const struct device_node *np, +const char *list_name, +const char *cells_name, +int cells_count) {struct of_phandle_iterator it;int rc, cur_index =0 ;/* -* If cells_name is NULL we assume a cell count of 0. This makes -* counting the phandles trivial as each 32bit word in the list is a -* phandle and no arguments are to consider. So we don't iterate through -* the list but just use the length to determine the phandle count. +* If cells_count < 0 and cells_name is NULL we assume a cell count +* of 0. A zero cell count makes counting the phandles trivial as each +* 32bit word in the list is a phandle and no arguments are to consider. +* So we don't iterate through the list but just use the length to +* determine the phandle count. */ -if (!cells_name) { +if ((cells_count <0 && !cells_name) || cells_count ==0 ) {const __be32 *list;int size;
@@ -1758,7 +1746,7 @@ int of_count_phandle_with_args(const struct device_node *np, const char *list_nareturn size /sizeof (*list); } - rc =of_phandle_iterator_init (&it, np, list_name, cells_name,-1 ); + rc =of_phandle_iterator_init (&it, np, list_name, cells_name, cells_count);if (rc)return rc;
@@ -1770,8 +1758,47 @@ int of_count_phandle_with_args(const struct device_node *np, const char *list_nareturn cur_index; } + +/** +* of_count_phandle_with_args() - Find the number of phandles references in a property +* @np: pointer to a device tree node containing a list +* @list_name: property name that contains a list +* @cells_name: property name that specifies phandles' arguments count +* +* Returns the number of phandle + argument tuples within a property. It +* is a typical pattern to encode a list of phandle and variable +* arguments into a single property. The number of arguments is encoded +* by a property in the phandle-target node. For example, a gpios +* property would contain a list of GPIO specifies consisting of a +* phandle and 1 or more arguments. The number of arguments are +* determined by the #gpio-cells property in the node pointed to by the +* phandle. +*/ +int of_count_phandle_with_args (const struct device_node *np,const char *list_name, +const char *cells_name) +{ +return __of_count_phandle_with_args (np, list_name, cells_name,-1 ); +}EXPORT_SYMBOL (of_count_phandle_with_args); +/** +* of_count_phandle_with_fixed_args() - Find the number of phandles references in a property +* @np: pointer to a device tree node containing a list +* @list_name: property name that contains a list +* @cell_count: number of argument cells following the phandle +* +* Returns the number of phandle + argument tuples within a property. It +* is a typical pattern to encode a list of phandle and variable +* arguments into a single property. +*/ +int of_count_phandle_with_fixed_args (const struct device_node *np, +const char *list_name, +int cells_count) +{ +return __of_count_phandle_with_args (np, list_name,NULL , cells_count); +} +EXPORT_SYMBOL (of_count_phandle_with_fixed_args); +/** * __of_add_property - Add a property to a node without lock operations */
include/linux/of.h +9 -0
@@ -377,6 +377,8 @@ extern int of_parse_phandle_with_fixed_args(const struct device_node *np, struct of_phandle_args *out_args);extern int of_count_phandle_with_args (const struct device_node *np,const char *list_name,const char *cells_name); +extern int of_count_phandle_with_fixed_args (const struct device_node *np, +const char *list_name,int cells_count);/* phandle iterator functions */ extern int of_phandle_iterator_init(struct of_phandle_iterator *it,
@@ -886,6 +888,13 @@ static inline int of_count_phandle_with_args(struct device_node *np,return -ENOSYS ; } +static inline int of_count_phandle_with_fixed_args (const struct device_node *np, +const char *list_name, +int cells_count) +{ +return -ENOSYS ; +} + static inline int of_phandle_iterator_init(struct of_phandle_iterator *it, const struct device_node *np, const char *list_name,
Signature · 1 line
2.20.1
Richard Fitzgerald
maintainerPATCH v3 2/6 ASoC: audio-graph-card: Add plls and sysclks DT bindings
In reply to Richard FitzgeraldThe audio-graph-card driver has bindings for configuring the clocking for DAIs within a component, but is missing bindings for setting up the PLLs and sysclks of the component.
This patch adds the two new bindings 'plls' and 'sysclks' so that the audio-graph-driver can fully configure the component clocking.
--- .../bindings/sound/audio-graph-card.txt | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+)
Documentation/devicetree/bindings/sound/audio-graph-card.txt +72 -0
@@ -32,6 +32,40 @@ Required properties: Optional properties: - pa-gpios: GPIO used to control external amplifier. +- plls: A list of component pll settings. There are 4 cells per PLL setting: + - phandle to the node of the codec or cpu component, + - component PLL id, + - component clock source id, + - frequency (in Hz) of the PLL output clock. + + The PLL id and clock source id are specific to the particular component + so see the relevant component driver for the ids. Typically the + clock source id indicates the pin the source clock is connected to. + + The same phandle can appear in multiple entries so that several plls + can be set in the same component. + +- plls-clocks: A list of clock names giving the source clock for each setting + in the plls property. + +- sysclks: A list of component sysclk settings. There are 4 cells per sysclk + setting: + - phandle to the node of the codec or cpu component, + - component sysclk id, + - component clock source id, + - direction of the clock: 0 if the clock is an input to the component, + 1 if it is an output. + + The sysclk id and clock source id are specific to the particular + component so see the relevant component driver for the ids. Typically + the clock source id indicates the pin the source clock is connected to. + + The same phandle can appear in multiple entries so that several sysclks + can be set in the same component. + +- sysclks-clocks: A list of clock names giving the source clock for each setting + in the sysclks property. + ----------------------- Example: Single DAI case -----------------------
@@ -335,3 +369,41 @@ Example: Multi DAI with DPCM }; }; }; + +----------------------- +Example: Set component sysclks and PLLs +----------------------- + + sound { + compatible = "audio-graph-card"; + + clocks = <&audioclk>, <&pll1>; + clock-names = "audioclk", "pll1"; + + plls = <&cs47l15 MADERA_FLL1_REFCLK MADERA_FLL_SRC_MCLK1 98304000>; + plls-clocks = "audioclk"; + + sysclks = <&cs47l15 MADERA_CLK_SYSCLK_1 MADERA_CLK_SRC_FLL1 0>; + sysclks-clocks = "pll1"; + + dais = <&cpu_i2s_port>; + + pll1: pll1 { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <98304000>; + }; + }; + + cs47l15: codec@0 { + ... + ports { + #address-cells = <1>; + #size-cells = <0>; + cs47l15_aif1_port: port@0 { + reg = <0>; + cs47l15_aif1: endpoint { + remote-endpoint = <&cpu_i2s_endpoint>; + }; + }; + };
Signature · 1 line
2.20.1
Richard Fitzgerald
maintainerPATCH v3 5/6 ASoC: madera: Export clock config defines to dt-bindings
In reply to Richard FitzgeraldMove the defines for clock/fll IDs and sources into the dt-bindings header so that they can be used by machine driver dts files.
--- include/dt-bindings/sound/madera.h | 60 ++++++++++++++++++++++++++++++ sound/soc/codecs/madera.h | 56 +--------------------------- 2 files changed, 61 insertions(+), 55 deletions(-)
include/dt-bindings/sound/madera.h +60 -0
@@ -22,4 +22,64 @@#define CS47L35_DMIC_REF_MICBIAS2A 2#define CS47L35_DMIC_REF_MICBIAS2B 3 +/* FLL IDs */ +#define MADERA_FLL1_REFCLK 1 +#define MADERA_FLL2_REFCLK 2 +#define MADERA_FLL3_REFCLK 3 +#define MADERA_FLLAO_REFCLK 4 +#define MADERA_FLL1_SYNCCLK 5 +#define MADERA_FLL2_SYNCCLK 6 +#define MADERA_FLL3_SYNCCLK 7 +#define MADERA_FLLAO_SYNCCLK 8 + +/* FLL input source pin IDs */ +#define MADERA_FLL_SRC_NONE -1 +#define MADERA_FLL_SRC_MCLK1 0 +#define MADERA_FLL_SRC_MCLK2 1 +#define MADERA_FLL_SRC_MCLK3 2 +#define MADERA_FLL_SRC_SLIMCLK 3 +#define MADERA_FLL_SRC_FLL1 4 +#define MADERA_FLL_SRC_FLL2 5 +#define MADERA_FLL_SRC_AIF1BCLK 8 +#define MADERA_FLL_SRC_AIF2BCLK 9 +#define MADERA_FLL_SRC_AIF3BCLK 10 +#define MADERA_FLL_SRC_AIF4BCLK 11 +#define MADERA_FLL_SRC_AIF1LRCLK 12 +#define MADERA_FLL_SRC_AIF2LRCLK 13 +#define MADERA_FLL_SRC_AIF3LRCLK 14 +#define MADERA_FLL_SRC_AIF4LRCLK 15 + +/* SYSCLK IDs */ +#define MADERA_CLK_SYSCLK_1 1 +#define MADERA_CLK_ASYNCCLK_1 2 +#define MADERA_CLK_OPCLK 3 +#define MADERA_CLK_ASYNC_OPCLK 4 +#define MADERA_CLK_SYSCLK_2 5 +#define MADERA_CLK_SYSCLK_3 6 +#define MADERA_CLK_ASYNCCLK_2 7 +#define MADERA_CLK_DSPCLK 8 +#define MADERA_CLK_OUTCLK 9 + +/* SYSCLK source IDs */ +#define MADERA_CLK_SRC_MCLK1 0x0 +#define MADERA_CLK_SRC_MCLK2 0x1 +#define MADERA_CLK_SRC_MCLK3 0x2 +#define MADERA_CLK_SRC_FLL1 0x4 +#define MADERA_CLK_SRC_FLL2 0x5 +#define MADERA_CLK_SRC_FLL3 0x6 +#define MADERA_CLK_SRC_FLLAO_HI 0x7 +#define MADERA_CLK_SRC_FLL1_DIV6 0x7 +#define MADERA_CLK_SRC_AIF1BCLK 0x8 +#define MADERA_CLK_SRC_AIF2BCLK 0x9 +#define MADERA_CLK_SRC_AIF3BCLK 0xA +#define MADERA_CLK_SRC_AIF4BCLK 0xB +#define MADERA_CLK_SRC_FLLAO 0xF + +/* OPCLK source IDs */ +#define MADERA_OUTCLK_SYSCLK 0 +#define MADERA_OUTCLK_ASYNCCLK 1 +#define MADERA_OUTCLK_MCLK1 4 +#define MADERA_OUTCLK_MCLK2 5 +#define MADERA_OUTCLK_MCLK3 6 +#endif
sound/soc/codecs/madera.h +1 -55
68 lines not on this page · raw message
Signature · 1 line
2.20.1
Richard Fitzgerald
maintainerPATCH v3 3/6 ASoC: audio-graph-card: Support setting component plls and sysclks
In reply to Richard FitzgeraldSome codecs need plls and/or sysclks to be configured using the snd_soc_component_set_[sysclk|pll] functions. These drivers cannot necessarily be converted to use the clock framework. If the codec is on a I2C/SPI bus, a nested clk_get would be needed to enable the bus clock. But the clock framework does not support nested operations and this would deadlock.
This patch adds new dt properties that list phandles of components with the pll/sysclk settings to be applied. Multiple settings can be given for the same phandle to allow for components with multiple clocks and plls. The plls and sysclks are enabled when the card bias level moves to STANDBY and disabled when it moves to OFF.
The implementation does not attempt to handle specifying complex clock ordering interdependencies between components. The plls and sysclks are applied to a component as it is passed to the card set_bias_level/ set_bias_level_post callbacks. It follows from this that the order components are configured is the order that they are passed to those callbacks.
--- include/sound/simple_card_utils.h | 25 +++ sound/soc/generic/audio-graph-card.c | 16 +- sound/soc/generic/simple-card-utils.c | 236 ++++++++++++++++++++++++++ 3 files changed, 275 insertions(+), 2 deletions(-)
include/sound/simple_card_utils.h +25 -0
@@ -38,6 +38,16 @@ struct asoc_simple_jack {struct snd_soc_jack_gpio gpio; }; +struct asoc_simple_sysclk_pll { +struct device_node *node; +struct clk *clk; +int id; +int source; +unsigned int freq_out; +int dir; +bool enabled; +}; + struct asoc_simple_priv { struct snd_soc_card snd_card; struct simple_dai_props {
@@ -56,6 +66,11 @@ struct asoc_simple_priv {struct asoc_simple_dai *dais;struct snd_soc_codec_conf *codec_conf;struct gpio_desc *pa_gpio; + +struct asoc_simple_sysclk_pll *sysclks; +int num_sysclks; +struct asoc_simple_sysclk_pll *plls; +int num_plls; };#define simple_priv_to_card (priv) (&(priv)->snd_card)#define simple_priv_to_props (priv, i) ((priv)->dai_props + (i))
@@ -94,6 +109,14 @@ void asoc_simple_shutdown(struct snd_pcm_substream *substream);int asoc_simple_hw_params (struct snd_pcm_substream *substream,struct snd_pcm_hw_params *params);int asoc_simple_dai_init (struct snd_soc_pcm_runtime *rtd); + +int asoc_simple_set_bias_level (struct snd_soc_card *card, +struct snd_soc_dapm_context *dapm, +enum snd_soc_bias_level level); +int asoc_simple_set_bias_level_post (struct snd_soc_card *card, +struct snd_soc_dapm_context *dapm, +enum snd_soc_bias_level level); +int asoc_simple_be_hw_params_fixup (struct snd_soc_pcm_runtime *rtd,struct snd_pcm_hw_params *params);
@@ -128,6 +151,8 @@ int asoc_simple_parse_widgets(struct snd_soc_card *card, char *prefix);int asoc_simple_parse_pin_switches (struct snd_soc_card *card,char *prefix); +int asoc_simple_parse_sysclks (struct asoc_simple_priv *priv,char *prefix); +int asoc_simple_parse_plls (struct asoc_simple_priv *priv,char *prefix); int asoc_simple_init_jack(struct snd_soc_card *card, struct asoc_simple_jack *sjack,
sound/soc/generic/audio-graph-card.c +14 -2
@@ -509,6 +509,14 @@ static int graph_parse_of(struct asoc_simple_priv *priv)return ret; } + ret =asoc_simple_parse_sysclks (priv,NULL ); +if (ret <0 ) +return ret; + + ret =asoc_simple_parse_plls (priv,NULL ); +if (ret <0 ) +return ret; +return asoc_simple_parse_card_name (card,NULL ); }
@@ -642,6 +650,7 @@ static int graph_probe(struct platform_device *pdev) card->dapm_widgets = graph_dapm_widgets; card->num_dapm_widgets =ARRAY_SIZE (graph_dapm_widgets); card->probe = graph_card_probe; +snd_soc_card_set_drvdata (card, priv);memset (&li,0 ,sizeof (li));graph_get_dais_count (priv, &li);
@@ -666,10 +675,13 @@ static int graph_probe(struct platform_device *pdev) goto err; } -snd_soc_card_set_drvdata (card, priv); -asoc_simple_debug_info (priv); +if (priv->num_sysclks || priv->num_plls) { + card->set_bias_level = asoc_simple_set_bias_level; + card->set_bias_level_post = asoc_simple_set_bias_level_post; + } + ret =devm_snd_soc_register_card (dev, card);if (ret <0 ) goto err;
sound/soc/generic/simple-card-utils.c +236 -0
260 lines not on this page · raw message
Signature · 1 line
2.20.1
Richard Fitzgerald
maintainerPATCH v3 6/6 ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15
In reply to Richard FitzgeraldThis adds a devicetree configuration for Raspberry Pi 4b connected to Cirrus Logic Lochnagar 2 audio development board and CS47L15 codec.
The common (codec-independent) Lochnagar 2 configuration is separated into a dtsi to simplify re-using it for other codecs.
--- MAINTAINERS | 1 + arch/arm/boot/dts/Makefile | 1 + ...bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dts | 186 ++++++++++++++++ .../dts/bcm2711-rpi4b-cirrus-lochnagar.dtsi | 201 ++++++++++++++++++ 4 files changed, 389 insertions(+) create mode 100644 arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dts create mode 100644 arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar.dtsi
MAINTAINERS +1 -0
@@ -4193,6 +4193,7 @@ M: Charles Keepax <[email protected]> M: Richard Fitzgerald <[email protected]> L: [email protected] S: Supported +F: arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar* F: Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml F: Documentation/devicetree/bindings/hwmon/cirrus,lochnagar.yaml F: Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
arch/arm/boot/dts/Makefile +1 -0
@@ -93,6 +93,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += \ bcm2837-rpi-3-b-plus.dtb \ bcm2837-rpi-cm3-io3.dtb \ bcm2711-rpi-4-b.dtb \ + bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dtb \ bcm2835-rpi-zero.dtb \ bcm2835-rpi-zero-w.dtb dtb-$(CONFIG_ARCH_BCM_5301X) += \
arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dts new file +186 -0
186 lines not on this page · raw message
arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar.dtsi new file +201 -0
201 lines not on this page · raw message
Signature · 1 line
2.20.1
Re: [PATCH v3 6/6] ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15
Quoted 33 lines · Richard Fitzgerald' via BCM-KERNEL-FEEDBACK-LIST,PDL
This adds a devicetree configuration for Raspberry Pi 4b connected to Cirrus Logic Lochnagar 2 audio development board and CS47L15 codec.
The common (codec-independent) Lochnagar 2 configuration is separated into a dtsi to simplify re-using it for other codecs.
Signed-off-by Richard Fitzgerald <[email protected]>--- MAINTAINERS | 1 + arch/arm/boot/dts/Makefile | 1 + ...bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dts | 186 ++++++++++++++++ .../dts/bcm2711-rpi4b-cirrus-lochnagar.dtsi | 201 ++++++++++++++++++ 4 files changed, 389 insertions(+) create mode 100644 arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dts create mode 100644 arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar.dtsiMAINTAINERS +1
-0@@ -4193,6 +4193,7 @@ M: Charles Keepax <[email protected]> M: Richard Fitzgerald <[email protected]> L: [email protected] S: Supported +F: arch/arm/boot/dts/bcm2711-rpi4b-cirrus-lochnagar* F: Documentation/devicetree/bindings/clock/cirrus,lochnagar.yaml F: Documentation/devicetree/bindings/hwmon/cirrus,lochnagar.yaml F: Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yamlarch/arm/boot/dts/Makefile +0
-0
arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_BCM2835) += \ · line 96
Quoted 4 lines
arch/arm/boot/dts/Makefile +1
-0@@ -93,6 +93,7 @@ dtb-$(CONFIG_ARCH_BCM2835) += \ bcm2837-rpi-3-b-plus.dtb \ bcm2837-rpi-cm3-io3.dtb \ bcm2711-rpi-4-b.dtb \ + bcm2711-rpi4b-cirrus-lochnagar-cs47l15.dtb \
Is there a reason you are not following the convention established above and have this file be named: bcm2711-rpi-4-b-cirrus-lochnagar-cs47l15.dtb?
Signature · 1 line
Florian
Kuninori Morimoto
maintainerRe: [PATCH v3 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks
In reply to Richard FitzgeraldHi Richard
Thank you for your patch.
This is v3 patch, but I think this is the first time for me to receive patch...
Quoted 20 lines
Some codecs need plls and/or sysclks to be configured using the snd_soc_component_set_[sysclk|pll] functions. These drivers cannot necessarily be converted to use the clock framework. If the codec is on a I2C/SPI bus, a nested
clk_getwould be needed to enable the bus clock. But the clock framework does not support nested operations and this would deadlock.This patch adds new dt properties that list phandles of components with the pll/sysclk settings to be applied. Multiple settings can be given for the same phandle to allow for components with multiple clocks and plls. The plls and sysclks are enabled when the card bias level moves to STANDBY and disabled when it moves to OFF.
The implementation does not attempt to handle specifying complex clock ordering interdependencies between components. The plls and sysclks are applied to a component as it is passed to the card set_bias_level/
set_bias_level_postcallbacks. It follows from this that the order components are configured is the order that they are passed to those callbacks.
Quoted 6 lines
Signed-off-by Richard Fitzgerald <[email protected]>--- include/sound/simple_card_utils.h | 25 +++ sound/soc/generic/audio-graph-card.c | 16 +- sound/soc/generic/simple-card-utils.c | 236 ++++++++++++++++++++++++++ 3 files changed, 275 insertions(+), 2 deletions(-)
I understand that you need sysclk/pll and .set_bias_level_xxx(). But I guess makes it generic code is difficult (?).
Thus, as Sameer doing on Tegra, creating custom audio-graph-card is better idea for you ?
# Now I'm creating new audio-graph-card2 which also supports
# overwriting/customizing each/all functions. # It is not full compatible with audio-graph-card, but almost same if you # uses normal connection. # I hope I can post it next year
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Richard Fitzgerald
maintainerRe: [PATCH v3 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks
Quoted 6 lines · Kuninori Morimoto
Hi Richard
Thank you for your patch.
This is v3 patch, but I think this is the first time for me to receive patch...
Yes sorry.
Somehow I missed you off V1 and V2 emails.
Quoted 45 lines
Quoted 21 lines
Some codecs need plls and/or sysclks to be configured using the snd_soc_component_set_[sysclk|pll] functions. These drivers cannot necessarily be converted to use the clock framework. If the codec is on a I2C/SPI bus, a nested
clk_getwould be needed to enable the bus clock. But the clock framework does not support nested operations and this would deadlock.This patch adds new dt properties that list phandles of components with the pll/sysclk settings to be applied. Multiple settings can be given for the same phandle to allow for components with multiple clocks and plls. The plls and sysclks are enabled when the card bias level moves to STANDBY and disabled when it moves to OFF.
The implementation does not attempt to handle specifying complex clock ordering interdependencies between components. The plls and sysclks are applied to a component as it is passed to the card set_bias_level/
set_bias_level_postcallbacks. It follows from this that the order components are configured is the order that they are passed to those callbacks.Quoted 6 lines
Signed-off-by Richard Fitzgerald <[email protected]>--- include/sound/simple_card_utils.h | 25 +++ sound/soc/generic/audio-graph-card.c | 16 +- sound/soc/generic/simple-card-utils.c | 236 ++++++++++++++++++++++++++ 3 files changed, 275 insertions(+), 2 deletions(-)I understand that you need sysclk/pll and .set_bias_level_xxx(). But I guess makes it generic code is difficult (?).
Thus, as Sameer doing on Tegra, creating custom audio-graph-card is better idea for you ?# Now I'm creating new audio-graph-card2 which also supports
# overwriting/customizing each/all functions. # It is not full compatible with audio-graph-card, but almost same if you # uses normal connection. # I hope I can post it next yearThank you for your help !!
Best regards
---
Kuninori Morimoto
Rob Herring
maintainerRe: [PATCH v3 2/6] ASoC: audio-graph-card: Add plls and sysclks DT bindings
In reply to Richard FitzgeraldQuoted 11 lines · Richard Fitzgerald
The audio-graph-card driver has bindings for configuring the clocking for DAIs within a component, but is missing bindings for setting up the PLLs and sysclks of the component.
This patch adds the two new bindings 'plls' and 'sysclks' so that the audio-graph-driver can fully configure the component clocking.
Signed-off-by Richard Fitzgerald <[email protected]>--- .../bindings/sound/audio-graph-card.txt | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+)
This is a schema now in master.
Quoted 91 lines
Documentation/devicetree/bindings/sound/audio-graph-card.txt +72
-0@@ -32,6 +32,40 @@ Required properties: Optional properties: - pa-gpios: GPIO used to control external amplifier. +- plls: A list of component pll settings. There are 4 cells per PLL setting: + - phandle to the node of the codec or cpu component, + - component PLL id, + - component clock source id, + - frequency (in Hz) of the PLL output clock. + + The PLL id and clock source id are specific to the particular component + so see the relevant component driver for the ids. Typically the + clock source id indicates the pin the source clock is connected to. + + The same phandle can appear in multiple entries so that several plls + can be set in the same component. + +- plls-clocks: A list of clock names giving the source clock for each setting + in the plls property. + +- sysclks: A list of component sysclk settings. There are 4 cells per sysclk + setting: + - phandle to the node of the codec or cpu component, + - component sysclk id, + - component clock source id, + - direction of the clock: 0 if the clock is an input to the component, + 1 if it is an output. + + The sysclk id and clock source id are specific to the particular + component so see the relevant component driver for the ids. Typically + the clock source id indicates the pin the source clock is connected to. + + The same phandle can appear in multiple entries so that several sysclks + can be set in the same component. + +- sysclks-clocks: A list of clock names giving the source clock for each setting + in the sysclks property. + ----------------------- Example: Single DAI case -----------------------@@ -335,3 +369,41 @@ Example: Multi DAI with DPCM }; }; }; + +----------------------- +Example: Set component sysclks and PLLs +----------------------- + + sound { + compatible = "audio-graph-card"; + + clocks = <&audioclk>, <&pll1>; + clock-names = "audioclk", "pll1"; + + plls = <&cs47l15 MADERA_FLL1_REFCLK MADERA_FLL_SRC_MCLK1 98304000>; + plls-clocks = "audioclk"; + + sysclks = <&cs47l15 MADERA_CLK_SYSCLK_1 MADERA_CLK_SRC_FLL1 0>; + sysclks-clocks = "pll1"; + + dais = <&cpu_i2s_port>; + + pll1: pll1 { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <98304000>; + }; + }; + + cs47l15: codec@0 { + ... + ports { + #address-cells = <1>; + #size-cells = <0>; + cs47l15_aif1_port: port@0 { + reg = <0>; + cs47l15_aif1: endpoint { + remote-endpoint = <&cpu_i2s_endpoint>; + }; + }; + };Signature · 1 line
2.20.1