Skip to contentSkip to conversation

package/xenomai: smp support needs at least armv6

PATCH New Romain Naour 3 participants 6 messages Feb 2, 2021 – Feb 10, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/xenomai: smp support needs at least armv6

There are no autobuilder failures for this issue, but the following defconfig:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XENOMAI=y
BR2_PACKAGE_XENOMAI_COBALT=y

See:
https://gitlab.denx.de/Xenomai/xenomai/-/blob/v3.1/lib/cobalt/arch/arm/include/asm/xenomai/features.h#L56

---
 package/xenomai/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/xenomai/Config.in +2 -0
index b655733528..b1b02373c3 100644
@@ -110,6 +110,8 @@ endchoice
 config BR2_PACKAGE_XENOMAI_ENABLE_SMP
 	bool "Enable SMP support"
 	default y
+	# SMP not supported below armv6
+	depends on !BR2_ARM_CPU_ARMV4 || !BR2_ARM_CPU_ARMV5
 	help
 	  This option enables SMP support in Xenomai userspace.
 
Signature · 1 line
2.29.2
#1 lore raw

PATCH 2/2 package/xenomai: disable cobalt for armv8

When a armv8 target is used in 32bits mode, xenomai fail to detect the ARM architecture and abord the build. (__ARM_ARCH_7A__ is not defined for armv8 cpus).

There are no autobuilder failures for this issue since cobalt is never selected, but the following defconfig:

BR2_arm=y
BR2_cortex_a53=y
BR2_ARM_FPU_NEON_VFPV4=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XENOMAI=y
BR2_PACKAGE_XENOMAI_COBALT=y

This was initialy reproduced using the raspberrypi3_defconfig with Xenomai package with cobalt selected.

In order to use Xenomai on raspberrypi3 in 32 bits mode, you have to select BR2_cortex_a7. This partially revert the commit a13a388dd444ee047f0e7b8c10f5e6c235ec5004.

See:
https://gitlab.denx.de/Xenomai/xenomai/-/blob/v3.1/lib/cobalt/arch/arm/include/asm/xenomai/features.h#L52

---
 package/xenomai/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/xenomai/Config.in +2 -2
index b1b02373c3..e060bcc46f 100644
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_XENOMAI_COBALT_ARCH_SUPPORTS
 	bool
 	default y
-	depends on BR2_i386 || BR2_x86_64 || (BR2_arm && !BR2_ARM_CPU_ARMV7M) || \
-		BR2_powerpc
+	depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || \
+		(BR2_arm && !BR2_ARM_CPU_ARMV7M && !BR2_ARM_CPU_ARMV8A)
 
 comment "xenomai needs a glibc or uClibc toolchain w/ threads"
 	depends on BR2_USE_MMU
Signature · 1 line
2.29.2
#2 lore raw

PATCH 2/2 package/xenomai: disable cobalt for armv8

Romain, All,

On 2021-02-02 21:56 +0100, Romain Naour spake thusly:

Quoted 34 lines

When a armv8 target is used in 32bits mode, xenomai fail to detect the ARM architecture and abord the build. (__ARM_ARCH_7A__ is not defined for armv8 cpus).

There are no autobuilder failures for this issue since cobalt is never selected, but the following defconfig:

BR2_arm=y
BR2_cortex_a53=y
BR2_ARM_FPU_NEON_VFPV4=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XENOMAI=y
BR2_PACKAGE_XENOMAI_COBALT=y

This was initialy reproduced using the raspberrypi3_defconfig with Xenomai package with cobalt selected.

In order to use Xenomai on raspberrypi3 in 32 bits mode, you have to select BR2_cortex_a7. This partially revert the commit a13a388dd444ee047f0e7b8c10f5e6c235ec5004.

See:
https://gitlab.denx.de/Xenomai/xenomai/-/blob/v3.1/lib/cobalt/arch/arm/include/asm/xenomai/features.h#L52

---
 package/xenomai/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/xenomai/Config.in +0 -0
index b1b02373c3..e060bcc46f 100644

package/xenomai/Config.in line 5

Quoted 7 lines
package/xenomai/Config.in +2 -2
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_XENOMAI_COBALT_ARCH_SUPPORTS
 	bool
 	default y
-	depends on BR2_i386 || BR2_x86_64 || (BR2_arm && !BR2_ARM_CPU_ARMV7M) || \
-		BR2_powerpc
+	depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || \
+		(BR2_arm && !BR2_ARM_CPU_ARMV7M && !BR2_ARM_CPU_ARMV8A)

This condition is starting to look pretty ugly, now... I've changed that to a series of conditional 'default y if $ARCH' statements instead.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 9 lines
package/xenomai/Config.in +0 -0
 comment "xenomai needs a glibc or uClibc toolchain w/ threads"
 	depends on BR2_USE_MMU
Signature · 6 lines
2.29.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 2/2 package/xenomai: disable cobalt for armv8

In reply to Romain Naour
Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

When a armv8 target is used in 32bits mode, xenomai fail to detect the ARM architecture and abord the build. (__ARM_ARCH_7A__ is not defined for armv8 cpus).

There are no autobuilder failures for this issue since cobalt is never selected, but the following defconfig:

BR2_arm=y
BR2_cortex_a53=y
BR2_ARM_FPU_NEON_VFPV4=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XENOMAI=y
BR2_PACKAGE_XENOMAI_COBALT=y

This was initialy reproduced using the raspberrypi3_defconfig with Xenomai package with cobalt selected.

Quoted 8 lines

In order to use Xenomai on raspberrypi3 in 32 bits mode, you have to select BR2_cortex_a7. This partially revert the commit a13a388dd444ee047f0e7b8c10f5e6c235ec5004.

See:
https://gitlab.denx.de/Xenomai/xenomai/-/blob/v3.1/lib/cobalt/arch/arm/include/asm/xenomai/features.h#L52

Committed to 2020.02.x and 2020.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/2 package/xenomai: smp support needs at least armv6

In reply to Romain Naour

Romain, All,

On 2021-02-02 21:56 +0100, Romain Naour spake thusly:

Quoted 21 lines

There are no autobuilder failures for this issue, but the following defconfig:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XENOMAI=y
BR2_PACKAGE_XENOMAI_COBALT=y

See:
https://gitlab.denx.de/Xenomai/xenomai/-/blob/v3.1/lib/cobalt/arch/arm/include/asm/xenomai/features.h#L56

---
 package/xenomai/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/xenomai/Config.in +0 -0
index b655733528..b1b02373c3 100644

package/xenomai/Config.in endchoice · line 114

Quoted 5 lines
package/xenomai/Config.in +2 -0
@@ -110,6 +110,8 @@ endchoice
 config BR2_PACKAGE_XENOMAI_ENABLE_SMP
 	bool "Enable SMP support"
 	default y
+	# SMP not supported below armv6
+	depends on !BR2_ARM_CPU_ARMV4 || !BR2_ARM_CPU_ARMV5

This does not make sense:

- if you are using armv4, then you are not using armv5, and thus the

    condition is true;

- if you are using armv5, then you are not using armv4, and thus the

    condition is true;

- if you are using neither armv4 nor armv5, then the condition is true.

So, the condition is always true...

I've changed that to:

    depends on !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV5

Applied to master with that fixed, thanks.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/xenomai/Config.in +0 -0
 	help
 	  This option enables SMP support in Xenomai userspace.
 
Signature · 6 lines
2.29.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 1/2 package/xenomai: smp support needs at least armv6

In reply to Romain Naour
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

There are no autobuilder failures for this issue, but the following defconfig:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XENOMAI=y
BR2_PACKAGE_XENOMAI_COBALT=y

Quoted 4 lines

See:
https://gitlab.denx.de/Xenomai/xenomai/-/blob/v3.1/lib/cobalt/arch/arm/include/asm/xenomai/features.h#L56

Committed to 2020.02.x and 2020.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard