Skip to contentSkip to conversation

media: rkvdec: Remove of_match_ptr()

PATCH In review Fabio Estevam 2 participants 2 messages Mar 20, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: rkvdec: Remove of_match_ptr()

When building with CONFIG_OF not set, the following clang build warning is seen:

Quoted 1 line
Quoted 1 line

drivers/staging/media/rkvdec/rkvdec.c:967:34: warning: unused variable 'of_rkvdec_match' [-Wunused-const-variable]

Fix the warning by removing the unnecessary of_match_ptr().

Fixes cd33c830448b ("media: rkvdec: Add the rkvdec driver")
---
 drivers/staging/media/rkvdec/rkvdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/rkvdec/rkvdec.c +1 -1
index 225eeca73356..0ff013c1fc38 100644
@@ -1092,7 +1092,7 @@ static struct platform_driver rkvdec_driver = {
 	.remove = rkvdec_remove,
 	.driver = {
 		   .name = "rkvdec",
-		   .of_match_table = of_match_ptr(of_rkvdec_match),
+		   .of_match_table = of_rkvdec_match,
 		   .pm = &rkvdec_pm_ops,
 	},
 };
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Fabio Estevam

When building with CONFIG_OF not set, the following clang build warning is seen:

Quoted 1 line
Quoted 1 line

drivers/staging/media/rkvdec/rkvdec.c:967:34: warning: unused variable 'of_rkvdec_match' [-Wunused-const-variable]

Fix the warning by removing the unnecessary of_match_ptr().

Fixes cd33c830448b ("media: rkvdec: Add the rkvdec driver")

---
 drivers/staging/media/rkvdec/rkvdec.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/rkvdec/rkvdec.c +0 -0
index 225eeca73356..0ff013c1fc38 100644

drivers/staging/media/rkvdec/rkvdec.c static struct platform_driver rkvdec_driver = { · line 1098

Quoted 8 lines
drivers/staging/media/rkvdec/rkvdec.c +1 -1
@@ -1092,7 +1092,7 @@ static struct platform_driver rkvdec_driver = {
         .remove = rkvdec_remove,
         .driver = {
                    .name = "rkvdec",
-                  .of_match_table = of_match_ptr(of_rkvdec_match),
+                  .of_match_table = of_rkvdec_match,
                    .pm = &rkvdec_pm_ops,
         },
  };

Looks good.

Thanks,
Ezequiel