Skip to contentSkip to conversation

ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes

PATCH Superseded Rob Herring 2 participants 2 messages Mar 23, 2021 – Mar 24, 2021

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes

The nvidia,tegra210-ahub binding is missing schema for child nodes. This results in warnings if 'additionalProperties: false' is set (or when the tools implement 'unevaluatedProperties' support). Add the child nodes and reference their schema if one exists.

Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Sameer Pujar <[email protected]>

---
This patch ideally should be applied before this series[1].

[1] https://lore.kernel.org/r/[email protected]/

 .../bindings/sound/nvidia,tegra210-ahub.yaml         | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml +12 -0
index e568d6c7dddd..d7a5eb77ed4f 100644
@@ -69,6 +69,18 @@ properties:
         $ref: audio-graph-port.yaml#
         unevaluatedProperties: false
 
+patternProperties:
+  '^i2s@[0-9a-f]+$':
+    type: object
+
+  '^dmic@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-dmic.yaml#
+
+  '^admaif@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-admaif.yaml#
+
 required:
   - compatible
   - reg
Signature · 1 line
2.27.0
#1 lore raw
Quoted 34 lines · Rob Herring

External email: Use caution opening links or attachments

The nvidia,tegra210-ahub binding is missing schema for child nodes. This results in warnings if 'additionalProperties: false' is set (or when the tools implement 'unevaluatedProperties' support). Add the child nodes and reference their schema if one exists.

Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Sameer Pujar <[email protected]>

---
This patch ideally should be applied before this series[1].

[1] https://lore.kernel.org/r/[email protected]/

  .../bindings/sound/nvidia,tegra210-ahub.yaml         | 12 ++++++++++++
  1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml +2 -0
index e568d6c7dddd..d7a5eb77ed4f 100644
@@ -69,6 +69,18 @@ properties:
          $ref: audio-graph-port.yaml#
          unevaluatedProperties: false
 
+patternProperties:
+  '^i2s@[0-9a-f]+$':

Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml properties: · line 83

Quoted 10 lines
Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml +10 -0
+    type: object
+
+  '^dmic@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-dmic.yaml#
+
+  '^admaif@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-admaif.yaml#
+

There is "dspk@xxx" child node as well for ahub, though schema example does not show this. I am seeing error because of this during "dtbs_check". Wondering if we can add following with this patch?

+ '^dspk@[0-9a-f]+$':
+ type: object
+ $ref: nvidia,tegra186-dspk.yaml#

Quoted 6 lines
Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml +0 -1
  required:
    - compatible
    - reg
--

2.27.0