Skip to contentSkip to conversation

ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes

PATCH In review Rob Herring 4 participants 5 messages Mar 26, 2021 – Mar 30, 2021

Subsystems (3)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH v2 1/1 ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes

The nvidia,tegra210-ahub binding is missing schema for child nodes. This results in warnings if 'additionalProperties: false' is set (or when the tools implement 'unevaluatedProperties' support). Add the child nodes and reference their schema if one exists.

Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Sameer Pujar <[email protected]>

---
v2:
- Also add 'dspk' child node

This patch ideally should be applied before this series[1].

[1] https://lore.kernel.org/r/[email protected]/

---
 .../bindings/sound/nvidia,tegra210-ahub.yaml     | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml +16 -0
index e568d6c7dddd..1118a9488345 100644
@@ -69,6 +69,22 @@ properties:
         $ref: audio-graph-port.yaml#
         unevaluatedProperties: false
 
+patternProperties:
+  '^i2s@[0-9a-f]+$':
+    type: object
+
+  '^dmic@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-dmic.yaml#
+
+  '^admaif@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-admaif.yaml#
+
+  '^dspk@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra186-dspk.yaml#
+
 required:
   - compatible
   - reg
Signature · 1 line
2.27.0
Acked-by on v2 1/1
#1 lore raw
Quoted 17 lines · Rob Herring

The nvidia,tegra210-ahub binding is missing schema for child nodes. This results in warnings if 'additionalProperties: false' is set (or when the tools implement 'unevaluatedProperties' support). Add the child nodes and reference their schema if one exists.

Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Sameer Pujar <[email protected]>

---
v2:
- Also add 'dspk' child node

Quoted 6 lines

This patch ideally should be applied before this series[1].

[1] https://lore.kernel.org/r/[email protected]/

---
 .../bindings/sound/nvidia,tegra210-ahub.yaml     | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Acked-by on v2 1/1
#2 lore raw
In reply to Rob Herring
Quoted 17 lines · Rob Herring

The nvidia,tegra210-ahub binding is missing schema for child nodes. This results in warnings if 'additionalProperties: false' is set (or when the tools implement 'unevaluatedProperties' support). Add the child nodes and reference their schema if one exists.

Cc Liam Girdwood <[email protected]>
Cc Mark Brown <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Sameer Pujar <[email protected]>

---
v2:
- Also add 'dspk' child node

Quoted 6 lines

This patch ideally should be applied before this series[1].

[1] https://lore.kernel.org/r/[email protected]/

---
  .../bindings/sound/nvidia,tegra210-ahub.yaml     | 16 ++++++++++++++++
  1 file changed, 16 insertions(+)
maintainer
#3 lore raw

Re: [PATCH v2] ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes

In reply to Rob Herring
Quoted 4 lines · Rob Herring

The nvidia,tegra210-ahub binding is missing schema for child nodes. This results in warnings if 'additionalProperties: false' is set (or when the tools implement 'unevaluatedProperties' support). Add the child nodes and reference their schema if one exists.

This doesn't apply against current code, please check and resend:

Applying: ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes
error: sha1 information is lacking or useless (Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml).
error: could not build fake ancestor
Patch failed at 0001 ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes

maintainer
#4 lore raw

Re: [PATCH v2] ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes

In reply to Rob Herring
Quoted 4 lines · Rob Herring

The nvidia,tegra210-ahub binding is missing schema for child nodes. This results in warnings if 'additionalProperties: false' is set (or when the tools implement 'unevaluatedProperties' support). Add the child nodes and reference their schema if one exists.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: nvidia, tegra210-ahub: Add missing child nodes

      commit: 8b01a0d0b5c1327296b37a13c37ca7ab31841577

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark