Skip to contentSkip to conversation

pinctrl: bcm: bcm6362: fix warning

PATCH Superseded Álvaro Fernández Rojas 2 participants 2 messages Mar 30, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: bcm: bcm6362: fix warning

The current implementation of bcm6362_set_gpio() produces the following
warning on x86_64:
drivers/pinctrl/bcm/pinctrl-bcm6362.c: In function 'bcm6362_set_gpio':
drivers/pinctrl/bcm/pinctrl-bcm6362.c:503:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

  503 |        (uint32_t) desc->drv_data, 0);
      |        ^

Modify the code to make it similar to bcm63268_set_gpio() in order to fix the warning.

Fixes 705791e23ecd ("pinctrl: add a pincontrol driver for BCM6362")
---
 drivers/pinctrl/bcm/pinctrl-bcm6362.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/pinctrl/bcm/pinctrl-bcm6362.c +4 -3
index eb7ec80353e9..6b5a1dfc2367 100644
@@ -496,11 +496,12 @@ static int bcm6362_pinctrl_get_groups(struct pinctrl_dev *pctldev,
 static void bcm6362_set_gpio(struct bcm63xx_pinctrl *pc, unsigned pin)
 {
 	const struct pinctrl_pin_desc *desc = &bcm6362_pins[pin];
+	unsigned int basemode = (unsigned long) desc->drv_data;
 	unsigned int mask = bcm63xx_bank_pin(pin);
 
-	if (desc->drv_data)
-		regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG,
-				   (uint32_t) desc->drv_data, 0);
+	if (basemode)
+		regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG, basemode,
+				   0);
 
 	if (pin < BCM63XX_BANK_GPIOS) {
 		/* base mode 0 => gpio 1 => mux function */
Signature · 1 line
2.20.1
#1 lore raw
Quoted 22 lines · Álvaro Fernández Rojas

The current implementation of bcm6362_set_gpio() produces the following
warning on x86_64:
drivers/pinctrl/bcm/pinctrl-bcm6362.c: In function 'bcm6362_set_gpio':
drivers/pinctrl/bcm/pinctrl-bcm6362.c:503:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

  503 |        (uint32_t) desc->drv_data, 0);
      |        ^

Modify the code to make it similar to bcm63268_set_gpio() in order to fix the warning.

Fixes 705791e23ecd ("pinctrl: add a pincontrol driver for BCM6362")
---
 drivers/pinctrl/bcm/pinctrl-bcm6362.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/pinctrl/bcm/pinctrl-bcm6362.c +0 -0
index eb7ec80353e9..6b5a1dfc2367 100644

drivers/pinctrl/bcm/pinctrl-bcm6362.c static int bcm6362_pinctrl_get_groups(struct pinctrl_dev *pctldev, · line 499

Quoted 4 lines
drivers/pinctrl/bcm/pinctrl-bcm6362.c +1 -0
@@ -496,11 +496,12 @@ static int bcm6362_pinctrl_get_groups(struct pinctrl_dev *pctldev,
 static void bcm6362_set_gpio(struct bcm63xx_pinctrl *pc, unsigned pin)
 {
        const struct pinctrl_pin_desc *desc = &bcm6362_pins[pin];
+       unsigned int basemode = (unsigned long) desc->drv_data;

Space between ) and d is not needed.
Usually we use uintptr_t for casting pointers to the integers.

drivers/pinctrl/bcm/pinctrl-bcm6362.c static int bcm6362_pinctrl_get_groups(struct pinctrl_dev *pctldev,

Quoted 9 lines
drivers/pinctrl/bcm/pinctrl-bcm6362.c +3 -3
        unsigned int mask = bcm63xx_bank_pin(pin);
 
-       if (desc->drv_data)
-               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG,
-                                  (uint32_t) desc->drv_data, 0);
+       if (basemode)
 
+               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG, basemode,
+                                  0);

Put it on one line for sake of the readability.

Quoted 6 lines
drivers/pinctrl/bcm/pinctrl-bcm6362.c +0 -1
        if (pin < BCM63XX_BANK_GPIOS) {
                /* base mode 0 => gpio 1 => mux function */
--

2.20.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko