Skip to contentSkip to conversation

pinctrl: bcm: bcm6362: fix warning

PATCH In review Álvaro Fernández Rojas 3 participants 4 messages Mar 30, 2021 – Mar 31, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 pinctrl: bcm: bcm6362: fix warning

The current implementation of bcm6362_set_gpio() produces the following
warning on x86_64:
drivers/pinctrl/bcm/pinctrl-bcm6362.c: In function 'bcm6362_set_gpio':
drivers/pinctrl/bcm/pinctrl-bcm6362.c:503:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

  503 |        (uint32_t) desc->drv_data, 0);
      |        ^

Modify the code to make it similar to bcm63268_set_gpio() in order to fix the warning.

Fixes 705791e23ecd ("pinctrl: add a pincontrol driver for BCM6362")
---
 drivers/pinctrl/bcm/pinctrl-bcm6362.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/bcm/pinctrl-bcm6362.c +3 -3
index eb7ec80353e9..40ef495b6301 100644
@@ -496,11 +496,11 @@ static int bcm6362_pinctrl_get_groups(struct pinctrl_dev *pctldev,
 static void bcm6362_set_gpio(struct bcm63xx_pinctrl *pc, unsigned pin)
 {
 	const struct pinctrl_pin_desc *desc = &bcm6362_pins[pin];
+	unsigned int basemode = (uintptr_t)desc->drv_data;
 	unsigned int mask = bcm63xx_bank_pin(pin);
 
-	if (desc->drv_data)
-		regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG,
-				   (uint32_t) desc->drv_data, 0);
+	if (basemode)
+		regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG, basemode, 0);
 
 	if (pin < BCM63XX_BANK_GPIOS) {
 		/* base mode 0 => gpio 1 => mux function */
Signature · 1 line
2.20.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · Álvaro Fernández Rojas

The current implementation of bcm6362_set_gpio() produces the following
warning on x86_64:
drivers/pinctrl/bcm/pinctrl-bcm6362.c: In function 'bcm6362_set_gpio':
drivers/pinctrl/bcm/pinctrl-bcm6362.c:503:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

  503 |        (uint32_t) desc->drv_data, 0);
      |        ^

Modify the code to make it similar to bcm63268_set_gpio() in order to fix the warning.

Seems good to me, thanks!

Quoted 3 lines
Fixes 705791e23ecd ("pinctrl: add a pincontrol driver for BCM6362")

---

Missed changelog here.

Quoted 25 lines
 drivers/pinctrl/bcm/pinctrl-bcm6362.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/bcm/pinctrl-bcm6362.c +3 -4
index eb7ec80353e9..40ef495b6301 100644
@@ -496,11 +496,11 @@ static int bcm6362_pinctrl_get_groups(struct pinctrl_dev *pctldev,
 static void bcm6362_set_gpio(struct bcm63xx_pinctrl *pc, unsigned pin)
 {
        const struct pinctrl_pin_desc *desc = &bcm6362_pins[pin];
+       unsigned int basemode = (uintptr_t)desc->drv_data;
        unsigned int mask = bcm63xx_bank_pin(pin);
 
-       if (desc->drv_data)
-               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG,
-                                  (uint32_t) desc->drv_data, 0);
+       if (basemode)
+               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG, basemode, 0);
 
        if (pin < BCM63XX_BANK_GPIOS) {
                /* base mode 0 => gpio 1 => mux function */
--

2.20.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

Hi Andy,

Quoted 13 lines · Andy Shevchenko
Quoted 10 lines · Álvaro Fernández Rojas

The current implementation of bcm6362_set_gpio() produces the following
warning on x86_64:
drivers/pinctrl/bcm/pinctrl-bcm6362.c: In function 'bcm6362_set_gpio':
drivers/pinctrl/bcm/pinctrl-bcm6362.c:503:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

   503 |        (uint32_t) desc->drv_data, 0);
       |        ^

Modify the code to make it similar to bcm63268_set_gpio() in order to fix the warning.

Quoted 8 lines

Seems good to me, thanks!

Quoted 3 lines
Fixes 705791e23ecd ("pinctrl: add a pincontrol driver for BCM6362")

---

Missed changelog here.

Yes, sorry about that but I added it to v1 patch by mistake... ;D
v2: use uintptr_t, remove unneeded space and modify put regmap_update_bits() call on a single line.

Quoted 21 lines
Quoted 21 lines
  drivers/pinctrl/bcm/pinctrl-bcm6362.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pinctrl/bcm/pinctrl-bcm6362.c +3 -3
index eb7ec80353e9..40ef495b6301 100644
@@ -496,11 +496,11 @@ static int bcm6362_pinctrl_get_groups(struct pinctrl_dev *pctldev,
  static void bcm6362_set_gpio(struct bcm63xx_pinctrl *pc, unsigned pin)
  {
         const struct pinctrl_pin_desc *desc = &bcm6362_pins[pin];
+       unsigned int basemode = (uintptr_t)desc->drv_data;
         unsigned int mask = bcm63xx_bank_pin(pin);
 
-       if (desc->drv_data)
-               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG,
-                                  (uint32_t) desc->drv_data, 0);
+       if (basemode)
+               regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG, basemode, 0);
 
Quoted 7 lines
Quoted 5 lines
drivers/pinctrl/bcm/pinctrl-bcm6362.c +0 -1
         if (pin < BCM63XX_BANK_GPIOS) {
                 /* base mode 0 => gpio 1 => mux function */
--

2.20.1

Best regards,
Álvaro.

#3 lore raw
In reply to Álvaro Fernández Rojas
Quoted 4 lines · Álvaro Fernández Rojas

The current implementation of bcm6362_set_gpio() produces the following
warning on x86_64:
drivers/pinctrl/bcm/pinctrl-bcm6362.c: In function 'bcm6362_set_gpio':
drivers/pinctrl/bcm/pinctrl-bcm6362.c:503:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

Quoted 8 lines
  503 |        (uint32_t) desc->drv_data, 0);
      |        ^

Modify the code to make it similar to bcm63268_set_gpio() in order to fix the warning.

Fixes 705791e23ecd ("pinctrl: add a pincontrol driver for BCM6362")

Patch applied! Thanks!

Yours,
Linus Walleij